From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2544CC433F5 for ; Mon, 21 Feb 2022 11:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356453AbiBULbc (ORCPT ); Mon, 21 Feb 2022 06:31:32 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231432AbiBULba (ORCPT ); Mon, 21 Feb 2022 06:31:30 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C8519E for ; Mon, 21 Feb 2022 03:31:07 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E665B482; Mon, 21 Feb 2022 12:31:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1645443066; bh=Jvc6l7eBJDLiO4Mz0/BV9DgxoksgWkVr/zEEkxGT72I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eMX7WR5lWVi+xTbULf6gyCBtx2KUeIWwt6pdoaWqJmBvMNHiuqtAAt9xX920s1sQx L2MXrA8k84oOmk6U7jUa5MkSCH9LItibhpWYTirLYCZROeZjkaZHPc1DKfgrIfJ0Lt js88O3aqVZWO+yW+CKHteB7M5OkYOulRFOVMFIdw= Date: Mon, 21 Feb 2022 13:30:57 +0200 From: Laurent Pinchart To: Lucas Stach Cc: Shawn Guo , Rob Herring , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patchwork-lst@pengutronix.de Subject: Re: [PATCH v2 7/9] arm64: dts: imx8mp: add HSIO power-domains Message-ID: References: <20220207192547.1997549-1-l.stach@pengutronix.de> <20220207192547.1997549-7-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Lucas, On Sun, Feb 20, 2022 at 07:56:11AM +0200, Laurent Pinchart wrote: > On Sat, Feb 19, 2022 at 09:40:50AM +0200, Laurent Pinchart wrote: > > On Mon, Feb 07, 2022 at 08:25:45PM +0100, Lucas Stach wrote: > > > This adds the GPC and HSIO blk-ctrl nodes providing power control for > > > the high-speed (USB and PCIe) IOs. > > > > > > Signed-off-by: Lucas Stach > > > --- > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 63 ++++++++++++++++++++--- > > > 1 file changed, 57 insertions(+), 6 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > index 6b840c05dd77..dc488a147d0c 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > @@ -4,6 +4,7 @@ > > > */ > > > > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -475,6 +476,44 @@ src: reset-controller@30390000 { > > > interrupts = ; > > > #reset-cells = <1>; > > > }; > > > + > > > + gpc: gpc@303a0000 { > > > + compatible = "fsl,imx8mp-gpc"; > > > + reg = <0x303a0000 0x10000>; > > > > According to the reference manual, the GPC occupies 4kB, not 64kB. > > > > > + interrupt-parent = <&gic>; > > > + interrupt-controller; > > > + #interrupt-cells = <3>; > > > + > > > + pgc { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > > We're working on support for the MEDIAMIX power domains, which we'll > > rebase on top of this. In case the HSIO part still needs more work, > > could you split this patch in two, with one patch that adds the PGC, > > with an empty pgc nodde, and a second patch that adds the HSIO-related > > power domains ? The first one could then be merged faster (it would be > > great if it could get in v5.18). > > > > > + pgc_pcie_phy: power-domain@1 { > > > + #power-domain-cells = <0>; > > > + reg = ; > > > + }; > > > + > > > + pgc_usb1_phy: power-domain@2 { > > > + #power-domain-cells = <0>; > > > + reg = ; > > > + }; > > > + > > > + pgc_usb2_phy: power-domain@3 { > > > + #power-domain-cells = <0>; > > > + reg = ; > > > + }; > > > + > > > + pgc_hsiomix: power-domains@17 { > > > + #power-domain-cells = <0>; > > > + reg = ; > > > + clocks = <&clk IMX8MP_CLK_HSIO_AXI>, > > > + <&clk IMX8MP_CLK_HSIO_ROOT>; > > > + assigned-clocks = <&clk IMX8MP_CLK_HSIO_AXI>; > > > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>; > > > + assigned-clock-rates = <500000000>; > > > + }; > > > + }; > > > + }; > > > }; > > > > > > aips2: bus@30400000 { > > > @@ -908,6 +947,20 @@ ddr-pmu@3d800000 { > > > interrupts = ; > > > }; > > > > > > + hsio_blk_ctrl: blk-ctrl@32f10000 { > > > + compatible = "fsl,imx8mp-hsio-blk-ctrl", "syscon"; > > > + reg = <0x32f10000 0x24>; > > > + clocks = <&clk IMX8MP_CLK_USB_ROOT>, > > > + <&clk IMX8MP_CLK_PCIE_ROOT>; > > > + clock-names = "usb", "pcie"; > > > + power-domains = <&pgc_hsiomix>, <&pgc_hsiomix>, > > > + <&pgc_usb1_phy>, <&pgc_usb2_phy>, > > > + <&pgc_hsiomix>, <&pgc_pcie_phy>; > > > > Would it be useful to rework the driver to avoid specifying the same > > parent power domain multiple times in DT ? > > > > > + power-domain-names = "bus", "usb", "usb-phy1", > > > + "usb-phy2", "pcie", "pcie-phy"; > > > + #power-domain-cells = <1>; > > > + }; > > Shouldn't this be in an aips4 node ? With the reg size fixed, and this device moved to an aips4 node, Reviewed-by: Laurent Pinchart > > > + > > > usb3_phy0: usb-phy@381f0040 { > > > compatible = "fsl,imx8mp-usb-phy"; > > > reg = <0x381f0040 0x40>; > > > @@ -915,6 +968,7 @@ usb3_phy0: usb-phy@381f0040 { > > > clock-names = "phy"; > > > assigned-clocks = <&clk IMX8MP_CLK_USB_PHY_REF>; > > > assigned-clock-parents = <&clk IMX8MP_CLK_24M>; > > > + power-domains = <&hsio_blk_ctrl IMX8MP_HSIOBLK_PD_USB_PHY1>; > > > #phy-cells = <0>; > > > status = "disabled"; > > > }; > > > @@ -926,6 +980,7 @@ usb3_0: usb@32f10100 { > > > <&clk IMX8MP_CLK_USB_ROOT>; > > > clock-names = "hsio", "suspend"; > > > interrupts = ; > > > + power-domains = <&hsio_blk_ctrl IMX8MP_HSIOBLK_PD_USB>; > > > #address-cells = <1>; > > > #size-cells = <1>; > > > dma-ranges = <0x40000000 0x40000000 0xc0000000>; > > > @@ -939,9 +994,6 @@ usb_dwc3_0: usb@38100000 { > > > <&clk IMX8MP_CLK_USB_CORE_REF>, > > > <&clk IMX8MP_CLK_USB_ROOT>; > > > clock-names = "bus_early", "ref", "suspend"; > > > - assigned-clocks = <&clk IMX8MP_CLK_HSIO_AXI>; > > > - assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>; > > > - assigned-clock-rates = <500000000>; > > > interrupts = ; > > > phys = <&usb3_phy0>, <&usb3_phy0>; > > > phy-names = "usb2-phy", "usb3-phy"; > > > @@ -957,6 +1009,7 @@ usb3_phy1: usb-phy@382f0040 { > > > clock-names = "phy"; > > > assigned-clocks = <&clk IMX8MP_CLK_USB_PHY_REF>; > > > assigned-clock-parents = <&clk IMX8MP_CLK_24M>; > > > + power-domains = <&hsio_blk_ctrl IMX8MP_HSIOBLK_PD_USB_PHY2>; > > > #phy-cells = <0>; > > > }; > > > > > > @@ -967,6 +1020,7 @@ usb3_1: usb@32f10108 { > > > <&clk IMX8MP_CLK_USB_ROOT>; > > > clock-names = "hsio", "suspend"; > > > interrupts = ; > > > + power-domains = <&hsio_blk_ctrl IMX8MP_HSIOBLK_PD_USB>; > > > #address-cells = <1>; > > > #size-cells = <1>; > > > dma-ranges = <0x40000000 0x40000000 0xc0000000>; > > > @@ -980,9 +1034,6 @@ usb_dwc3_1: usb@38200000 { > > > <&clk IMX8MP_CLK_USB_CORE_REF>, > > > <&clk IMX8MP_CLK_USB_ROOT>; > > > clock-names = "bus_early", "ref", "suspend"; > > > - assigned-clocks = <&clk IMX8MP_CLK_HSIO_AXI>; > > > - assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>; > > > - assigned-clock-rates = <500000000>; > > > interrupts = ; > > > phys = <&usb3_phy1>, <&usb3_phy1>; > > > phy-names = "usb2-phy", "usb3-phy"; > > > -- Regards, Laurent Pinchart