From: Jonathan McDowell <noodles@earth.li>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/18] ARM: dts: qcom: disable smb208 regulators for ipq8064-rb3011
Date: Tue, 22 Feb 2022 18:53:50 +0000 [thread overview]
Message-ID: <YhUxPigWzLOffcZM@earth.li> (raw)
In-Reply-To: <20220218002956.6590-5-ansuelsmth@gmail.com>
On Fri, Feb 18, 2022 at 01:29:42AM +0100, Ansuel Smith wrote:
> Mikrotik RB3011 have a special configuration where the regulators are
> not the common smb208 controlled by RPM but they use a TPS563900
> controlled via i2c. Disable the smb208 for this specific device.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> index 596d129d4a95..0982b6214fb7 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> @@ -216,6 +216,10 @@ led@7 {
> };
> };
>
> +&smb208_regulators {
> + status = "disabled";
> +}
Missing ; after the }, but with that:
Reviewed-by: Jonathan McDowell <noodles@earth.li>
Tested-by: Jonathan McDowell <noodles@earth.li>
> +
> &adm_dma {
> status = "okay";
> };
> --
> 2.34.1
>
J.
--
/-\ | Design a system any fool can use,
|@/ Debian GNU/Linux Developer | and only a fool will want to use
\- | it.
next prev parent reply other threads:[~2022-02-22 18:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 0:29 [PATCH v2 00/18] Multiple addition to ipq8064 dtsi Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 01/18] ARM: dts: qcom: add multiple missing pin definition for ipq8064 Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 02/18] ARM: dts: qcom: add gsbi6 missing " Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 03/18] ARM: dts: qcom: add missing rpm regulators and cells " Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 04/18] ARM: dts: qcom: disable smb208 regulators for ipq8064-rb3011 Ansuel Smith
2022-02-22 18:53 ` Jonathan McDowell [this message]
2022-02-18 0:29 ` [PATCH v2 05/18] ARM: dts: qcom: add missing snps,dwmac compatible for gmac ipq8064 Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 06/18] ARM: dts: qcom: enable usb phy by default for ipq8064 Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 07/18] ARM: dts: qcom: reduce pci IO size to 64K " Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 08/18] ARM: dts: qcom: fix dtc warning for missing #address-cells " Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 09/18] ARM: dts: qcom: add smem node " Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 10/18] ARM: dts: qcom: add saw for l2 cache and kraitcc " Ansuel Smith
2022-02-22 20:01 ` Jonathan McDowell
2022-02-24 17:49 ` Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 11/18] ARM: dts: qcom: add sic non secure node " Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 12/18] ARM: dts: qcom: fix and add some missing gsbi " Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 13/18] ARM: dts: qcom: add opp table for cpu and l2 " Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 14/18] ARM: dts: qcom: add speedbin efuse nvmem binding Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 15/18] ARM: dts: qcom: add multiple missing binding for cpu and l2 for ipq8064 Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 16/18] ARM: dts: qcom: remove redundant binding from ipq8064 rb3011 dts Ansuel Smith
2022-02-18 14:11 ` Jonathan McDowell
2022-02-19 19:08 ` Jonathan McDowell
2022-02-20 14:50 ` Ansuel Smith
2022-02-20 14:44 ` Ansuel Smith
2022-02-22 18:29 ` Jonathan McDowell
2022-02-18 0:29 ` [PATCH v2 17/18] ARM: dts: qcom: add ipq8064-v2.0 dtsi Ansuel Smith
2022-02-18 0:29 ` [PATCH v2 18/18] ARM: dts: qcom: add ipq8065 dtsi Ansuel Smith
2022-02-22 20:06 ` [PATCH v2 00/18] Multiple addition to ipq8064 dtsi Jonathan McDowell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhUxPigWzLOffcZM@earth.li \
--to=noodles@earth.li \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).