[PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex

[PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex

[Krzysztof Kozlowski]

Intel Agilex USB DWC2 node is used as compatible with generic snps,dwc2
(just like Altera's Stratix10).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 481aaa09f3f2..048e352c531a 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -41,6 +41,7 @@ properties:
               - amlogic,meson8b-usb
               - amlogic,meson-gxbb-usb
               - amlogic,meson-g12a-usb
+              - intel,socfpga-agilex-hsotg
           - const: snps,dwc2
       - const: amcc,dwc-otg
       - const: apm,apm82181-dwc-otg
@@ -53,7 +54,6 @@ properties:
           - const: st,stm32mp15-hsotg
           - const: snps,dwc2
       - const: samsung,s3c6400-hsotg
-      - const: intel,socfpga-agilex-hsotg
 
   reg:
     maxItems: 1
-- 
2.32.0

[PATCH 2/4] dt-bindings: usb: dwc2: add iommus

[Krzysztof Kozlowski]

The DWC2 node might use IOMMU (e.g. Altera Stratix10), so add "iommus"
property.  This fixes warnings like:

  arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml:
    usb@ffb40000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 048e352c531a..1ba96706bbcb 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -68,6 +68,9 @@ properties:
     items:
       - const: otg
 
+  iommus:
+    maxItems: 1
+
   resets:
     items:
       - description: common reset
-- 
2.32.0

Re: [PATCH 2/4] dt-bindings: usb: dwc2: add iommus

[Rob Herring]

On Fri, 18 Feb 2022 17:15:20 +0100, Krzysztof Kozlowski wrote:
> The DWC2 node might use IOMMU (e.g. Altera Stratix10), so add "iommus"
> property.  This fixes warnings like:
> 
>   arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml:
>     usb@ffb40000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc2.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

[PATCH 3/4] dt-bindings: usb: dwc2: add disable-over-current

[Krzysztof Kozlowski]

The driver parses disable-over-current protection and some
implementations use it (e.g. Altera Stratix10), so document it in the
bindings.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 1ba96706bbcb..1addab83f4fd 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -68,6 +68,10 @@ properties:
     items:
       - const: otg
 
+  disable-over-current:
+    type: boolean
+    description: whether to disable detection of over-current condition.
+
   iommus:
     maxItems: 1
 
-- 
2.32.0

Re: [PATCH 3/4] dt-bindings: usb: dwc2: add disable-over-current

[Rob Herring]

On Fri, 18 Feb 2022 17:15:21 +0100, Krzysztof Kozlowski wrote:
> The driver parses disable-over-current protection and some
> implementations use it (e.g. Altera Stratix10), so document it in the
> bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

[PATCH 4/4] arm64: dts: agilex/stratix10: add clock-names to USB DWC2 node

[Krzysztof Kozlowski]

USB DWC2 requires clock-names:

  arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml:
    usb@ffb00000: 'clock-names' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 1 +
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index 3ec301bd08a9..d7d1918ae471 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -484,6 +484,7 @@ usb0: usb@ffb00000 {
 			resets = <&rst USB0_RESET>, <&rst USB0_OCP_RESET>;
 			reset-names = "dwc2", "dwc2-ecc";
 			clocks = <&clkmgr STRATIX10_USB_CLK>;
+			clock-names = "otg";
 			iommus = <&smmu 6>;
 			status = "disabled";
 		};
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index f4270cf18996..984c71b850c9 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -510,6 +510,7 @@ usb0: usb@ffb00000 {
 			resets = <&rst USB0_RESET>, <&rst USB0_OCP_RESET>;
 			reset-names = "dwc2", "dwc2-ecc";
 			clocks = <&clkmgr AGILEX_USB_CLK>;
+			clock-names = "otg";
 			iommus = <&smmu 6>;
 			status = "disabled";
 		};
-- 
2.32.0

Re: [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex

[Rob Herring]

On Fri, 18 Feb 2022 17:15:19 +0100, Krzysztof Kozlowski wrote:
> Intel Agilex USB DWC2 node is used as compatible with generic snps,dwc2
> (just like Altera's Stratix10).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc2.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/4] dt-bindings: usb: dwc2: fix compatible of Intel Agilex

[Dinh Nguyen]

All patches applied!

Thanks,
Dinh

On 2/18/22 10:15, Krzysztof Kozlowski wrote:
> Intel Agilex USB DWC2 node is used as compatible with generic snps,dwc2
> (just like Altera's Stratix10).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>   Documentation/devicetree/bindings/usb/dwc2.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 481aaa09f3f2..048e352c531a 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -41,6 +41,7 @@ properties:
>                 - amlogic,meson8b-usb
>                 - amlogic,meson-gxbb-usb
>                 - amlogic,meson-g12a-usb
> +              - intel,socfpga-agilex-hsotg
>             - const: snps,dwc2
>         - const: amcc,dwc-otg
>         - const: apm,apm82181-dwc-otg
> @@ -53,7 +54,6 @@ properties:
>             - const: st,stm32mp15-hsotg
>             - const: snps,dwc2
>         - const: samsung,s3c6400-hsotg
> -      - const: intel,socfpga-agilex-hsotg
>   
>     reg:
>       maxItems: 1