From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Taniya Das <tdas@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 06/16] clk: qcom: gcc-ipq806x: use ARRAY_SIZE for num_parents
Date: Wed, 23 Feb 2022 21:49:11 -0600 [thread overview]
Message-ID: <YhcANw99BMk9PHTS@builder.lan> (raw)
In-Reply-To: <20220217235703.26641-7-ansuelsmth@gmail.com>
On Thu 17 Feb 17:56 CST 2022, Ansuel Smith wrote:
> Use ARRAY_SIZE for num_parents instead of hardcoding the value.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> drivers/clk/qcom/gcc-ipq806x.c | 68 +++++++++++++++++-----------------
> 1 file changed, 34 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c
> index 828383c30322..f6db7247835e 100644
> --- a/drivers/clk/qcom/gcc-ipq806x.c
> +++ b/drivers/clk/qcom/gcc-ipq806x.c
> @@ -373,7 +373,7 @@ static struct clk_rcg gsbi1_uart_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi1_uart_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -424,7 +424,7 @@ static struct clk_rcg gsbi2_uart_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi2_uart_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -475,7 +475,7 @@ static struct clk_rcg gsbi4_uart_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi4_uart_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -526,7 +526,7 @@ static struct clk_rcg gsbi5_uart_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi5_uart_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -577,7 +577,7 @@ static struct clk_rcg gsbi6_uart_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi6_uart_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -628,7 +628,7 @@ static struct clk_rcg gsbi7_uart_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi7_uart_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -692,7 +692,7 @@ static struct clk_rcg gsbi1_qup_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi1_qup_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -743,7 +743,7 @@ static struct clk_rcg gsbi2_qup_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi2_qup_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -794,7 +794,7 @@ static struct clk_rcg gsbi4_qup_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi4_qup_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -845,7 +845,7 @@ static struct clk_rcg gsbi5_qup_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi5_qup_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -896,7 +896,7 @@ static struct clk_rcg gsbi6_qup_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi6_qup_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -947,7 +947,7 @@ static struct clk_rcg gsbi7_qup_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gsbi7_qup_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -1099,7 +1099,7 @@ static struct clk_rcg gp0_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gp0_src",
> .parent_data = gcc_pxo_pll8_cxo,
> - .num_parents = 3,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_cxo),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_PARENT_GATE,
> },
> @@ -1150,7 +1150,7 @@ static struct clk_rcg gp1_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gp1_src",
> .parent_data = gcc_pxo_pll8_cxo,
> - .num_parents = 3,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_cxo),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_RATE_GATE,
> },
> @@ -1201,7 +1201,7 @@ static struct clk_rcg gp2_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gp2_src",
> .parent_data = gcc_pxo_pll8_cxo,
> - .num_parents = 3,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_cxo),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_RATE_GATE,
> },
> @@ -1257,7 +1257,7 @@ static struct clk_rcg prng_src = {
> .hw.init = &(struct clk_init_data){
> .name = "prng_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> },
> },
> @@ -1321,7 +1321,7 @@ static struct clk_rcg sdc1_src = {
> .hw.init = &(struct clk_init_data){
> .name = "sdc1_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> },
> }
> @@ -1371,7 +1371,7 @@ static struct clk_rcg sdc3_src = {
> .hw.init = &(struct clk_init_data){
> .name = "sdc3_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> },
> }
> @@ -1456,7 +1456,7 @@ static struct clk_rcg tsif_ref_src = {
> .hw.init = &(struct clk_init_data){
> .name = "tsif_ref_src",
> .parent_data = gcc_pxo_pll8,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8),
> .ops = &clk_rcg_ops,
> },
> }
> @@ -1620,7 +1620,7 @@ static struct clk_rcg pcie_ref_src = {
> .hw.init = &(struct clk_init_data){
> .name = "pcie_ref_src",
> .parent_data = gcc_pxo_pll3,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll3),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_RATE_GATE,
> },
> @@ -1714,7 +1714,7 @@ static struct clk_rcg pcie1_ref_src = {
> .hw.init = &(struct clk_init_data){
> .name = "pcie1_ref_src",
> .parent_data = gcc_pxo_pll3,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll3),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_RATE_GATE,
> },
> @@ -1808,7 +1808,7 @@ static struct clk_rcg pcie2_ref_src = {
> .hw.init = &(struct clk_init_data){
> .name = "pcie2_ref_src",
> .parent_data = gcc_pxo_pll3,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll3),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_RATE_GATE,
> },
> @@ -1907,7 +1907,7 @@ static struct clk_rcg sata_ref_src = {
> .hw.init = &(struct clk_init_data){
> .name = "sata_ref_src",
> .parent_data = gcc_pxo_pll3,
> - .num_parents = 2,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll3),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_RATE_GATE,
> },
> @@ -2048,7 +2048,7 @@ static struct clk_rcg usb30_master_clk_src = {
> .hw.init = &(struct clk_init_data){
> .name = "usb30_master_ref_src",
> .parent_data = gcc_pxo_pll8_pll0,
> - .num_parents = 3,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll0),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_RATE_GATE,
> },
> @@ -2122,7 +2122,7 @@ static struct clk_rcg usb30_utmi_clk = {
> .hw.init = &(struct clk_init_data){
> .name = "usb30_utmi_clk",
> .parent_data = gcc_pxo_pll8_pll0,
> - .num_parents = 3,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll0),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_RATE_GATE,
> },
> @@ -2196,7 +2196,7 @@ static struct clk_rcg usb_hs1_xcvr_clk_src = {
> .hw.init = &(struct clk_init_data){
> .name = "usb_hs1_xcvr_src",
> .parent_data = gcc_pxo_pll8_pll0,
> - .num_parents = 3,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll0),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_RATE_GATE,
> },
> @@ -2262,7 +2262,7 @@ static struct clk_rcg usb_fs1_xcvr_clk_src = {
> .hw.init = &(struct clk_init_data){
> .name = "usb_fs1_xcvr_src",
> .parent_data = gcc_pxo_pll8_pll0,
> - .num_parents = 3,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll0),
> .ops = &clk_rcg_ops,
> .flags = CLK_SET_RATE_GATE,
> },
> @@ -2398,7 +2398,7 @@ static struct clk_dyn_rcg gmac_core1_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gmac_core1_src",
> .parent_data = gcc_pxo_pll8_pll14_pll18_pll0,
> - .num_parents = 5,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll14_pll18_pll0),
> .ops = &clk_dyn_rcg_ops,
> },
> },
> @@ -2470,7 +2470,7 @@ static struct clk_dyn_rcg gmac_core2_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gmac_core2_src",
> .parent_data = gcc_pxo_pll8_pll14_pll18_pll0,
> - .num_parents = 5,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll14_pll18_pll0),
> .ops = &clk_dyn_rcg_ops,
> },
> },
> @@ -2542,7 +2542,7 @@ static struct clk_dyn_rcg gmac_core3_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gmac_core3_src",
> .parent_data = gcc_pxo_pll8_pll14_pll18_pll0,
> - .num_parents = 5,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll14_pll18_pll0),
> .ops = &clk_dyn_rcg_ops,
> },
> },
> @@ -2614,7 +2614,7 @@ static struct clk_dyn_rcg gmac_core4_src = {
> .hw.init = &(struct clk_init_data){
> .name = "gmac_core4_src",
> .parent_data = gcc_pxo_pll8_pll14_pll18_pll0,
> - .num_parents = 5,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll14_pll18_pll0),
> .ops = &clk_dyn_rcg_ops,
> },
> },
> @@ -2674,7 +2674,7 @@ static struct clk_dyn_rcg nss_tcm_src = {
> .hw.init = &(struct clk_init_data){
> .name = "nss_tcm_src",
> .parent_data = gcc_pxo_pll8_pll14_pll18_pll0,
> - .num_parents = 5,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll14_pll18_pll0),
> .ops = &clk_dyn_rcg_ops,
> },
> },
> @@ -2752,7 +2752,7 @@ static struct clk_dyn_rcg ubi32_core1_src_clk = {
> .hw.init = &(struct clk_init_data){
> .name = "ubi32_core1_src_clk",
> .parent_data = gcc_pxo_pll8_pll14_pll18_pll0,
> - .num_parents = 5,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll14_pll18_pll0),
> .ops = &clk_dyn_rcg_ops,
> .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE,
> },
> @@ -2805,7 +2805,7 @@ static struct clk_dyn_rcg ubi32_core2_src_clk = {
> .hw.init = &(struct clk_init_data){
> .name = "ubi32_core2_src_clk",
> .parent_data = gcc_pxo_pll8_pll14_pll18_pll0,
> - .num_parents = 5,
> + .num_parents = ARRAY_SIZE(gcc_pxo_pll8_pll14_pll18_pll0),
> .ops = &clk_dyn_rcg_ops,
> .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE,
> },
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-02-24 3:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 23:56 [PATCH v4 00/16] Multiple addition and improvement to ipq8064 gcc Ansuel Smith
2022-02-17 23:56 ` [PATCH v4 01/16] dt-bindings: clock: split qcom,gcc.yaml to common and specific schema Ansuel Smith
2022-02-24 3:38 ` Bjorn Andersson
2022-02-17 23:56 ` [PATCH v4 02/16] dt-bindings: clock: simplify qcom,gcc-apq8064 Documentation Ansuel Smith
2022-02-24 3:41 ` Bjorn Andersson
2022-02-17 23:56 ` [PATCH v4 03/16] dt-bindings: clock: Document qcom,gcc-ipq8064 binding Ansuel Smith
2022-02-24 3:42 ` Bjorn Andersson
2022-02-17 23:56 ` [PATCH v4 04/16] clk: qcom: gcc-ipq806x: fix wrong naming for gcc_pxo_pll8_pll0 Ansuel Smith
2022-02-24 3:43 ` Bjorn Andersson
2022-02-17 23:56 ` [PATCH v4 05/16] clk: qcom: gcc-ipq806x: convert parent_names to parent_data Ansuel Smith
2022-02-24 3:48 ` Bjorn Andersson
2022-02-24 15:45 ` Ansuel Smith
2022-02-24 16:08 ` Bjorn Andersson
2022-02-17 23:56 ` [PATCH v4 06/16] clk: qcom: gcc-ipq806x: use ARRAY_SIZE for num_parents Ansuel Smith
2022-02-24 3:49 ` Bjorn Andersson [this message]
2022-02-17 23:56 ` [PATCH v4 07/16] clk: qcom: gcc-ipq806x: drop hardcoded pxo and cxo source clk Ansuel Smith
2022-02-24 3:50 ` Bjorn Andersson
2022-02-24 15:50 ` Ansuel Smith
2022-02-24 16:15 ` Bjorn Andersson
2022-02-17 23:56 ` [PATCH v4 08/16] clk: qcom: gcc-ipq806x: add additional freq nss cores Ansuel Smith
2022-02-24 3:55 ` Bjorn Andersson
2022-02-24 15:55 ` Ansuel Smith
2022-02-24 16:17 ` Bjorn Andersson
2022-02-17 23:56 ` [PATCH v4 09/16] clk: qcom: gcc-ipq806x: add unusued flag for critical clock Ansuel Smith
2022-02-17 23:56 ` [PATCH v4 10/16] clk: qcom: clk-rcg: add clk_rcg_floor_ops ops Ansuel Smith
2022-02-24 3:58 ` Bjorn Andersson
2022-02-17 23:56 ` [PATCH v4 11/16] clk: qcom: gcc-ipq806x: add additional freq for sdc table Ansuel Smith
2022-02-17 23:56 ` [PATCH v4 12/16] dt-bindings: clock: add ipq8064 ce5 clk define Ansuel Smith
2022-02-24 4:01 ` Bjorn Andersson
2022-02-24 16:01 ` Ansuel Smith
2022-02-24 16:18 ` Bjorn Andersson
2022-02-17 23:57 ` [PATCH v4 13/16] clk: qcom: gcc-ipq806x: add CryptoEngine clocks Ansuel Smith
2022-02-17 23:57 ` [PATCH v4 14/16] dt-bindings: reset: add ipq8064 ce5 resets Ansuel Smith
2022-02-24 4:01 ` Bjorn Andersson
2022-02-24 16:31 ` Philipp Zabel
2022-02-17 23:57 ` [PATCH v4 15/16] clk: qcom: gcc-ipq806x: add CryptoEngine resets Ansuel Smith
2022-02-17 23:57 ` [PATCH v4 16/16] ARM: dts: qcom: Add syscon and cxo/pxo clock to gcc node for ipq8064 Ansuel Smith
2022-02-24 4:08 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhcANw99BMk9PHTS@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).