From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD869C433FE for ; Thu, 24 Feb 2022 03:50:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbiBXDuq (ORCPT ); Wed, 23 Feb 2022 22:50:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbiBXDup (ORCPT ); Wed, 23 Feb 2022 22:50:45 -0500 Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0F54234016 for ; Wed, 23 Feb 2022 19:50:16 -0800 (PST) Received: by mail-oo1-xc30.google.com with SMTP id i10-20020a4aab0a000000b002fccf890d5fso1703268oon.5 for ; Wed, 23 Feb 2022 19:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YX+8SJVk0oliJ3pEu4ZMjuzH+FEJiz0kXUJ+6yLv9a4=; b=GA90Bpj8f/3QLmmY2xQqr8xq+ilH5tEUvsH11kAFRgyfYarduXU7XRPIiOH5yE81IB o2uD+ecmbi5A1PhoB++9M+aZgJwciRkK2iES4b0oYLvjRmOx7+XEb7rT5NC8D9vJ/Tun sk85rMK4Hi05XxQFYG3O/8cCI44k4R6QOM7XQTPHiORfV9KQ9pbi4OVmOKzFZHm3FC89 SW5hxuG1YIqDQJ+jusCORyRQOdu02/7RgaL1zFTNDUbTZTgw9OHUObyxynkBt4qPa3zn OVkkkBHUEEvvOJFQB4WCgFUbgXzXIH+B0NU4g+8fe/pp9t3SzNmZbaNKuOk5pMcCAAEu 9e9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YX+8SJVk0oliJ3pEu4ZMjuzH+FEJiz0kXUJ+6yLv9a4=; b=IieNWGHwiDKxi3WNAuSU5fF/MI0qXN+z/53nE9dTjz7FU2jGI214Ob/OcAMHDKQUSe rAa/rxXSqGYOCEV2oiDrrosX2z8gXxk8Div8JzrrrlON9M70RoYETkqEkj1TTLohTmD+ okHrLaXa5YkpjaMVo2Q3lcj5u7Jn/QKw1ezb3xBWq60+Lvzjljh/EHdnQvVWCcTBEfj7 SMiHawwN3FSEco9iJocofDDRCRfhUShDxW0idhDi6b7PcNOwgCSpjhKMjVfB8Ehvvwtx 73hpMS8GRHkZcGO4kaKPbisG+M4o++LXFWIOEl/ELbPvPjmitsPqLVH2L7BCQtU+E/YK YfMA== X-Gm-Message-State: AOAM533qeCqXgPSptPVzhlMbMV9d7wg6KrAGEDoYUpCz3CnsLPqrCjIX ywoTYTM1JMpfN2sDwvgGHYXztA== X-Google-Smtp-Source: ABdhPJwfPVEYmjXLEJZtJLB3Y6ke4eOm2bx2wvBFvPmm0pp7LB7bFxCVEHhSH1ML96DFDxbNe+fzFw== X-Received: by 2002:a05:6870:832a:b0:cc:f848:1651 with SMTP id p42-20020a056870832a00b000ccf8481651mr316226oae.347.1645674616380; Wed, 23 Feb 2022 19:50:16 -0800 (PST) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id o2sm645821otl.9.2022.02.23.19.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 19:50:15 -0800 (PST) Date: Wed, 23 Feb 2022 21:50:14 -0600 From: Bjorn Andersson To: Ansuel Smith Cc: Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Philipp Zabel , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 07/16] clk: qcom: gcc-ipq806x: drop hardcoded pxo and cxo source clk Message-ID: References: <20220217235703.26641-1-ansuelsmth@gmail.com> <20220217235703.26641-8-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220217235703.26641-8-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 17 Feb 17:56 CST 2022, Ansuel Smith wrote: > We now define these clk in dts. Drop pxo and cxo hardcoded in the gcc > probe function. > As noted on the previous patch, this breaks booting with existing dtbs. So I would like to split this with 1-2 releases in between to avoid any problems. Reviewed-by: Bjorn Andersson on the change though. Regards, Bjorn > Signed-off-by: Ansuel Smith > --- > drivers/clk/qcom/gcc-ipq806x.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c > index f6db7247835e..a4bf78fe8678 100644 > --- a/drivers/clk/qcom/gcc-ipq806x.c > +++ b/drivers/clk/qcom/gcc-ipq806x.c > @@ -3119,23 +3119,14 @@ MODULE_DEVICE_TABLE(of, gcc_ipq806x_match_table); > > static int gcc_ipq806x_probe(struct platform_device *pdev) > { > - struct device *dev = &pdev->dev; > struct regmap *regmap; > int ret; > > - ret = qcom_cc_register_board_clk(dev, "cxo_board", "cxo", 25000000); > - if (ret) > - return ret; > - > - ret = qcom_cc_register_board_clk(dev, "pxo_board", "pxo", 25000000); > - if (ret) > - return ret; > - > ret = qcom_cc_probe(pdev, &gcc_ipq806x_desc); > if (ret) > return ret; > > - regmap = dev_get_regmap(dev, NULL); > + regmap = dev_get_regmap(&pdev->dev, NULL); > if (!regmap) > return -ENODEV; > > -- > 2.34.1 >