From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F11FC433EF for ; Thu, 24 Feb 2022 16:46:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbiBXQqe (ORCPT ); Thu, 24 Feb 2022 11:46:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229619AbiBXQqd (ORCPT ); Thu, 24 Feb 2022 11:46:33 -0500 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6437D340D6; Thu, 24 Feb 2022 08:46:03 -0800 (PST) Received: by mail-oi1-f180.google.com with SMTP id l25so3315295oic.13; Thu, 24 Feb 2022 08:46:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zbkQNmRMiKw/pcrFZH62eSxRpSbb/s9oDkkz3K5wBJ4=; b=6Zc1PZ+6yfLdHeGuod2Sbf8yG/0oDXC7uiwip5liAhFAKut8hWCCeuvbCd9jcCde70 FwCEeqrBzKxzNSwClZiPyIZSOffdf5gNEoFBXwvzMcI4OFLnx6ZjRZu/V5I9YyPPHnkF pY05CusdxFnPmVciXK5dpi7NFZ97NelDHRIZevjQwWHrqhhvpNI5hURHOvBTfI9ykWtV cGlwVlcpK7g5lgz1cKh2DF/H5ye85OBof1p7a/NSl55BDvQV47tJqnxRtZRN+nv78A3B CdLK9jdYsFYAiyVuCWJUBKEe3vxbLHynkSZJ+zBTQUm6Djz1ti3v98A6jGuN938jld3z 8XUg== X-Gm-Message-State: AOAM530h6CXxzuExkE8XzzzXnbrmtoG5h/ZD+a+sVefrJ/fRAOHM3G8x FSIN5MK+ofRLkMcAiSp+CpOJ39/+rg== X-Google-Smtp-Source: ABdhPJxUdvQQ74bDVPACbU46SgRLAo662OysqMgqfjKUa3F3TgTNZydiCsoVlSxthTdtiIVIFdbrsg== X-Received: by 2002:aca:5c89:0:b0:2d5:18eb:9e6 with SMTP id q131-20020aca5c89000000b002d518eb09e6mr1735362oib.58.1645719172925; Thu, 24 Feb 2022 08:12:52 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id bc16sm1650906oib.26.2022.02.24.08.12.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 08:12:52 -0800 (PST) Received: (nullmailer pid 3173677 invoked by uid 1000); Thu, 24 Feb 2022 16:12:50 -0000 Date: Thu, 24 Feb 2022 10:12:50 -0600 From: Rob Herring To: Allen-KH Cheng Cc: Jassi Brar , Matthias Brugger , Jassi Brar , Linux-ALSA , tzungbi@google.com, cujomalainey@google.com, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Kevin Hilman , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v17 1/2] dt-bindings: mailbox: mtk,adsp-mbox: add mtk adsp-mbox document Message-ID: References: <20220224133045.23903-1-allen-kh.cheng@mediatek.com> <20220224133045.23903-2-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220224133045.23903-2-allen-kh.cheng@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Feb 24, 2022 at 09:30:44PM +0800, Allen-KH Cheng wrote: > From: Allen-KH Cheng > > This patch adds document for mediatek adsp mbox > > Signed-off-by: Allen-KH Cheng > Reviewed-by: AngeloGioacchino Del Regno > --- > .../bindings/mailbox/mtk,adsp-mbox.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml b/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > new file mode 100644 > index 000000000000..25756837797f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mailbox/mtk,adsp-mbox.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek ADSP mailbox > + > +maintainers: > + - Allen-KH Cheng > + > +description: | > + The MTK ADSP mailbox Inter-Processor Communication (IPC) enables the SoC > + to ommunicate with ADSP by passing messages through two mailbox channels. > + The MTK ADSP mailbox IPC also provides the ability for one processor to > + signal the other processor using interrupts. > + > +properties: > + compatible: > + items: > + - const: mediatek,mt8195-adsp-mbox > + > + "#mbox-cells": > + const: 0 > + > + reg: > + description: > + Physical address base for dsp mbox registers. That's fairly obvious. Drop. You need to define how many: 'maxItems: 1' > + > + interrupts: > + description: > + adsp mbox interrupt Same here. > + > +required: > + - compatible > + - "#mbox-cells" > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + adsp_mailbox0:mailbox@10816000 { > + compatible = "mediatek,mt8195-adsp-mbox"; > + #mbox-cells = <0>; > + reg = <0x10816000 0x1000>; > + interrupts = ; > + }; > -- > 2.18.0 > >