From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: agross@kernel.org, robh+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: Add chosen node information for SDX65.
Date: Thu, 24 Feb 2022 13:44:00 -0600 [thread overview]
Message-ID: <YhfgAL8z6rO+zU3w@builder.lan> (raw)
In-Reply-To: <1644574845-23248-1-git-send-email-quic_rohiagar@quicinc.com>
On Fri 11 Feb 04:20 CST 2022, Rohit Agarwal wrote:
> Add chosen node in the base dtsi file of SDX65.
>
While this happens to be the same on most boards, it is still a
board-specific decision which UART is the debug uart, or if there is one
at all...
So this property should remain in the dts.
Thanks,
Bjorn
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> arch/arm/boot/dts/qcom-sdx65-mtp.dts | 4 ----
> arch/arm/boot/dts/qcom-sdx65.dtsi | 4 ++++
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> index 59457da..3a75c21 100644
> --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> @@ -14,10 +14,6 @@
> aliases {
> serial0 = &blsp1_uart3;
> };
> -
> - chosen {
> - stdout-path = "serial0:115200n8";
> - };
> };
>
> &blsp1_uart3 {
> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
> index 796641d..653df15 100644
> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
> @@ -17,6 +17,10 @@
> qcom,msm-id = <458 0x10000>, <483 0x10000>, <509 0x10000>;
> interrupt-parent = <&intc>;
>
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> memory {
> device_type = "memory";
> reg = <0 0>;
> --
> 2.7.4
>
next prev parent reply other threads:[~2022-02-24 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 10:20 [PATCH] ARM: dts: qcom: Add chosen node information for SDX65 Rohit Agarwal
2022-02-24 19:44 ` Bjorn Andersson [this message]
2022-02-25 7:16 ` Rohit Agarwal
2022-02-25 7:44 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhfgAL8z6rO+zU3w@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).