From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA055C433F5 for ; Thu, 24 Feb 2022 19:44:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233981AbiBXToe (ORCPT ); Thu, 24 Feb 2022 14:44:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232334AbiBXToe (ORCPT ); Thu, 24 Feb 2022 14:44:34 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD3F31C6EF7 for ; Thu, 24 Feb 2022 11:44:03 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id z7so4523523oid.4 for ; Thu, 24 Feb 2022 11:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6UcRxp9kACZzHXhxXXBrsGjD5/thuvHHqLsrvWRzW00=; b=PFItRgf8j7HlA6HdmRScXwKPDVRfwrJ36SO6Y5iraV/GbbXg6KIjYbQ6PJ2NmojuRE qRe/6NNxoZJZkG32eaoXaJ4bo4o1pKwEr1bNLMc+GDs15oVKvHhnHmqZY1EFqO3eVmVk ZYarZsHNQ2bhMM7InZ8YeoJRUsf2macfGXo5q/ddJnkxou2zmlWyXeVg1RsaSh1NiI5w dC8I+vMQz1ne4JrMWZAffB1QQYNF7+omLeHdccmzgRc41qHOk9zoLNSTGYxYwmp95rse 7q+k+Gcs4qnfIThFZ42fS2R34fjd6AMJVoczHtc7/NAr0Hde1thEopz9nHRW8Ojt+gEB WfYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6UcRxp9kACZzHXhxXXBrsGjD5/thuvHHqLsrvWRzW00=; b=iDyrsYU7v/n2PtVNpNRUZ6s29ucvID9ccWhBbI1z6feSivASoGmsUUxyM8fxHWnwG1 zkXt+1YNK/nynMN/NnTIMIWnqbx32Tjsj5vQ8gCQ5PJF05NpBXRoWf7tEV+UR+CqdEpQ GI5VNCiDX6A/TCEU4errsoG5e+AoVJPwVCHdAq3ap1J+IBpJkMGgOUaadmRUH47KFDTd 9xDbaQG5MlvHm4AGd4JlO0+DhT/fekn092pJ1be+nzzsHb3VJwoH+TGR+y+6on51g8Pn oJE/Dv4xqEte4TXPGYAiCO1gN7ttSkdVZZxTR4BMv2GR5zYWlb+rf329OvsqvmX1T9HZ JOag== X-Gm-Message-State: AOAM5309WWa4u95N29GGU3+E+F9u/9cTuZCC11ESKiRn2PqOCU1b4HjV Fz0ef/qmWr3/0p9bX7YNGWB12DUv/yJQlA== X-Google-Smtp-Source: ABdhPJzJZxAk+ZQGlBdXsfRylXvvpesnKNFw1w9vNrvRvXXh73PSKeSctBeyKlfNVy+CtA+slIMWfA== X-Received: by 2002:a05:6808:1aa9:b0:2d4:958a:ec5a with SMTP id bm41-20020a0568081aa900b002d4958aec5amr2220715oib.275.1645731843125; Thu, 24 Feb 2022 11:44:03 -0800 (PST) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id o22-20020a0568080bd600b002d49b19bc2fsm253363oik.23.2022.02.24.11.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 11:44:02 -0800 (PST) Date: Thu, 24 Feb 2022 13:44:00 -0600 From: Bjorn Andersson To: Rohit Agarwal Cc: agross@kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: qcom: Add chosen node information for SDX65. Message-ID: References: <1644574845-23248-1-git-send-email-quic_rohiagar@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644574845-23248-1-git-send-email-quic_rohiagar@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri 11 Feb 04:20 CST 2022, Rohit Agarwal wrote: > Add chosen node in the base dtsi file of SDX65. > While this happens to be the same on most boards, it is still a board-specific decision which UART is the debug uart, or if there is one at all... So this property should remain in the dts. Thanks, Bjorn > Signed-off-by: Rohit Agarwal > --- > arch/arm/boot/dts/qcom-sdx65-mtp.dts | 4 ---- > arch/arm/boot/dts/qcom-sdx65.dtsi | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts > index 59457da..3a75c21 100644 > --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts > +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts > @@ -14,10 +14,6 @@ > aliases { > serial0 = &blsp1_uart3; > }; > - > - chosen { > - stdout-path = "serial0:115200n8"; > - }; > }; > > &blsp1_uart3 { > diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi > index 796641d..653df15 100644 > --- a/arch/arm/boot/dts/qcom-sdx65.dtsi > +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi > @@ -17,6 +17,10 @@ > qcom,msm-id = <458 0x10000>, <483 0x10000>, <509 0x10000>; > interrupt-parent = <&intc>; > > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > memory { > device_type = "memory"; > reg = <0 0>; > -- > 2.7.4 >