From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: robh+dt@kernel.org, ohad@wizery.com, agross@kernel.org,
mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, evgreen@chromium.org,
dianders@chromium.org, swboyd@chromium.org, mka@chromium.org,
krzysztof.kozlowski@canonical.com
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem
Date: Thu, 24 Feb 2022 13:59:38 -0600 [thread overview]
Message-ID: <YhfjqsrHhbU36OqH@builder.lan> (raw)
In-Reply-To: <1644813252-12897-4-git-send-email-quic_sibis@quicinc.com>
On Sun 13 Feb 22:34 CST 2022, Sibi Sankar wrote:
> Add interconnects that are required to be proxy voted upon during modem
> bootup on SC7280 SoCs.
>
Looked at this again, and it makes me wonder why do we need to vote on
the path LLCC -> EBI1 and why do we call that path "imem"?
Regards,
Bjorn
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi
> index 9f4a9c263c35..1969f4cf59fe 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi
> @@ -89,6 +89,8 @@
> compatible = "qcom,sc7280-mss-pil";
> iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>;
> memory-region = <&mba_mem>, <&mpss_mem>;
> + interconnects = <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>;
> + interconnect-names = "imem";
> };
>
> /* Increase the size from 2.5MB to 8MB */
> --
> 2.7.4
>
next prev parent reply other threads:[~2022-02-24 19:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 4:34 [PATCH 0/3] Add support for proxy interconnect bandwidth votes Sibi Sankar
2022-02-14 4:34 ` [PATCH 1/3] dt-bindings: remoteproc: qcom: Add interconnects property Sibi Sankar
2022-02-14 7:28 ` Krzysztof Kozlowski
2022-02-14 4:34 ` [PATCH 2/3] remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth voting Sibi Sankar
2022-02-22 18:33 ` Bjorn Andersson
2022-02-14 4:34 ` [PATCH 3/3] arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem Sibi Sankar
2022-02-24 19:59 ` Bjorn Andersson [this message]
2022-04-04 23:17 ` [PATCH 0/3] Add support for proxy interconnect bandwidth votes Stephen Boyd
2022-05-10 10:59 ` Sibi Sankar
2022-05-10 11:03 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhfjqsrHhbU36OqH@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).