From: Rob Herring <robh@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: devicetree@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH v2] dt-bindings: leds: Document mmc trigger
Date: Thu, 24 Feb 2022 16:31:42 -0600 [thread overview]
Message-ID: <YhgHTrlxyn5QGdOM@robh.at.kernel.org> (raw)
In-Reply-To: <20220217174357.13427-1-marex@denx.de>
On Thu, Feb 17, 2022 at 06:43:57PM +0100, Marek Vasut wrote:
> The mmc subsystem supports triggering leds on card activity, document
> the trigger value here. The value is a pattern in this case.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> To: linux-leds@vger.kernel.org
> ---
> V2: Rebase on next-20220217
Why? Nobody can apply patches to linux-next. Is there something in next
you are dependent on that you didn't tell us about?
> ---
> .../devicetree/bindings/leds/common.yaml | 39 ++++++++++---------
> 1 file changed, 21 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 328952d7acbbc..3c14a98430e19 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -79,24 +79,27 @@ properties:
> the LED.
> $ref: /schemas/types.yaml#/definitions/string
>
> - enum:
> - # LED will act as a back-light, controlled by the framebuffer system
> - - backlight
> - # LED will turn on (but for leds-gpio see "default-state" property in
> - # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> - - default-on
> - # LED "double" flashes at a load average based rate
> - - heartbeat
> - # LED indicates disk activity
> - - disk-activity
> - # LED indicates IDE disk activity (deprecated), in new implementations
> - # use "disk-activity"
> - - ide-disk
> - # LED flashes at a fixed, configurable rate
> - - timer
> - # LED alters the brightness for the specified duration with one software
> - # timer (requires "led-pattern" property)
> - - pattern
> + oneOf:
> + - enum:
> + # LED will act as a back-light, controlled by the framebuffer system
> + - backlight
> + # LED will turn on (but for leds-gpio see "default-state" property in
> + # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> + - default-on
> + # LED "double" flashes at a load average based rate
> + - heartbeat
> + # LED indicates disk activity
> + - disk-activity
> + # LED indicates IDE disk activity (deprecated), in new implementations
> + # use "disk-activity"
> + - ide-disk
> + # LED flashes at a fixed, configurable rate
> + - timer
> + # LED alters the brightness for the specified duration with one software
> + # timer (requires "led-pattern" property)
> + - pattern
> + # LED is triggered by SD/MMC activity
> + - pattern: "^mmc[0-9]+$"
>
> led-pattern:
> description: |
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2022-02-24 22:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 17:43 [PATCH v2] dt-bindings: leds: Document mmc trigger Marek Vasut
2022-02-24 22:31 ` Rob Herring [this message]
2022-02-24 23:08 ` Marek Vasut
2022-02-24 22:31 ` Rob Herring
2022-09-21 10:56 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhgHTrlxyn5QGdOM@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=marex@denx.de \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).