* [PATCH v2] dt-bindings: leds: Document mmc trigger
@ 2022-02-17 17:43 Marek Vasut
2022-02-24 22:31 ` Rob Herring
2022-02-24 22:31 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: Marek Vasut @ 2022-02-17 17:43 UTC (permalink / raw)
To: devicetree; +Cc: Marek Vasut, Jacek Anaszewski, Pavel Machek, Rob Herring
The mmc subsystem supports triggering leds on card activity, document
the trigger value here. The value is a pattern in this case.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
To: linux-leds@vger.kernel.org
---
V2: Rebase on next-20220217
---
.../devicetree/bindings/leds/common.yaml | 39 ++++++++++---------
1 file changed, 21 insertions(+), 18 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index 328952d7acbbc..3c14a98430e19 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -79,24 +79,27 @@ properties:
the LED.
$ref: /schemas/types.yaml#/definitions/string
- enum:
- # LED will act as a back-light, controlled by the framebuffer system
- - backlight
- # LED will turn on (but for leds-gpio see "default-state" property in
- # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
- - default-on
- # LED "double" flashes at a load average based rate
- - heartbeat
- # LED indicates disk activity
- - disk-activity
- # LED indicates IDE disk activity (deprecated), in new implementations
- # use "disk-activity"
- - ide-disk
- # LED flashes at a fixed, configurable rate
- - timer
- # LED alters the brightness for the specified duration with one software
- # timer (requires "led-pattern" property)
- - pattern
+ oneOf:
+ - enum:
+ # LED will act as a back-light, controlled by the framebuffer system
+ - backlight
+ # LED will turn on (but for leds-gpio see "default-state" property in
+ # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
+ - default-on
+ # LED "double" flashes at a load average based rate
+ - heartbeat
+ # LED indicates disk activity
+ - disk-activity
+ # LED indicates IDE disk activity (deprecated), in new implementations
+ # use "disk-activity"
+ - ide-disk
+ # LED flashes at a fixed, configurable rate
+ - timer
+ # LED alters the brightness for the specified duration with one software
+ # timer (requires "led-pattern" property)
+ - pattern
+ # LED is triggered by SD/MMC activity
+ - pattern: "^mmc[0-9]+$"
led-pattern:
description: |
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] dt-bindings: leds: Document mmc trigger
2022-02-17 17:43 [PATCH v2] dt-bindings: leds: Document mmc trigger Marek Vasut
@ 2022-02-24 22:31 ` Rob Herring
2022-02-24 23:08 ` Marek Vasut
2022-02-24 22:31 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2022-02-24 22:31 UTC (permalink / raw)
To: Marek Vasut; +Cc: devicetree, Jacek Anaszewski, Pavel Machek
On Thu, Feb 17, 2022 at 06:43:57PM +0100, Marek Vasut wrote:
> The mmc subsystem supports triggering leds on card activity, document
> the trigger value here. The value is a pattern in this case.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> To: linux-leds@vger.kernel.org
> ---
> V2: Rebase on next-20220217
Why? Nobody can apply patches to linux-next. Is there something in next
you are dependent on that you didn't tell us about?
> ---
> .../devicetree/bindings/leds/common.yaml | 39 ++++++++++---------
> 1 file changed, 21 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 328952d7acbbc..3c14a98430e19 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -79,24 +79,27 @@ properties:
> the LED.
> $ref: /schemas/types.yaml#/definitions/string
>
> - enum:
> - # LED will act as a back-light, controlled by the framebuffer system
> - - backlight
> - # LED will turn on (but for leds-gpio see "default-state" property in
> - # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> - - default-on
> - # LED "double" flashes at a load average based rate
> - - heartbeat
> - # LED indicates disk activity
> - - disk-activity
> - # LED indicates IDE disk activity (deprecated), in new implementations
> - # use "disk-activity"
> - - ide-disk
> - # LED flashes at a fixed, configurable rate
> - - timer
> - # LED alters the brightness for the specified duration with one software
> - # timer (requires "led-pattern" property)
> - - pattern
> + oneOf:
> + - enum:
> + # LED will act as a back-light, controlled by the framebuffer system
> + - backlight
> + # LED will turn on (but for leds-gpio see "default-state" property in
> + # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> + - default-on
> + # LED "double" flashes at a load average based rate
> + - heartbeat
> + # LED indicates disk activity
> + - disk-activity
> + # LED indicates IDE disk activity (deprecated), in new implementations
> + # use "disk-activity"
> + - ide-disk
> + # LED flashes at a fixed, configurable rate
> + - timer
> + # LED alters the brightness for the specified duration with one software
> + # timer (requires "led-pattern" property)
> + - pattern
> + # LED is triggered by SD/MMC activity
> + - pattern: "^mmc[0-9]+$"
>
> led-pattern:
> description: |
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: leds: Document mmc trigger
2022-02-24 22:31 ` Rob Herring
@ 2022-02-24 23:08 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2022-02-24 23:08 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree, Jacek Anaszewski, Pavel Machek
On 2/24/22 23:31, Rob Herring wrote:
> On Thu, Feb 17, 2022 at 06:43:57PM +0100, Marek Vasut wrote:
>> The mmc subsystem supports triggering leds on card activity, document
>> the trigger value here. The value is a pattern in this case.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>> Cc: Pavel Machek <pavel@ucw.cz>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> To: linux-leds@vger.kernel.org
>> ---
>> V2: Rebase on next-20220217
>
> Why? Nobody can apply patches to linux-next. Is there something in next
> you are dependent on that you didn't tell us about?
It is just a convenience really, it is where the commits for all the
mostly latest development exist in one place, so I can be reasonably
sure the maintainer won't have trouble applying the patch on their tree
due to some missing patch, and if I work also on driver stuff, I can be
sure those drivers are also up-to-date-ish.
No, I don't think this patch specifically depends on anything in latest
next.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: leds: Document mmc trigger
2022-02-17 17:43 [PATCH v2] dt-bindings: leds: Document mmc trigger Marek Vasut
2022-02-24 22:31 ` Rob Herring
@ 2022-02-24 22:31 ` Rob Herring
2022-09-21 10:56 ` Pavel Machek
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2022-02-24 22:31 UTC (permalink / raw)
To: Marek Vasut; +Cc: Rob Herring, Jacek Anaszewski, Pavel Machek, devicetree
On Thu, 17 Feb 2022 18:43:57 +0100, Marek Vasut wrote:
> The mmc subsystem supports triggering leds on card activity, document
> the trigger value here. The value is a pattern in this case.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> To: linux-leds@vger.kernel.org
> ---
> V2: Rebase on next-20220217
> ---
> .../devicetree/bindings/leds/common.yaml | 39 ++++++++++---------
> 1 file changed, 21 insertions(+), 18 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: leds: Document mmc trigger
2022-02-24 22:31 ` Rob Herring
@ 2022-09-21 10:56 ` Pavel Machek
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2022-09-21 10:56 UTC (permalink / raw)
To: Rob Herring; +Cc: Marek Vasut, Rob Herring, Jacek Anaszewski, devicetree
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
On Thu 2022-02-24 16:31:52, Rob Herring wrote:
> On Thu, 17 Feb 2022 18:43:57 +0100, Marek Vasut wrote:
> > The mmc subsystem supports triggering leds on card activity, document
> > the trigger value here. The value is a pattern in this case.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > To: linux-leds@vger.kernel.org
> > ---
> > V2: Rebase on next-20220217
> > ---
> > .../devicetree/bindings/leds/common.yaml | 39 ++++++++++---------
> > 1 file changed, 21 insertions(+), 18 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@ke
Thanks, applied.
best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-21 10:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-17 17:43 [PATCH v2] dt-bindings: leds: Document mmc trigger Marek Vasut
2022-02-24 22:31 ` Rob Herring
2022-02-24 23:08 ` Marek Vasut
2022-02-24 22:31 ` Rob Herring
2022-09-21 10:56 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).