From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] dt-bindings: extcon: maxim,max77843: fix ports type
Date: Mon, 14 Mar 2022 08:52:36 +0000 [thread overview]
Message-ID: <Yi8CVJTRGy6v1CWr@google.com> (raw)
In-Reply-To: <20220310073258.24060-1-krzysztof.kozlowski@canonical.com>
On Thu, 10 Mar 2022, Krzysztof Kozlowski wrote:
> The "ports" property can contain multiple ports as name suggests, so it
> should be using "ports" type from device graphs.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Fixes: 9729cad0278b ("dt-bindings: extcon: maxim,max77843: Add MAX77843 bindings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> ---
>
> Hi Lee,
>
> This is a fix for a commit in your next branch.
Yes and no.
I sent out a pull-request so that follow-up fixes can go in via their
respective trees.
> ---
> Documentation/devicetree/bindings/extcon/maxim,max77843.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
> index f9ffe3d6f957..0216ec868c3e 100644
> --- a/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
> +++ b/Documentation/devicetree/bindings/extcon/maxim,max77843.yaml
> @@ -25,7 +25,7 @@ properties:
> $ref: /schemas/connector/usb-connector.yaml#
>
> ports:
> - $ref: /schemas/graph.yaml#/properties/port
> + $ref: /schemas/graph.yaml#/properties/ports
> description:
> Any connector to the data bus of this controller should be modelled using
> the OF graph bindings specified
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-03-14 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 7:32 [PATCH] dt-bindings: extcon: maxim,max77843: fix ports type Krzysztof Kozlowski
2022-03-10 23:25 ` Rob Herring
2022-03-14 8:52 ` Lee Jones [this message]
2022-03-29 21:26 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi8CVJTRGy6v1CWr@google.com \
--to=lee.jones@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).