From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120E9C433F5 for ; Thu, 3 Mar 2022 10:27:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231464AbiCCK1p (ORCPT ); Thu, 3 Mar 2022 05:27:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbiCCK1o (ORCPT ); Thu, 3 Mar 2022 05:27:44 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E12D4175869; Thu, 3 Mar 2022 02:26:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646303219; x=1677839219; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=drBwYn/yyUl+7kN4zTzBxFwNu33eBH11loDnD/f27gM=; b=NLsit8rzY6/xG1c73Kw8Enhg+Ei2aUKGau1EJGP92IxM6hwlhDlZSKk8 FHtSNa4Ebz/xRqAIAd2wsZZxyvAlI06hQtbWpURnzfSzjBBoWNS/qzHPN SJHM5JLJwXcL7yqIlXMyvdG+5bmCoEAgZQ/MD7NIUnsEwNarW2hzU4oFn yHBgZuClndmg9kitHixzhAyaDbLW3NL1dlWPPwoF1FEhjB2oZRqkQORPi eMDzlsOsv5uhHcTHvxM1RWDb5KGUzyLZezd86jLtm4JePDE0Vel5H4gUd D/doJH+IAtxk6G4kHNYE9fjX5GURS2n11XZJF4oF6QN6vvaNMxBp+BbBV g==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="278318636" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="278318636" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 02:26:59 -0800 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="640131042" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 02:26:50 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nPiep-00AjrX-4e; Thu, 03 Mar 2022 12:26:03 +0200 Date: Thu, 3 Mar 2022 12:26:02 +0200 From: Andy Shevchenko To: Tyrone Ting Cc: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, yangyicong@hisilicon.com, semen.protsenko@linaro.org, wsa@kernel.org, jie.deng@intel.com, sven@svenpeter.dev, bence98@sch.bme.hu, lukas.bulwahn@gmail.com, arnd@arndb.de, olof@lixom.net, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Message-ID: References: <20220303083141.8742-1-warp5tw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220303083141.8742-1-warp5tw@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Mar 03, 2022 at 04:31:30PM +0800, Tyrone Ting wrote: > From: Tyrone Ting > > This patchset includes the following fixes: > > - Add dt-bindings description for NPCM845. > - Bug fix for timeout calculation. > - Better handling of spurious interrupts. > - Fix for event type in slave mode. > - Removal of own slave addresses [2:10]. > - Support for next gen BMC (NPCM845). > > The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards. Overall my impression that the code was never tested for this driver and somehow appears in the upstream and hence this series. Anyway, I'm going to review the changes here. -- With Best Regards, Andy Shevchenko