From: Rob Herring <robh@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Frank Rowand <frowand.list@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Maxime Ripard <maxime@cerno.tech>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: kbuild: Use DTB files for validation
Date: Fri, 4 Mar 2022 08:07:21 -0600 [thread overview]
Message-ID: <YiIdGTcqDyaaC1i9@robh.at.kernel.org> (raw)
In-Reply-To: <YiH+Twl8JnwKPv3a@pendragon.ideasonboard.com>
On Fri, Mar 04, 2022 at 01:55:59PM +0200, Laurent Pinchart wrote:
> Hi Rob,
>
> Thank you for the patch.
>
> On Thu, Mar 03, 2022 at 04:42:37PM -0600, Rob Herring wrote:
> > Switch the DT validation to use DTB files directly instead of a DTS to
> > YAML conversion.
> >
> > The original motivation for supporting validation on DTB files was to
> > enable running validation on a running system (e.g. 'dt-validate
> > /sys/firmware/fdt') or other cases where the original source DTS is not
> > available.
> >
> > The YAML format was not without issues. Using DTBs with the schema type
> > information solves some of those problems. The YAML format relies on the
> > DTS source level information including bracketing of properties, size
> > directives, and phandle tags all of which are lost in a DTB file. While
> > standardizing the bracketing is a good thing, it does cause a lot of
> > extra warnings and churn to fix them.
>
> It does indeed, but it's a bit sad to let that feature go :-S
I agree, but I think that checking is better served with a DTS linter.
Rob
next prev parent reply other threads:[~2022-03-04 14:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 22:42 [PATCH 0/2] dt-bindings: DTB based validation Rob Herring
2022-03-03 22:42 ` [PATCH 1/2] dt-bindings: kbuild: Pass DT_SCHEMA_FILES to dt-validate Rob Herring
2022-03-04 9:32 ` Geert Uytterhoeven
2022-03-04 13:57 ` Rob Herring
2022-03-04 14:05 ` Geert Uytterhoeven
2022-03-04 14:30 ` Rob Herring
2022-03-04 14:49 ` Geert Uytterhoeven
2022-03-10 15:49 ` Rob Herring
2022-03-04 11:48 ` Laurent Pinchart
2022-03-04 14:03 ` Rob Herring
2022-03-03 22:42 ` [PATCH 2/2] dt-bindings: kbuild: Use DTB files for validation Rob Herring
2022-03-04 11:55 ` Laurent Pinchart
2022-03-04 14:07 ` Rob Herring [this message]
2022-03-07 12:20 ` Geert Uytterhoeven
2022-03-07 17:00 ` Rob Herring
2022-03-08 8:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiIdGTcqDyaaC1i9@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=maxime@cerno.tech \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).