From: Andrew Lunn <andrew@lunn.ch>
To: Divya.Koppera@microchip.com
Cc: netdev@vger.kernel.org, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
richardcochran@gmail.com, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com, Madhuri.Sripada@microchip.com,
Manohar.Puri@microchip.com
Subject: Re: [PATCH net-next 2/3] dt-bindings: net: micrel: Configure latency values and timestamping check for LAN8814 phy
Date: Tue, 8 Mar 2022 14:54:37 +0100 [thread overview]
Message-ID: <YidgHT8CLWrmhbTW@lunn.ch> (raw)
In-Reply-To: <CO1PR11MB4771F7C1819E033EC613E262E2099@CO1PR11MB4771.namprd11.prod.outlook.com>
> > Thanks for the reply, but you did not answer my question:
> >
> > Does this mean the hardware itself cannot tell you it is missing the
> > needed hardware?
> >
> > Don't you have different IDs in register 2 and 3 for those devices with clock
> > register and those without?
> >
>
> The purpose of this option is, if both PHY and MAC supports
> timestamping then always timestamping is done in PHY. If
> timestamping need to be done in MAC we need a way to stop PHY
> timestamping. If this flag is used then timestamping is taken care
> by MAC.
This is not a valid use of DT, since this is configuration, not
describing the hardware. There has been recent extension in the UAPI
to allow user space to do this configuration. Please look at that
work.
> Sorry I answered wrong. Latency values vary depending on the position of PHY in board.
> We have used this PHY in different hardware's, where latency values differs based on PHY positioning.
> So we used latency option in DTS file.
> If you have other ideas or I'm wrong please let me know?
So this is a function of the track length between the MAC and the PHY?
How do you determine these values? There is no point having
configuration values if you don't document how to determine what value
should be used.
Andrew
next prev parent reply other threads:[~2022-03-08 13:54 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 9:34 [PATCH net-next 0/3] Add support for 1588 in LAN8814 Divya Koppera
2022-03-04 9:34 ` [PATCH net-next 1/3] net: phy: micrel: Fix concurrent register access Divya Koppera
2022-03-04 9:34 ` [PATCH net-next 2/3] dt-bindings: net: micrel: Configure latency values and timestamping check for LAN8814 phy Divya Koppera
2022-03-04 12:50 ` Andrew Lunn
2022-03-04 13:55 ` Richard Cochran
2022-03-07 5:02 ` Divya.Koppera
2022-03-07 4:40 ` Divya.Koppera
2022-03-07 13:08 ` Andrew Lunn
2022-03-08 10:05 ` Divya.Koppera
2022-03-08 13:54 ` Andrew Lunn [this message]
2022-03-08 14:54 ` Richard Cochran
2022-03-08 15:43 ` Horatiu Vultur
2022-03-08 18:10 ` Andrew Lunn
2022-03-08 22:14 ` Horatiu Vultur
2022-03-08 23:36 ` Andrew Lunn
2022-03-09 1:46 ` Richard Cochran
2022-03-09 1:58 ` Richard Cochran
2022-03-09 13:24 ` Horatiu Vultur
2022-03-09 14:55 ` Russell King (Oracle)
2022-03-09 19:52 ` Richard Cochran
2022-03-11 14:28 ` Horatiu Vultur
2022-03-11 15:08 ` Richard Cochran
2022-03-12 19:36 ` Allan W. Nielsen
2022-03-13 2:41 ` Richard Cochran
2022-03-13 4:04 ` Richard Cochran
2022-03-11 15:21 ` Woojung.Huh
2022-03-12 2:48 ` Richard Cochran
2022-03-12 20:04 ` Andrew Lunn
2022-03-13 2:46 ` Richard Cochran
2022-03-13 15:07 ` Andrew Lunn
2022-03-13 19:37 ` Allan W. Nielsen
2022-03-13 20:03 ` Richard Cochran
2022-03-13 20:07 ` Richard Cochran
2022-03-11 14:07 ` Horatiu Vultur
2022-03-07 21:33 ` Rob Herring
2022-03-04 9:34 ` [PATCH net-next 3/3] net: phy: micrel: 1588 support " Divya Koppera
2022-03-04 13:06 ` Andrew Lunn
2022-03-07 4:58 ` Divya.Koppera
2022-03-07 13:19 ` Andrew Lunn
2022-03-04 13:46 ` Kurt Kanzenbach
2022-03-04 13:57 ` Richard Cochran
2022-03-04 12:50 ` [PATCH net-next 0/3] Add support for 1588 in LAN8814 patchwork-bot+netdevbpf
2022-03-04 13:06 ` Andrew Lunn
2022-03-04 13:21 ` David Miller
2022-03-04 13:47 ` Andrew Lunn
2022-03-04 14:37 ` David Miller
2022-03-04 14:06 ` Richard Cochran
2022-03-04 14:17 ` Andrew Lunn
2022-03-04 15:42 ` Richard Cochran
2022-03-17 12:16 ` Michael Walle
2022-03-17 14:05 ` Allan W. Nielsen
2022-03-17 14:38 ` Andrew Lunn
2022-03-17 19:30 ` Allan W. Nielsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YidgHT8CLWrmhbTW@lunn.ch \
--to=andrew@lunn.ch \
--cc=Divya.Koppera@microchip.com \
--cc=Madhuri.Sripada@microchip.com \
--cc=Manohar.Puri@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).