[RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[Alim Akhtar]

Adds spi controller dt-binding compatible information for
Tesla Full Self-Driving (FSD) SoC.

Cc: linux-fsd@tesla.com
Signed-off-by: Adithya K V <adithya.kv@samsung.com>
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Andi Shyti <andi@etezian.org>
---
 Documentation/devicetree/bindings/spi/samsung,spi.yaml | 1 +
 1 file changed, 1 insertion(+)

- Resend of FSD SPI support patches as the dependencies has landed in MFD
  tree, hope this will go via MFD tree (as there are dependency between
MFD, SPI and DT)

diff --git a/Documentation/devicetree/bindings/spi/samsung,spi.yaml b/Documentation/devicetree/bindings/spi/samsung,spi.yaml
index 61c77088e8ee..bf9a76d931d2 100644
--- a/Documentation/devicetree/bindings/spi/samsung,spi.yaml
+++ b/Documentation/devicetree/bindings/spi/samsung,spi.yaml
@@ -21,6 +21,7 @@ properties:
           - samsung,s3c6410-spi
           - samsung,s5pv210-spi # for S5PV210 and S5PC110
           - samsung,exynos5433-spi
+          - tesla,fsd-spi
       - const: samsung,exynos7-spi
         deprecated: true
 

base-commit: 172e611b54e813c49a35b6b74bccaa99f27bf566
-- 
2.25.1

[RESEND PATCH v3 2/2] spi: s3c64xx: Add spi port configuration for Tesla FSD SoC

[Alim Akhtar]

Add compatible and port configuration for spi controller
for Tesla Full Self-Driving SoC.

Cc: linux-fsd@tesla.com
Signed-off-by: Aswani Reddy <aswani.reddy@samsung.com>
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Andi Shyti <andi@etezian.org>
---
 drivers/spi/spi-s3c64xx.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 386550fca81c..423518bf0270 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1440,6 +1440,16 @@ static const struct s3c64xx_spi_port_config exynos5433_spi_port_config = {
 	.quirks		= S3C64XX_SPI_QUIRK_CS_AUTO,
 };
 
+static struct s3c64xx_spi_port_config fsd_spi_port_config = {
+	.fifo_lvl_mask	= { 0x7f, 0x7f, 0x7f, 0x7f, 0x7f},
+	.rx_lvl_offset	= 15,
+	.tx_st_done	= 25,
+	.high_speed	= true,
+	.clk_from_cmu	= true,
+	.clk_ioclk	= false,
+	.quirks		= S3C64XX_SPI_QUIRK_CS_AUTO,
+};
+
 static const struct platform_device_id s3c64xx_spi_driver_ids[] = {
 	{
 		.name		= "s3c2443-spi",
@@ -1470,6 +1480,9 @@ static const struct of_device_id s3c64xx_spi_dt_match[] = {
 	{ .compatible = "samsung,exynos5433-spi",
 			.data = (void *)&exynos5433_spi_port_config,
 	},
+	{ .compatible = "tesla,fsd-spi",
+			.data = (void *)&fsd_spi_port_config,
+	},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, s3c64xx_spi_dt_match);
-- 
2.25.1

Re: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

On Tue, Mar 08, 2022 at 05:46:39PM +0530, Alim Akhtar wrote:

> - Resend of FSD SPI support patches as the dependencies has landed in MFD
>   tree, hope this will go via MFD tree (as there are dependency between
> MFD, SPI and DT)

I either need a pull request for the MFD changes or to wait until those
changes have come in via Linus' tree.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[Lee Jones]

On Tue, 08 Mar 2022, Mark Brown wrote:

> On Tue, Mar 08, 2022 at 05:46:39PM +0530, Alim Akhtar wrote:
> 
> > - Resend of FSD SPI support patches as the dependencies has landed in MFD
> >   tree, hope this will go via MFD tree (as there are dependency between
> > MFD, SPI and DT)
> 
> I either need a pull request for the MFD changes or to wait until those
> changes have come in via Linus' tree.

You mean this one:

  https://lore.kernel.org/all/YiYC7eYx2SpPILyl@google.com/

  spi: dt-bindings: samsung: Convert to dtschema

Or something else?

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

On Tue, Mar 08, 2022 at 01:58:03PM +0000, Lee Jones wrote:
> On Tue, 08 Mar 2022, Mark Brown wrote:

> > I either need a pull request for the MFD changes or to wait until those
> > changes have come in via Linus' tree.

> You mean this one:

>   https://lore.kernel.org/all/YiYC7eYx2SpPILyl@google.com/

>   spi: dt-bindings: samsung: Convert to dtschema

> Or something else?

There were changes adding the FSD SoC as well as DT stuff IIRC.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[Alim Akhtar]

>-----Original Message-----
>From: Mark Brown [mailto:broonie@kernel.org]
>Sent: Tuesday, March 8, 2022 8:01 PM
>To: Lee Jones <lee.jones@linaro.org>
>Cc: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
>devicetree@vger.kernel.org; linus.walleij@linaro.org; robh+dt@kernel.org;
>krzysztof.kozlowski@canonical.com; linux-samsung-soc@vger.kernel.org;
>pankaj.dubey@samsung.com; andi@etezian.org; linux-spi@vger.kernel.org;
>linux-fsd@tesla.com; Adithya K V <adithya.kv@samsung.com>
>Subject: Re: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi
>compatible
>
>On Tue, Mar 08, 2022 at 01:58:03PM +0000, Lee Jones wrote:
>> On Tue, 08 Mar 2022, Mark Brown wrote:
>
>> > I either need a pull request for the MFD changes or to wait until
>> > those changes have come in via Linus' tree.
>
>> You mean this one:
>
>>   https://lore.kernel.org/all/YiYC7eYx2SpPILyl@google.com/
>
>>   spi: dt-bindings: samsung: Convert to dtschema
>
>> Or something else?
>
>There were changes adding the FSD SoC as well as DT stuff IIRC.

FSD SoC DT changes are already in -next.
I think this can go with MFD tree because of immutable
branch between MFD, SPI and DT due for the v5.18 merge windows.
I am not sure if there are better ways to handle this.

Regards,
Alim

Re: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

On Tue, Mar 08, 2022 at 08:15:15PM +0530, Alim Akhtar wrote:

> >There were changes adding the FSD SoC as well as DT stuff IIRC.

> FSD SoC DT changes are already in -next.
> I think this can go with MFD tree because of immutable
> branch between MFD, SPI and DT due for the v5.18 merge windows.
> I am not sure if there are better ways to handle this.

I need the changes that are hard dependencies to actually be in my tree
so my tree is not broken, -next isn't good enough here.  If there are
dependencies for things you're posting you should explicitly say what
they are when you post (not just vauge statements that there are
dependencies), and when you post things that will be dependencies for
other trees it's good to mention this so that people can think about
putting them on a separate branch for easier cross merging.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[Lee Jones]

On Tue, 08 Mar 2022, Mark Brown wrote:

> On Tue, Mar 08, 2022 at 08:15:15PM +0530, Alim Akhtar wrote:
> 
> > >There were changes adding the FSD SoC as well as DT stuff IIRC.
> 
> > FSD SoC DT changes are already in -next.
> > I think this can go with MFD tree because of immutable
> > branch between MFD, SPI and DT due for the v5.18 merge windows.
> > I am not sure if there are better ways to handle this.
> 
> I need the changes that are hard dependencies to actually be in my tree
> so my tree is not broken, -next isn't good enough here.  If there are
> dependencies for things you're posting you should explicitly say what
> they are when you post (not just vauge statements that there are
> dependencies), and when you post things that will be dependencies for
> other trees it's good to mention this so that people can think about
> putting them on a separate branch for easier cross merging.

Right.

Which patch(es) contain the dependencies please Alim?

I tend to send out pull-requests for cross-subsystem changes I merge.

Not sure I see anything relevant in my tree currently.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

RE: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[Alim Akhtar]

>-----Original Message-----
>From: Lee Jones [mailto:lee.jones@linaro.org]
>Sent: Tuesday, March 8, 2022 9:06 PM
>To: Mark Brown <broonie@kernel.org>
>Cc: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
>devicetree@vger.kernel.org; linus.walleij@linaro.org; robh+dt@kernel.org;
>krzysztof.kozlowski@canonical.com; linux-samsung-soc@vger.kernel.org;
>pankaj.dubey@samsung.com; andi@etezian.org; linux-spi@vger.kernel.org;
>linux-fsd@tesla.com; 'Adithya K V' <adithya.kv@samsung.com>
>Subject: Re: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi
>compatible
>
>On Tue, 08 Mar 2022, Mark Brown wrote:
>
>> On Tue, Mar 08, 2022 at 08:15:15PM +0530, Alim Akhtar wrote:
>>
>> > >There were changes adding the FSD SoC as well as DT stuff IIRC.
>>
>> > FSD SoC DT changes are already in -next.
>> > I think this can go with MFD tree because of immutable branch
>> > between MFD, SPI and DT due for the v5.18 merge windows.
>> > I am not sure if there are better ways to handle this.
>>
>> I need the changes that are hard dependencies to actually be in my
>> tree so my tree is not broken, -next isn't good enough here.  If there
>> are dependencies for things you're posting you should explicitly say
>> what they are when you post (not just vauge statements that there are
>> dependencies), and when you post things that will be dependencies for
>> other trees it's good to mention this so that people can think about
>> putting them on a separate branch for easier cross merging.
>
>Right.
>
>Which patch(es) contain the dependencies please Alim?
>

Only dependency is on 
  https://lore.kernel.org/all/YiYC7eYx2SpPILyl@google.com/

  spi: dt-bindings: samsung: Convert to dtschema

for the subject patch.

>I tend to send out pull-requests for cross-subsystem changes I merge.
>
>Not sure I see anything relevant in my tree currently.
>
>--
>Lee Jones [李琼斯]
>Principal Technical Lead - Developer Services Linaro.org │ Open source
>software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

RE: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[Alim Akhtar]

>-----Original Message-----
>From: Mark Brown [mailto:broonie@kernel.org]
>Sent: Tuesday, March 8, 2022 8:32 PM
>To: Alim Akhtar <alim.akhtar@samsung.com>
>Cc: 'Lee Jones' <lee.jones@linaro.org>;
linux-arm-kernel@lists.infradead.org;
>linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
>linus.walleij@linaro.org; robh+dt@kernel.org;
>krzysztof.kozlowski@canonical.com; linux-samsung-soc@vger.kernel.org;
>pankaj.dubey@samsung.com; andi@etezian.org; linux-spi@vger.kernel.org;
>linux-fsd@tesla.com; 'Adithya K V' <adithya.kv@samsung.com>
>Subject: Re: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi
>compatible
>
>On Tue, Mar 08, 2022 at 08:15:15PM +0530, Alim Akhtar wrote:
>
>> >There were changes adding the FSD SoC as well as DT stuff IIRC.
>
>> FSD SoC DT changes are already in -next.
>> I think this can go with MFD tree because of immutable branch between
>> MFD, SPI and DT due for the v5.18 merge windows.
>> I am not sure if there are better ways to handle this.
>
>I need the changes that are hard dependencies to actually be in my tree so
my
>tree is not broken, -next isn't good enough here.  If there are
dependencies
>for things you're posting you should explicitly say what they are when you
>post (not just vauge statements that there are dependencies), and when you
>post things that will be dependencies for other trees it's good to mention
this
>so that people can think about putting them on a separate branch for easier
>cross merging.
Sorry Mark for the noise. I should have clearly mentioned the dependencies. 
Surly I will keep this in mind for the future patches.

Only dependency these two patches have on 

  https://lore.kernel.org/all/YiYC7eYx2SpPILyl@google.com/

  spi: dt-bindings: samsung: Convert to dtschema

which is now in MFD tree.

Re: [RESEND PATCH v3 1/2] spi: dt-bindings: samsung: Add fsd spi compatible

[Mark Brown]

On Tue, 8 Mar 2022 17:46:39 +0530, Alim Akhtar wrote:
> Adds spi controller dt-binding compatible information for
> Tesla Full Self-Driving (FSD) SoC.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: dt-bindings: samsung: Add fsd spi compatible
      commit: 363d3c51bc5b3243b5b035a1f50d6d994a1b203f
[2/2] spi: s3c64xx: Add spi port configuration for Tesla FSD SoC
      commit: 4ebb15a15799da4954f1d4926fcd3263ea46e417

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark