From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C429C433FE for ; Tue, 8 Mar 2022 19:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349833AbiCHTHv (ORCPT ); Tue, 8 Mar 2022 14:07:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349849AbiCHTHu (ORCPT ); Tue, 8 Mar 2022 14:07:50 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67FE553E0E for ; Tue, 8 Mar 2022 11:06:53 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id e3so58752pjm.5 for ; Tue, 08 Mar 2022 11:06:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fKKD+3hXAeIEEWs0Yh0fwesV2YwX9bcSV9zNUsAN1go=; b=TiAz7VQN6cqOR+YCGQONQ1puu9/mIbyi+3VaF2Y+0BaZGeb5d0zwRpgV+wE8vfCZR2 Pgq+thE1e9/4lXjLiLuSG2aKfs9V+qPTceSPGx1VZpZ/g/nRHQ1xsr06c/+SZh0uL6ZD l59TPYzzVMS9JLJRtFAh9Cax5j2QTPG0/KiPc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fKKD+3hXAeIEEWs0Yh0fwesV2YwX9bcSV9zNUsAN1go=; b=dsNwq71iTypAUIrux4JO/kQFlSpwvGfxZPUHyhTrU5ECMl5mXz54nO4UvCjjTV2ypt 3aUiCQ0ovDd9C+1cVjKxXiHGzHkZcBJkXqRpSGIBR29LujIxXSMYmueJo3HEtu4IqZes N+o1vLE4+/D3Yz+zxT4T4b1+z3gzzgN5nEU+hLqeH1Ur4cFkR2x6mhtunxw5kJM+v4yB luwYUId9VOVQfBb5YjfnC2ZXEc6rdocrBwXrmsagMbkMf0ySMN+DDazAgqir4lW9/xHl 8sB+lmcl1XfgIR9SdgvsdVDWrpI/AWZ47AfFexR5eTNgG73uZ/K5c/q/BhVBOPkmYZl4 hpgQ== X-Gm-Message-State: AOAM530bnl82TpAyZvuLffK98CEXR1YCKXX5A9TOjH8Kb2pXJBxtkDKq Xx4QHSkd+c9wb36t6AEc3MU8yw== X-Google-Smtp-Source: ABdhPJwSOD+gGbHatfnouDV590+C0yrq8QOnBDEG0WOdkHpfzRz+TxjH6jpl1Ho2oEWdFX5xJuG7yw== X-Received: by 2002:a17:90a:aa8c:b0:1bf:5273:ba28 with SMTP id l12-20020a17090aaa8c00b001bf5273ba28mr6261331pjq.226.1646766412904; Tue, 08 Mar 2022 11:06:52 -0800 (PST) Received: from google.com ([2620:15c:202:201:b3e3:a188:cbfc:3a0e]) by smtp.gmail.com with ESMTPSA id x29-20020aa79a5d000000b004f0ef1822d3sm19910654pfj.128.2022.03.08.11.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 11:06:52 -0800 (PST) Date: Tue, 8 Mar 2022 11:06:49 -0800 From: Brian Norris To: Krzysztof Kozlowski , Heiko Stuebner Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring , Lin Huang , Heiko Stuebner , Derek Basehore , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 01/15] dt-bindings: devfreq: rk3399_dmc: Convert to YAML Message-ID: References: <20220308000945.706701-1-briannorris@chromium.org> <20220307160918.v3.1.I875ab8f28c5155a7d2f103316191954d4b07ac13@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 08, 2022 at 07:03:15PM +0100, Krzysztof Kozlowski wrote: > On 08/03/2022 01:09, Brian Norris wrote: > Apologies for jumping in late in discussion, but how about moving it to > memory-controllers or interconnect directory? devfreq is Linux specific > and DMC sounds a lot like dynamic memory controller. Sure! Will do in v4. > > > > .../bindings/devfreq/rk3399_dmc.txt | 212 ------------- > > .../bindings/devfreq/rk3399_dmc.yaml | 294 ++++++++++++++++++ > > file name: > rockchip,rk3399-dmc.yaml Ack. > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.yaml > > + devfreq-events: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + minItems: 1 > > + maxItems: 1 > > Rob previously asked about max, but it seems it is only one phandle, > right? Then the type - 'phandle'. Sure! Don't know why I didn't notice that. > > + rockchip,ddr3_odt: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + When the DRAM type is DDR3, this parameter defines the DRAM side ODT > > + strength in ohms. Default value is 120. > > Here and in all other places - instead of describing default value in > description, just add "default: 120". Yep. Most of these properties are actually deprecated in the end, but doesn't hurt to use the facilities available. > Best regards, > Krzysztof Thanks for the reviews! I'll roll them all into v4 shortly. While I'm at it: I think I have Reviewed-by's for all the DT patches (except this one). Given it also touches Rockchip device trees, maybe this all needs to go through Heiko / linux-rockchip? Or if not, it'd be nice if Heiko spoke up to tell the devfreq maintainers instead. Regards, Brian