[PATCH v2] dt-bindings: firmware: arm,scpi: Add missing maxItems to mboxes/shmem

[PATCH v2] dt-bindings: firmware: arm,scpi: Add missing maxItems to mboxes/shmem

[Geert Uytterhoeven]

"make dt_binding_check":

    Documentation/devicetree/bindings/firmware/arm,scpi.example.dt.yaml: scpi: shmem: [[2], [1]] is too long

Fix this by adding a proper maxItems value to the shmem property,
and to the related mboxes property.

Fix the grouping of the "mboxes" property in the example.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
---
Exposed by commit 39bd2b6a3783b899 ("dt-bindings: Improve phandle-array
schemas").

v2:
  - Change limit from 2 to 4, as requested by Sudeep,
  - Add Acked-by,
  - Add maxItems to mboxes properties,
  - Group mboxes in example.
---
 Documentation/devicetree/bindings/firmware/arm,scpi.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
index 800417a76bda0bd9..1f9322925e7c9f2d 100644
--- a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
+++ b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
@@ -43,6 +43,7 @@ properties:
       by remote SCP firmware for use by SCPI message protocol should be
       specified in any order.
     minItems: 1
+    maxItems: 4
 
   shmem:
     description:
@@ -51,6 +52,7 @@ properties:
       be any memory reserved for the purpose of this communication between the
       processors.
     minItems: 1
+    maxItems: 4
 
   power-controller:
     type: object
@@ -235,7 +237,7 @@ examples:
     firmware {
         scpi {
             compatible = "amlogic,meson-gxbb-scpi", "arm,scpi-pre-1.0";
-            mboxes = <&mailbox 1 &mailbox 2>;
+            mboxes = <&mailbox 1>, <&mailbox 2>;
             shmem = <&cpu_scp_lpri>, <&cpu_scp_hpri>;
 
             scpi_sensors1: sensors {
-- 
2.25.1

Re: [PATCH v2] dt-bindings: firmware: arm,scpi: Add missing maxItems to mboxes/shmem

[Rob Herring]

On Tue, Mar 08, 2022 at 06:49:02PM +0100, Geert Uytterhoeven wrote:
> "make dt_binding_check":
> 
>     Documentation/devicetree/bindings/firmware/arm,scpi.example.dt.yaml: scpi: shmem: [[2], [1]] is too long
> 
> Fix this by adding a proper maxItems value to the shmem property,
> and to the related mboxes property.
> 
> Fix the grouping of the "mboxes" property in the example.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> Exposed by commit 39bd2b6a3783b899 ("dt-bindings: Improve phandle-array
> schemas").
> 
> v2:
>   - Change limit from 2 to 4, as requested by Sudeep,
>   - Add Acked-by,
>   - Add maxItems to mboxes properties,
>   - Group mboxes in example.
> ---
>  Documentation/devicetree/bindings/firmware/arm,scpi.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks!

Rob