From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7684C433FE for ; Tue, 8 Mar 2022 23:09:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbiCHXKt (ORCPT ); Tue, 8 Mar 2022 18:10:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbiCHXKs (ORCPT ); Tue, 8 Mar 2022 18:10:48 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 645F86F4B3 for ; Tue, 8 Mar 2022 15:09:48 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id o106-20020a9d2273000000b005b21f46878cso480926ota.3 for ; Tue, 08 Mar 2022 15:09:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xuc98iQ6lLN5ZWjfMkCi08X6OqD4xJL8S5CE7+O2xXo=; b=ufjwvyzNLdj8kL4OhOSrTDZr9TwtTMGBSYKptuax0eItS0/K2Li7gLDPnKGMSVhxb0 AVhfV82OUzj4q6JGYm3SJjk7imPLYPvVWFEO7Hnvu22PjY7s+7eefgq1tGg2xQvMD5C2 sZV0znnqEGyrfEKDzwX/Pzt7gjZvZapFf2MyBY3NHA1dRW+G5mrX2h6l7yXqZEdMRepF QQmuDgriXkK7wdMr2PHSVgeKuxkIB90+avmkKV5p17EWJln+MVCytyavDctuDJJIAJqM 1YjRl1H5BKzo5yrDI8SbzUe8CKigHm7BWSTWlwIG0IoeV9jb8JsLgg96waj9ZOHo9jGk P6ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xuc98iQ6lLN5ZWjfMkCi08X6OqD4xJL8S5CE7+O2xXo=; b=NWLuy7x+Tu+5bG4oBV1ROkh2iGB+xg3mPUEJwm5pZskwdui/peXk5T8HvYsRmvat44 2e46kyf0I7BjbiZdMeI+jq/zMGL4vEKRoTm1AGqmk+IyaGIwZf1eJYqcBWOwepomRx/n Bsj99VsttPj/BlBBnc6u0dW/gqKd94lNciqR90U1ynB6KIvW69nxeccGLv2dQmNPtJAv zJ35Bj70NjwO8LFjIMmJJUbiVRaiejx3nazmp883b2KrwYP7lREqb2Me1rVYK7Hw4gt3 EWwRTfWZ6ivSs3yjM6uLd5GGTYVV+qp1mMkKsqByHTn+UBniLBYMHbJcSURZrM9ci8Yz w6GQ== X-Gm-Message-State: AOAM53339mFdSI9kVI4Z7ayysVuNVG4Mk3LFW93F2DZk0ejeKNPzvruX nJP0TQRoCou2tre4oDMdwQO46Q== X-Google-Smtp-Source: ABdhPJxRpGsmLOMyITa2cLxJpOaQ0mqRRzUUbDozIlPaZ8piOB6fxUH+hJr2w8mLPUw47UxqSD2a9Q== X-Received: by 2002:a9d:518c:0:b0:5b2:364b:7fbd with SMTP id y12-20020a9d518c000000b005b2364b7fbdmr5766151otg.255.1646780987672; Tue, 08 Mar 2022 15:09:47 -0800 (PST) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id z26-20020a9d62da000000b005b23f5488cdsm68215otk.52.2022.03.08.15.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 15:09:46 -0800 (PST) Date: Tue, 8 Mar 2022 17:09:45 -0600 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Bhupesh Sharma , linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, agross@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, sboyd@kernel.org, tdas@codeaurora.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, robh+dt@kernel.org Subject: Re: [PATCH v3 3/6] clk: qcom: gcc: Add emac GDSC support for SM8150 Message-ID: References: <20220303084824.284946-1-bhupesh.sharma@linaro.org> <20220303084824.284946-4-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 03 Mar 04:33 CST 2022, Dmitry Baryshkov wrote: > On Thu, 3 Mar 2022 at 11:48, Bhupesh Sharma wrote: > > > > Add the EMAC GDSC defines and driver structures for SM8150. > > > > Cc: Stephen Boyd > > Cc: Bjorn Andersson > > Signed-off-by: Bhupesh Sharma > > --- > > drivers/clk/qcom/gcc-sm8150.c | 10 ++++++++++ > > include/dt-bindings/clock/qcom,gcc-sm8150.h | 1 + > > 2 files changed, 11 insertions(+) > > > > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c > > index 85a431ac417b..08ba29e3a835 100644 > > --- a/drivers/clk/qcom/gcc-sm8150.c > > +++ b/drivers/clk/qcom/gcc-sm8150.c > > @@ -3448,6 +3448,15 @@ static struct clk_branch gcc_video_xo_clk = { > > }, > > }; > > > > Is it available on sm8150 or only on sa8155au? I think this deserves > at least a comment. > The ethernet controller is there on SM8150 as well. Regards, Bjorn > > +static struct gdsc emac_gdsc = { > > + .gdscr = 0x6004, > > + .pd = { > > + .name = "emac_gdsc", > > + }, > > + .pwrsts = PWRSTS_OFF_ON, > > + .flags = POLL_CFG_GDSCR, > > +}; > > + > > static struct gdsc usb30_prim_gdsc = { > > .gdscr = 0xf004, > > .pd = { > > @@ -3714,6 +3723,7 @@ static const struct qcom_reset_map gcc_sm8150_resets[] = { > > }; > > > > static struct gdsc *gcc_sm8150_gdscs[] = { > > + [EMAC_GDSC] = &emac_gdsc, > > [USB30_PRIM_GDSC] = &usb30_prim_gdsc, > > [USB30_SEC_GDSC] = &usb30_sec_gdsc, > > }; > > diff --git a/include/dt-bindings/clock/qcom,gcc-sm8150.h b/include/dt-bindings/clock/qcom,gcc-sm8150.h > > index 3e1a91876610..40596b9ded06 100644 > > --- a/include/dt-bindings/clock/qcom,gcc-sm8150.h > > +++ b/include/dt-bindings/clock/qcom,gcc-sm8150.h > > @@ -243,5 +243,6 @@ > > /* GCC GDSCRs */ > > #define USB30_PRIM_GDSC 4 > > #define USB30_SEC_GDSC 5 > > +#define EMAC_GDSC 6 > > > > #endif > > -- > > 2.35.1 > > > > > -- > With best wishes > Dmitry