From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC835C433F5 for ; Fri, 25 Mar 2022 14:34:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353994AbiCYOgJ (ORCPT ); Fri, 25 Mar 2022 10:36:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237056AbiCYOgI (ORCPT ); Fri, 25 Mar 2022 10:36:08 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F079853E2C; Fri, 25 Mar 2022 07:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648218875; x=1679754875; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=zUmqoASe1g47J7WaVh6lOsEwgkOYKF3XKkW5XTAmW/c=; b=Ek2zmGs7TJya4TdRy9DsP71aKoUZXVcsI3dGHJL0+o3GeNb1JlccOfep AGB+Luj2ELB7V2u3z/DTYRJJ9VKHES5KcHf9Bp4Y5PPRnfNijWPUf8b5x RIaSEk/GOAk9dyDMSh7JuthXL0efePf/L5yZpNVWf3oUjZf6KKLkPyj5H DxWKImmUiX+UB2s6SSvHQR+MoaCLMDPxJV9jsvtq3APcS9ITRmkGFx225 4mKTRWUGEFjHEAEt7uq73AqOtlf9sbZVATXMMEbK4znMNfBle0xNn427M kgeEnqzaHtahRIZ03P4yib4uTUUDS3mCW3iV2fSg409vOFi2exzUt55Xc A==; X-IronPort-AV: E=McAfee;i="6200,9189,10296"; a="246120474" X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="246120474" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2022 07:34:34 -0700 X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="602067416" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2022 07:34:30 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nXl0k-006RYj-8d; Fri, 25 Mar 2022 16:33:54 +0200 Date: Fri, 25 Mar 2022 16:33:54 +0200 From: Andy Shevchenko To: =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= Cc: Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Wolfram Sang , Peter Rosin , Rob Herring , Frank Rowand , Len Brown , Hans de Goede , Thomas Petazzoni , Alexandre Belloni , Allan Nielsen , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 4/9] device property: add fwnode_property_read_string_index() Message-ID: References: <20220325113148.588163-1-clement.leger@bootlin.com> <20220325113148.588163-5-clement.leger@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220325113148.588163-5-clement.leger@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Mar 25, 2022 at 12:31:43PM +0100, Clément Léger wrote: > Add fwnode_property_read_string_index() function which allows to > retrieve a single string from an array by its index. This function is > the equivalent of of_property_read_string_index() but for fwnode > support. ... > + ret = fwnode_call_int_op(fwnode, property_read_string_array, propname, > + string, 1, index); > + if (ret == -EINVAL && !IS_ERR_OR_NULL(fwnode) && > + !IS_ERR_OR_NULL(fwnode->secondary)) > + ret = fwnode_call_int_op(fwnode->secondary, > + property_read_string_array, propname, > + string, 1, index); This is not fully correct. See [1] for the details. I hope to send the new version just after the merge window ends. [1]: https://lore.kernel.org/lkml/20220308123712.18613-1-andriy.shevchenko@linux.intel.com/ -- With Best Regards, Andy Shevchenko