From: Andrew Lunn <andrew@lunn.ch>
To: Prasanna Vengateshan <prasanna.vengateshan@microchip.com>
Cc: netdev@vger.kernel.org, olteanv@gmail.com, robh+dt@kernel.org,
UNGLinuxDriver@microchip.com, woojung.huh@microchip.com,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
kuba@kernel.org, linux-kernel@vger.kernel.org,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v9 net-next 08/11] net: dsa: microchip: add support for ethtool port counters
Date: Sun, 20 Mar 2022 02:26:39 +0100 [thread overview]
Message-ID: <YjaCz0gqm846RAk5@lunn.ch> (raw)
In-Reply-To: <20220318085540.281721-9-prasanna.vengateshan@microchip.com>
On Fri, Mar 18, 2022 at 02:25:37PM +0530, Prasanna Vengateshan wrote:
> Added support for get_eth_**_stats() (phy/mac/ctrl) and
> get_stats64()
>
> Reused the KSZ common APIs for get_ethtool_stats() & get_sset_count()
> along with relevant lan937x hooks for KSZ common layer and added
> support for get_strings()
> +static void lan937x_get_stats64(struct dsa_switch *ds, int port,
> + struct rtnl_link_stats64 *s)
> +{
> + struct ksz_device *dev = ds->priv;
> + struct ksz_port_mib *mib = &dev->ports[port].mib;
> + u64 *ctr = mib->counters;
> +
> + mutex_lock(&mib->cnt_mutex);
I think for stats64 you are not allowed to block.
https://lore.kernel.org/netdev/20220218104330.g3vfbpdqltdkp4sr@skbuf/T/
There was talk of changing this. but i don't think it ever happened.
Andrew
next prev parent reply other threads:[~2022-03-20 1:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 8:55 [PATCH v9 net-next 00/11] net: dsa: microchip: DSA driver support for LAN937x switch Prasanna Vengateshan
2022-03-18 8:55 ` [PATCH v9 net-next 01/11] dt-bindings: net: make internal-delay-ps based on phy-mode Prasanna Vengateshan
2022-03-20 0:41 ` Andrew Lunn
2022-03-20 2:13 ` Rob Herring
2022-03-18 8:55 ` [PATCH v9 net-next 02/11] dt-bindings: net: add mdio property Prasanna Vengateshan
2022-03-20 0:41 ` Andrew Lunn
2022-03-21 23:27 ` Rob Herring
2022-03-22 14:46 ` Prasanna Vengateshan
2022-03-22 14:56 ` Rob Herring
2022-03-18 8:55 ` [PATCH v9 net-next 03/11] dt-bindings: net: dsa: dt bindings for microchip lan937x Prasanna Vengateshan
2022-03-20 0:49 ` Andrew Lunn
2022-03-21 20:19 ` Prasanna Vengateshan
2022-03-18 8:55 ` [PATCH v9 net-next 04/11] net: dsa: move mib->cnt_ptr reset code to ksz_common.c Prasanna Vengateshan
2022-03-18 8:55 ` [PATCH v9 net-next 05/11] net: dsa: tag_ksz: add tag handling for Microchip LAN937x Prasanna Vengateshan
2022-03-18 8:55 ` [PATCH v9 net-next 06/11] net: dsa: microchip: add DSA support for microchip lan937x Prasanna Vengateshan
2022-03-20 1:17 ` Andrew Lunn
2022-03-21 20:09 ` Prasanna Vengateshan
2022-03-18 8:55 ` [PATCH v9 net-next 07/11] net: dsa: microchip: add support for phylink management Prasanna Vengateshan
2022-03-18 8:55 ` [PATCH v9 net-next 08/11] net: dsa: microchip: add support for ethtool port counters Prasanna Vengateshan
2022-03-20 1:26 ` Andrew Lunn [this message]
2022-03-21 19:33 ` Prasanna Vengateshan
2022-03-18 8:55 ` [PATCH v9 net-next 09/11] net: dsa: microchip: add support for port mirror operations Prasanna Vengateshan
2022-03-18 11:00 ` Vladimir Oltean
2022-03-21 20:22 ` Prasanna Vengateshan
2022-03-18 8:55 ` [PATCH v9 net-next 10/11] net: dsa: microchip: add support for fdb and mdb management Prasanna Vengateshan
2022-03-18 8:55 ` [PATCH v9 net-next 11/11] net: dsa: microchip: add support for vlan operations Prasanna Vengateshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjaCz0gqm846RAk5@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=prasanna.vengateshan@microchip.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).