public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
Cc: linux-media@vger.kernel.org, Linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, heiko@sntech.de, hverkuil@xs4all.nl
Subject: Re: [PATCH v2 3/3] dt-bindings: media: rockchip-vpu: Add RK3568 compatible
Date: Sun, 20 Mar 2022 09:39:26 -0300	[thread overview]
Message-ID: <YjcgflUuQlFbVM/1@eze-laptop> (raw)
In-Reply-To: <20220214212955.1178947-3-piotr.oniszczuk@gmail.com>

Hi Piotr,

On Mon, Feb 14, 2022 at 10:29:55PM +0100, Piotr Oniszczuk wrote:
> From: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
> 
> RK356x has Hantro G1 video decoder capable to decode MPEG2/H.264/VP8
> video formats.
> 
> This patch adds RK3568 compatible in rockchip-vpu dt-bindings.
> 
> Tested on [1] with FFmpeg v4l2_request code taken from [2]
> with MPEG2, H.642 and VP8 samples with results [3].
> 
> [1] https://github.com/warpme/minimyth2
> [2] https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/multimedia/ffmpeg/patches/v4l2-request/ffmpeg-001-v4l2-request.patch
> [3] https://github.com/warpme/minimyth2/blob/master/video-test-summary.txt
> 
> Signed-off-by: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>

Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

This dt-binding change looks trivial, so I guess it's fine
taking it directly via the media tree?

Thanks,
Ezequiel

> ---
>  Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> index bacb60a34989..6cc4d3e5a61d 100644
> --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> @@ -23,6 +23,7 @@ properties:
>            - rockchip,rk3328-vpu
>            - rockchip,rk3399-vpu
>            - rockchip,px30-vpu
> +          - rockchip,rk3568-vpu
>        - items:
>            - const: rockchip,rk3188-vpu
>            - const: rockchip,rk3066-vpu
> -- 
> 2.29.2
> 

       reply	other threads:[~2022-03-20 12:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220214212955.1178947-1-piotr.oniszczuk@gmail.com>
     [not found] ` <20220214212955.1178947-3-piotr.oniszczuk@gmail.com>
2022-03-20 12:39   ` Ezequiel Garcia [this message]
2022-04-21 11:13     ` [PATCH v2 3/3] dt-bindings: media: rockchip-vpu: Add RK3568 compatible Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjcgflUuQlFbVM/1@eze-laptop \
    --to=ezequiel@vanguardiasur.com.ar \
    --cc=Linux-rockchip@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=piotr.oniszczuk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox