devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: virtio,mmio: Allow setting devices 'dma-coherent'
@ 2022-03-10  1:35 Rob Herring
  2022-03-20 19:08 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2022-03-10  1:35 UTC (permalink / raw)
  To: Michael S. Tsirkin, Jason Wang, Krzysztof Kozlowski,
	Jean-Philippe Brucker
  Cc: virtualization, devicetree, linux-kernel

'virtio,mmio' devices are always coherent within a guest. As Arm DTs
are default non-coherent, the 'dma-coherent' property needs to be set on
the virtio device to mark them as such. This aligns with the QEMU 'virt'
machine DTB.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/virtio/mmio.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml
index 4b7a0273181c..10c22b5bd16a 100644
--- a/Documentation/devicetree/bindings/virtio/mmio.yaml
+++ b/Documentation/devicetree/bindings/virtio/mmio.yaml
@@ -20,6 +20,8 @@ properties:
   reg:
     maxItems: 1
 
+  dma-coherent: true
+
   interrupts:
     maxItems: 1
 
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: virtio,mmio: Allow setting devices 'dma-coherent'
  2022-03-10  1:35 [PATCH] dt-bindings: virtio,mmio: Allow setting devices 'dma-coherent' Rob Herring
@ 2022-03-20 19:08 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2022-03-20 19:08 UTC (permalink / raw)
  To: Rob Herring
  Cc: virtualization, devicetree, linux-kernel, Jason Wang,
	Jean-Philippe Brucker, Michael S. Tsirkin, Krzysztof Kozlowski

On Wed, 09 Mar 2022 19:35:27 -0600, Rob Herring wrote:
> 'virtio,mmio' devices are always coherent within a guest. As Arm DTs
> are default non-coherent, the 'dma-coherent' property needs to be set on
> the virtio device to mark them as such. This aligns with the QEMU 'virt'
> machine DTB.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/virtio/mmio.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-20 19:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-10  1:35 [PATCH] dt-bindings: virtio,mmio: Allow setting devices 'dma-coherent' Rob Herring
2022-03-20 19:08 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).