From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: michael.srba@seznam.cz, Lars-Peter Clausen <lars@metafoo.de>,
Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Document invensense,icm20608d
Date: Sun, 20 Mar 2022 13:56:18 -0400 [thread overview]
Message-ID: <Yjdqwlp4NFpuj4vT@robh.at.kernel.org> (raw)
In-Reply-To: <20220320151525.34db502c@jic23-huawei>
On Sun, Mar 20, 2022 at 03:15:25PM +0000, Jonathan Cameron wrote:
> On Fri, 11 Mar 2022 17:15:59 +0100
> michael.srba@seznam.cz wrote:
>
> > From: Michael Srba <Michael.Srba@seznam.cz>
> >
> > ICM-20608-D differs from the other ICM-20608 variants by having
> > a DMP (Digital Motion Processor) core tacked on.
> > Despite having a different WHOAMI register, this variant is
> > completely interchangeable with the other ICM-20608 variants
> > by simply pretending the DMP core doesn't exist.
> >
> > Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> > ---
> > changelog:
> > - v2: require specifying "invensense,icm20608" as a fallback compatible
>
> Apologies that I joined the thread for v1 late, but no. That doesn't work.
> If the older driver before the new ID is present with this binding
> it won't probe because of the WHOAMI value difference so it's not
> compatible.
>
> I'm fine with the v1 version.
If the driver didn't check WHOAMI then it would be compatible. So does
driver implementation determine what's compatible or not? It shouldn't
as those are supposed to be decoupled.
Generally, if there are h/w id registers, then we'll rely on them and
don't need a compatible for every variant.
Rob
next prev parent reply other threads:[~2022-03-20 17:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 16:15 [PATCH v2 0/2] iio: imu: inv_mpu6050: Add support for ICM-20608-D michael.srba
2022-03-11 16:15 ` [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Document invensense,icm20608d michael.srba
2022-03-11 17:15 ` Krzysztof Kozlowski
2022-03-12 3:41 ` Rob Herring
2022-03-20 15:15 ` Jonathan Cameron
2022-03-20 17:56 ` Rob Herring [this message]
2022-03-21 14:58 ` Jonathan Cameron
2022-03-11 16:16 ` [PATCH v2 2/2] iio: imu: inv_mpu6050: Add support for ICM-20608-D michael.srba
2022-03-11 17:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjdqwlp4NFpuj4vT@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=jmaneyrol@invensense.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=michael.srba@seznam.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).