From: Rob Herring <robh@kernel.org>
To: Lucas Tanure <tanureal@opensource.cirrus.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
David Rhodes <drhodes@opensource.cirrus.com>
Subject: Re: [PATCH v4 15/16] ASoC: dt-bindings: cs35l41: Document CS35l41 External Boost
Date: Sun, 20 Mar 2022 14:03:15 -0400 [thread overview]
Message-ID: <YjdsY9tcuDmvYYQk@robh.at.kernel.org> (raw)
In-Reply-To: <20220317093120.168534-16-tanureal@opensource.cirrus.com>
On Thu, Mar 17, 2022 at 09:31:19AM +0000, Lucas Tanure wrote:
> From: David Rhodes <drhodes@opensource.cirrus.com>
>
> Document internal and external boost feature for ASoC CS35L41.
> For internal boost the following properties are required:
> - cirrus,boost-peak-milliamp
> - cirrus,boost-ind-nanohenry
> - cirrus,boost-cap-microfarad
>
> For external boost, the GPIO1 must be configured as output,
> so the following properties are required:
> - cirrus,gpio1-src-select = <1>
> - cirrus,gpio1-output-enable
>
> Signed-off-by: David Rhodes <drhodes@opensource.cirrus.com>
> Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
> ---
> .../bindings/sound/cirrus,cs35l41.yaml | 44 +++++++++++++++++--
> 1 file changed, 41 insertions(+), 3 deletions(-)
With the indentation fixed,
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-03-20 18:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 9:31 [PATCH v4 00/16] Support external boost at CS35l41 ASoC driver Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 01/16] sound: cs35l41: Unify hardware configuration Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 02/16] sound: cs35l41: Check hw_config before using it Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 03/16] sound: cs35l41: Move cs35l41_gpio_config to shared lib Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 04/16] ALSA: hda: cs35l41: Fix I2S params comments Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 05/16] ALSA: hda: cs35l41: Always configure the DAI Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 06/16] ALSA: hda: cs35l41: Add Boost type flag Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 07/16] hda: cs35l41: Put the device into safe mode for external boost Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 08/16] hda: cs35l41: Mute the device before shutdown Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 09/16] sound: cs35l41: Enable Internal Boost in shared lib Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 10/16] ALSA: hda: cs35l41: Move boost config to initialization code Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 11/16] ALSA: hda: cs35l41: Remove cs35l41_hda_reg_sequence struct Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 12/16] ALSA: hda: cs35l41: Reorganize log for playback actions Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 13/16] ALSA: hda: cs35l41: Handle all external boost setups the same way Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 14/16] ALSA: hda: cs35l41: Move external boost handling to lib for ASoC use Lucas Tanure
2022-03-17 9:31 ` [PATCH v4 15/16] ASoC: dt-bindings: cs35l41: Document CS35l41 External Boost Lucas Tanure
2022-03-18 11:13 ` Charles Keepax
2022-03-20 2:13 ` Rob Herring
2022-03-20 18:03 ` Rob Herring [this message]
2022-03-17 9:31 ` [PATCH v4 16/16] ASoC: cs35l41: Support external boost Lucas Tanure
2022-03-22 13:21 ` [PATCH v4 00/16] Support external boost at CS35l41 ASoC driver Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjdsY9tcuDmvYYQk@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drhodes@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).