From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80984C433FE for ; Mon, 21 Mar 2022 08:48:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240865AbiCUItp (ORCPT ); Mon, 21 Mar 2022 04:49:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243523AbiCUIto (ORCPT ); Mon, 21 Mar 2022 04:49:44 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 211F136315 for ; Mon, 21 Mar 2022 01:48:18 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id o7-20020a05600c4fc700b0038c87edc21eso2604219wmq.0 for ; Mon, 21 Mar 2022 01:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=brnXMh1CbWOf98YxRTTsbDywHUHYCG+alkGn638zm4M=; b=BlvyFCPLzsBlbqrGCBKMzUMgqnN4kBv+EO9dx8QQtssv6ckryQh3ESbB0tYPRif6dL PQn/As6uwDdRoWY21u8wppLgTnZykIXKGSFnDgt5Po/mkiunB+qy9MsDY0yTY/uKF3WB sAs24txOAa24hCWmiTH5GQ5e/6zgUSgXaQ/s5vHQCnF7ZqYuBFE8jlJ271X3Ifp3kSbk oRviKWNDfWLbKPJgE5HwmEtlVjLHpSWY8BjQzOumsFJdcizDE0EhG6WrDquo1l55Bjhb 01MutrJ5hAhUt8Zx0TeSLGebmKBFqikFDcqdcQ5V9/MzSWjEheVNeNdpOQPPiqstNcwj MpQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=brnXMh1CbWOf98YxRTTsbDywHUHYCG+alkGn638zm4M=; b=t6auTLYVDGXbu7L96BbZNTbzIriaRJ3RxV7h7Sdm6IKl5kBzQ43gkC0nG76P8SlQpt mJwmcd0UcqxZxvk88VQWHMWTCMqRGIWwf1aAJEcC2GD0KgXH0/vPjXvEyI6X5ebEHavv ee7iwbKPZZJI/G/7EcUCaUqrH6p93EzN0gJonq3phKTtMu2de09iVdDeVurQVuo+Amh8 2sGvrNg7GejG/HARIoRP9MA9qwnmZShx+cVCTw1wBlnpda14rGVGzf43FYmOjfLN3xt0 B6VqRqr9JFM3g2pZkHrTmdRa4UPuYOHJ0f6trhwAtzAYGTVz/leQWcO3olv09q19D6c+ FGeg== X-Gm-Message-State: AOAM533qPiMwfb7Q83vcllAbeFBcsmLoSiVIH+vnlKFc5Gj8MRi9/0Pm G1kD07xttxxmCUN6ExWCHh4djJ3VPM4iew== X-Google-Smtp-Source: ABdhPJxnXFWsEU7vaoMmlVg9NGIu10kQCl58O2xgYQ/I7PBvG0Dpr0PE2qPzya1IuKdxtEa00L4u6A== X-Received: by 2002:a7b:c14d:0:b0:38c:801a:a8b3 with SMTP id z13-20020a7bc14d000000b0038c801aa8b3mr15884385wmi.40.1647852496516; Mon, 21 Mar 2022 01:48:16 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id y6-20020a05600015c600b00203fa70b4ebsm8691375wry.53.2022.03.21.01.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 01:48:15 -0700 (PDT) Date: Mon, 21 Mar 2022 08:48:13 +0000 From: Lee Jones To: Alistair Francis Cc: Guenter Roeck , Geert Uytterhoeven , Alistair Francis , Mark Brown , Rob Herring , Sascha Hauer , Liam Girdwood , Linux PM list , linux-hwmon@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , NXP Linux Team , Zhang Rui , Amit Kucheria , Linux ARM , Andreas Kemnade , Sascha Hauer , Linux Kernel Mailing List , Shawn Guo Subject: Re: [PATCH v18 2/8] mfd: simple-mfd-i2c: Add a Kconfig name Message-ID: References: <20220124121009.108649-1-alistair@alistair23.me> <20220124121009.108649-3-alistair@alistair23.me> <7792b3b6-e196-c3c7-5875-9eb4da488a95@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 21 Mar 2022, Alistair Francis wrote: > On Sun, Mar 20, 2022 at 12:48 AM Guenter Roeck wrote: > > > > On 3/19/22 02:28, Geert Uytterhoeven wrote: > > > Hi Alistair, > > > > > > On Sat, Mar 19, 2022 at 3:36 AM Alistair Francis wrote: > > >> On Tue, Mar 8, 2022 at 8:53 PM Geert Uytterhoeven wrote: > > >>> Thanks for your patch, which is now commit bae5a4acef67db88 > > >>> ("mfd: simple-mfd-i2c: Add a Kconfig name") in mfd/for-mfd-next. > > >>> > > >>> On Mon, Jan 24, 2022 at 1:24 PM Alistair Francis wrote: > > >>>> Add a Kconfig name to the "Simple Multi-Functional Device support (I2C)" > > >>>> device so that it can be enabled via menuconfig. > > >>> > > >>> Which still does not explain why this would be needed... > > >>> > > >>>> Signed-off-by: Alistair Francis > > >>>> Acked-for-MFD-by: Lee Jones > > >>> > > >>>> --- a/drivers/mfd/Kconfig > > >>>> +++ b/drivers/mfd/Kconfig > > >>>> @@ -1188,7 +1188,7 @@ config MFD_SI476X_CORE > > >>>> module will be called si476x-core. > > >>>> > > >>>> config MFD_SIMPLE_MFD_I2C > > >>>> - tristate > > >>>> + tristate "Simple Multi-Functional Device support (I2C)" > > >>>> depends on I2C > > >>>> select MFD_CORE > > >>>> select REGMAP_I2C > > >>> > > >>> The help text states: > > >>> > > >>> | This driver creates a single register map with the intention for it > > >>> | to be shared by all sub-devices. > > >>> > > >>> Yes, that's what MFD does? > > >>> > > >>> | Once the register map has been successfully initialised, any > > >>> | sub-devices represented by child nodes in Device Tree will be > > >>> | subsequently registered. > > >>> > > >>> OK...? > > >>> > > >>> Still, no clue about what this driver really does, and why and when > > >>> it would be needed. > > >>> > > >>> There is one driver symbol that selects MFD_SIMPLE_MFD_I2C. > > >>> There are no driver symbols that depend on this symbol. > > >>> > > >>> If you have a driver in the pipeline that can make use of this, > > >>> can't it just select MFD_SIMPLE_MFD_I2C, so the symbol itself can > > >>> stay invisible? > > >> > > >> My patch "mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a" > > >> allows using this driver for the silergy,sy7636a MFD. So it's nice to > > >> be able to enable and disable it as required. > > > > > > So after that patch, enabling MFD_SIMPLE_MFD_I2C will enable > > > support for an ever-growing random bunch of devices, none of which > > > is described in the help text? > > > To me, ghat doesn't look like the way to go forward... > > > > > > > I am probably missing something. Why not something like the following ? > > > > config MFD_SY7636A > > tristate "Silergy SY7636A voltage regulator" > > depends on I2C > > select MFD_SIMPLE_MFD_I2C > > help > > Enable support for Silergy SY7636A voltage regulator. > > > > To enable support for building sub-devices as modules, > > choose M here. > > > > > > This would be quite similar to MFD_SL28CPLD which essentially does > > the same (and, unless I am missing something, doesn't have its own > > driver either). Sub-devices would then depend on MFD_SY7636A. > > That's fine with me. > > As you said this patch is already in the mfd/for-mfd-next tree, should > I resend the series? Making the symbol selectable-only is fine with me also. Please send a subsequent patch. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog