From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: bleung@chromium.org, groeck@chromium.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] platform/chrome: cros_kbd_led_backlight: support EC PWM backend
Date: Mon, 21 Mar 2022 15:18:18 +0800 [thread overview]
Message-ID: <Yjgmut/HndnYsPVE@google.com> (raw)
In-Reply-To: <20220318170751.GA687500@roeck-us.net>
On Fri, Mar 18, 2022 at 10:07:51AM -0700, Guenter Roeck wrote:
> On Mon, Mar 14, 2022 at 05:08:35PM +0800, Tzung-Bi Shih wrote:
> > @@ -142,6 +142,12 @@ config CROS_KBD_LED_BACKLIGHT_ACPI
> > help
> > ChromeOS keyboard backlight ACPI backend.
> >
> > +config CROS_KBD_LED_BACKLIGHT_EC_PWM
> > + tristate "ChromeOS keyboard backlight EC PWM backend"
>
> This is not a standa-alone module and should therefore be bool,
> not tristate.
Ack.
> > @@ -123,34 +130,122 @@ static const struct keyboard_led_drvdata keyboard_led_drvdata_acpi = {
> >
> > #endif /* IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_ACPI) */
> >
> > +#if IS_ENABLED(CONFIG_CROS_KBD_LED_BACKLIGHT_EC_PWM)
>
> #ifdef (with bool) should do.
Ack. Will apply the fix for CONFIG_CROS_KBD_LED_BACKLIGHT_ACPI too.
prev parent reply other threads:[~2022-03-21 7:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 9:08 [PATCH v2 0/5] platform/chrome: cros_kbd_led_backlight: add EC PWM backend Tzung-Bi Shih
2022-03-14 9:08 ` [PATCH v2 1/5] platform/chrome: cros_kbd_led_backlight: sort headers alphabetically Tzung-Bi Shih
2022-03-18 17:09 ` Guenter Roeck
2022-03-14 9:08 ` [PATCH v2 2/5] platform/chrome: cros_kbd_led_backlight: separate ACPI backend Tzung-Bi Shih
2022-03-14 9:08 ` [PATCH v2 3/5] dt-bindings: add google,cros-kbd-led-backlight Tzung-Bi Shih
2022-03-14 9:08 ` [PATCH v2 4/5] platform/chrome: cros_kbd_led_backlight: support OF match Tzung-Bi Shih
2022-03-18 17:04 ` Guenter Roeck
2022-03-14 9:08 ` [PATCH v2 5/5] platform/chrome: cros_kbd_led_backlight: support EC PWM backend Tzung-Bi Shih
2022-03-18 17:07 ` Guenter Roeck
2022-03-21 7:18 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjgmut/HndnYsPVE@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).