From: Sam Ravnborg <sam@ravnborg.org>
To: Christophe Branchereau <cbranchereau@gmail.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/4] drm/panel: Add panel driver for NewVision NV3052C based LCDs
Date: Mon, 21 Mar 2022 12:40:46 +0100 [thread overview]
Message-ID: <YjhkPnr46IOy5iS+@ravnborg.org> (raw)
In-Reply-To: <CAFsFa87NBB8VFFHJKjyPi+A255i9dyE-xxTggz3kLcEXmSWJXg@mail.gmail.com>
Hi Christophe,
> > > + { 0x0d, 0x58 },
> > > + { 0x0e, 0x48 },
> > > + { 0x0f, 0x38 },
> > > + { 0x10, 0x2b },
> > > +
> > > + { 0xff, 0x30 },
> > > + { 0xff, 0x52 },
> > > + { 0xff, 0x00 },
> > > + { 0x36, 0x0a },
> > > +};
> > There are some random (?) empty lines.
> > If they have any significance then a short comment would be nice.
> > If not, then drop the empty lines.
> >
>
> The empty lines are not random no, to access a different page in the
> init, one must write i.e. { 0xff, 0x30 }, { 0xff, 0x52 }, { 0xff,
> 0x02 }, to access page 2, so they add a little bit of readability.
Then I suggest to just say what page is is like:
/* Page 1 */
{ 0xff, 0x30 },
...
Etc. then it is obvious this is page boundaries.
Sam
next prev parent reply other threads:[~2022-03-21 11:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 17:02 [PATCH v4 0/4] Ingenic DRM bridge_atomic_enable proposal Christophe Branchereau
2022-03-11 17:02 ` [PATCH v4 1/4] drm/ingenic : add ingenic_drm_bridge_atomic_enable Christophe Branchereau
2022-03-14 19:57 ` Paul Cercueil
2022-03-11 17:02 ` [PATCH v4 2/4] drm/panel: Add panel driver for NewVision NV3052C based LCDs Christophe Branchereau
2022-03-14 19:54 ` Paul Cercueil
2022-03-21 13:14 ` Christophe Branchereau
2022-03-15 20:23 ` Sam Ravnborg
2022-03-21 9:36 ` Christophe Branchereau
2022-03-21 11:40 ` Sam Ravnborg [this message]
2022-03-11 17:02 ` [PATCH v4 3/4] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable Christophe Branchereau
2022-03-11 17:02 ` [PATCH v4 4/4] dt-bindings: display/panel: Add Leadtek ltk035c5444t Christophe Branchereau
2022-03-12 3:47 ` Rob Herring
2022-03-17 20:10 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjhkPnr46IOy5iS+@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=cbranchereau@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).