From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84FC1C433EF for ; Mon, 21 Mar 2022 15:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347809AbiCUPQF (ORCPT ); Mon, 21 Mar 2022 11:16:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236185AbiCUPQE (ORCPT ); Mon, 21 Mar 2022 11:16:04 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F56EEDF2A for ; Mon, 21 Mar 2022 08:14:39 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id w8so13004815pll.10 for ; Mon, 21 Mar 2022 08:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Vi2+JCSaediMV4fIRxpn8hEQFvyNR6zHSaSxlfbydg8=; b=mLSbZHC5mXRJErPc17RhtONtOQCHY8pq0NzHcS7uaZ910+4dxBn9jTc0IKBXhFIuhs ccpSCGG4YvS1YN8hLFwH9A5NWkZfCHOywaFpvlU4UTxmL0QBCB1k3SuyD7GUEQzF+U+u AKPENS44CZC7tmpv3Ny11bGHLN9JK8YhNonpU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Vi2+JCSaediMV4fIRxpn8hEQFvyNR6zHSaSxlfbydg8=; b=4+pOYHYaYhlhJpwPEfxxxFHwln99T+P70NW82W9Xnm3mE0AExRKir3fdM3TEOU5fF9 RNtSvzzJnMIFVZWYDa9+vlnPRYoREwCLaE/F/afCKAHdGKkpEmJGvQkS3nZE/YVU5lyo aDVQJnTjAOtLK1XrPC8D8rCvs4gLeyZPzsgj8ViAjktk4n9xltw/vFQWM/BxSN5QwKCK qZ5ancn0bKamKC7BL4tY1ZaTXS42uzs49oO5u8BAhxq4VE6HxBaL7pZ0qH23CBCGxeZI RLIrju6aeq8pER6JHlB9pdMq6V6dRXKhVxjFR2+1H2OxWQDfQlOkpfdusfG2eZvuxJTB 9zbQ== X-Gm-Message-State: AOAM533FkiHmRf7B0aqzD2rHgnLojo539x3qlTHcSFgXar133aXOrYX2 C5CwDUNJfpLLaUcttO3DZggPVw== X-Google-Smtp-Source: ABdhPJxSC/CLQYd2LeqNM7sSaZIcmei/abLlLofHzwrzcpTZquto/ceY3Edydh9kY4LGGH98pFuBMQ== X-Received: by 2002:a17:902:ce8e:b0:154:2ebc:8d49 with SMTP id f14-20020a170902ce8e00b001542ebc8d49mr11701225plg.135.1647875679186; Mon, 21 Mar 2022 08:14:39 -0700 (PDT) Received: from localhost ([2620:15c:202:201:b32a:e805:a393:534b]) by smtp.gmail.com with UTF8SMTPSA id s3-20020a056a00194300b004f6da3a1a3bsm20367875pfk.8.2022.03.21.08.14.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 08:14:38 -0700 (PDT) Date: Mon, 21 Mar 2022 08:14:36 -0700 From: Matthias Kaehlcke To: Rajendra Nayak Cc: Andy Gross , Bjorn Andersson , Rob Herring , Stephen Boyd , devicetree@vger.kernel.org, Douglas Anderson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: Add 'piglin' to the crd-r3 compatible strings Message-ID: References: <20220316172814.v1.1.I2deda8f2cd6adfbb525a97d8fee008a8477b7b0e@changeid> <20220316172814.v1.2.Ib0fbb7e5218201c81a2d064ff13c9bc1b0863212@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Mar 21, 2022 at 11:14:56AM +0530, Rajendra Nayak wrote: > > On 3/17/2022 5:58 AM, Matthias Kaehlcke wrote: > > With newer bootloader versions the crd-r3 (aka CRD 1.0 and 2.0) is > > identified as a 'piglin' board (like the IDP2 board), instead of 'hoglin' > > Add the compatible strings 'google,piglin-rev{3,4}'. The hoglin entries > > are kept to make sure the board keeps booting with older bootloader > > versions. > > The older bootloaders really look for the google,hoglin-rev3/google,hoglin-rev4 > compatibles or just google,hoglin? If its just google,hoglin, won;t it pick the > crd-rev5+ dtb now? They look for the -revN compatible, I confirmed that on my CRD 2.0.