From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32AEFC433F5 for ; Mon, 21 Mar 2022 15:23:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241448AbiCUPZA (ORCPT ); Mon, 21 Mar 2022 11:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350076AbiCUPY7 (ORCPT ); Mon, 21 Mar 2022 11:24:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6D2B25E9C; Mon, 21 Mar 2022 08:23:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7AAB1B817C2; Mon, 21 Mar 2022 15:23:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2884C340E8; Mon, 21 Mar 2022 15:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647876211; bh=4ZpyIyXYDcZ36RfZOIv4oxh4lJ+vIIHH8n+8gbprSCg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FLUh+ySfIHCMJccWzOujn77JxsZSejOrwn2p+855hwyPXkF77aZrr9VGfNd3TNBae Jv/ZNWbw9RsZ+dfUJ84+PcHkfujZL0NeibCYTsty4A6WSXYyMYGmUmcj2w2lcgxd4P cf8c1Gms39QL09R0tr7PAs6V8cKQg33YUUbBvLVsjcnKMHMgi57S0ZTfSyDw1nfGl/ HoyUkLDdnEeKZ8mYgoL+WPh+F2bKLY/gcv6y9AFrzpORCRUSuBTM7+tSlEiZbuUDU6 80L7Ocezq1BqkwgAuVGW8CVX5utlXtGw9ev6MzSOKgVw2psVepJdNKjc6a5a4AXINL /VeaMprAovbNg== Date: Mon, 21 Mar 2022 23:23:26 +0800 From: Tzung-Bi Shih To: Jiaxin Yu Cc: broonie@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linmq006@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, linux-mediatek@lists.infradead.org, trevor.wu@mediatek.com, matthias.bgg@gmail.com, aaronyu@google.com, linux-arm-kernel@lists.infradead.org, angelogioacchino.delregno@collabora.com Subject: Re: [v5 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset Message-ID: References: <20220319114111.11496-1-jiaxin.yu@mediatek.com> <20220319114111.11496-4-jiaxin.yu@mediatek.com> <17e6e8895ebc1113911481c7e097b394005db123.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Mar 21, 2022 at 10:38:48PM +0800, Jiaxin Yu wrote: > On Mon, 2022-03-21 at 17:21 +0800, Tzung-Bi Shih wrote: > > On Mon, Mar 21, 2022 at 05:14:08PM +0800, Jiaxin Yu wrote: > > > On Mon, 2022-03-21 at 11:59 +0800, Tzung-Bi Shih wrote: > > > > On Sat, Mar 19, 2022 at 07:41:10PM +0800, Jiaxin Yu wrote: > > > > > @@ -1145,6 +1140,13 @@ static int > > > > > mt8192_mt6359_dev_probe(struct > > > > > platform_device *pdev) > > > > > goto err_speaker_codec; > > > > > } > > > > > > > > > > + headset_codec = of_get_child_by_name(pdev->dev.of_node, > > > > > "mediatek,headset-codec"); > > > > > + if (!headset_codec) { > > > > > + ret = -EINVAL; > > > > > + dev_err_probe(&pdev->dev, ret, "Property > > > > > 'headset_codec' missing or invalid\n"); > > > > > + goto err_headset_codec; > > > > > + } > > > > > > > > (to be neat) Does it have any reason to prevent from using > > > > of_parse_phandle() > > > > but of_get_child_by_name()? > > > > > > "mediatek,headset-codec" is a child node of pdev->dev.of_node, so I > > > use > > > of_get_child_by_name() to get and pass it to > > > snd_soc_of_get_dai_link_codecs(). > > > > "mediatek,platform" and "mediatek,hdmi-codec" are also children of > > pdev->dev.of_node. I guess my question is: why doesn't it also use > > of_parse_phandle() for "mediatek,headset-codec"? Did I > > misunderstand? > > The following is from bindings, "mediatek,speaker-codec" and > "mediatek,headset-codec" are sub nodes of sound but "mediatek,platform" > and "mediatek,hdmi-codec" are the name of properties. So we can't get > the sub node pointer through of_parse_phandle(). > > sound: mt8192-sound { > compatible = "mediatek,mt8192_mt6359_rt1015_rt5682"; > mediatek,platform = <&afe>; > mediatek,hdmi-codec = <&anx_bridge_dp>; > pinctrl-names = "aud_clk_mosi_off", > "aud_clk_mosi_on"; > pinctrl-0 = <&aud_clk_mosi_off>; > pinctrl-1 = <&aud_clk_mosi_on>; > > mediatek,headset-codec { > sound-dai = <&rt5682>; > }; > > mediatek,speaker-codec { > sound-dai = <&rt1015_l>, > <&rt1015_r>; > }; > }; Got it, thanks for the explanation. Will provide my R-b tag in another thread.