From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E21FDC433EF for ; Tue, 22 Mar 2022 21:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237109AbiCVV7P (ORCPT ); Tue, 22 Mar 2022 17:59:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237198AbiCVV7O (ORCPT ); Tue, 22 Mar 2022 17:59:14 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A57896F4A8 for ; Tue, 22 Mar 2022 14:57:46 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 26E0FDFA; Tue, 22 Mar 2022 22:57:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1647986264; bh=gAE39Xube/yFEa4AH8cqoScCpNo0W4bh0jKxjwaqy2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BcckQ7g9Z/3r6vP0jiZN9cyeEunWTiID9ZX7QlcBTZeQnH8t8XbANR8AljIH21Lpr T0GmQGn4TvgeYQl/knJms3hDHHXIV1LdsLchnyqplIhxo/6fqHosUwMCAriALDmb3U xVttKLAZlfz0Vi/F5njPCwOQqJ/rUao0udh9YL1E= Date: Tue, 22 Mar 2022 23:57:26 +0200 From: Laurent Pinchart To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Fabio Estevam , Paul Elder , Lucas Stach , devicetree@vger.kernel.org, Rob Herring Subject: Re: [PATCH v2 1/4] dt-bindings: soc: Add i.MX8MP media block control DT bindings Message-ID: References: <20220322190324.12589-1-laurent.pinchart@ideasonboard.com> <20220322190324.12589-2-laurent.pinchart@ideasonboard.com> <3f7bdca8-0da7-fe2d-7bcb-9768b12bb759@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3f7bdca8-0da7-fe2d-7bcb-9768b12bb759@denx.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marek, On Tue, Mar 22, 2022 at 10:29:56PM +0100, Marek Vasut wrote: > On 3/22/22 20:03, Laurent Pinchart wrote: > > From: Paul Elder > > > > The i.MX8MP Media Block Control (MEDIA BLK_CTRL) is a top-level > > peripheral providing access to the NoC and ensuring proper power > > sequencing of the peripherals within the MEDIAMIX domain. Add DT > > bindings for it. > > > > There is already a driver for block controls of other SoCs in the i.MX8M > > family, so these bindings will expand upon that. > > > > Signed-off-by: Paul Elder > > Reviewed-by: Rob Herring > > Reviewed-by: Laurent Pinchart > > Signed-off-by: Laurent Pinchart > > Reviewed-by: Marek Vasut > > [...] > > > + power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi", > > + "mipi-csi2", "lcdif2", "isp2", "isp1", "dwe", > > + "mipi-dsi2"; > > Nit, I cannot say I'm a big fan of calling the power domain "mipi-csi1" > and "mipi-csi2", they are both MIPI CSI2, except there are two of them > CSI2 (#1 and #2). > > Maybe mipi-csi2-1 and mipi-csi2-2 would be better ? DTTO for the LCDIF, > where we have lcdifv3 and then mx8mp lcdifv3 and eventually we will have > power domain for lcdif #3 instance in this SoC in hdmimix, so maybe some > lcdif-1/lcdif-2 would be a better name ? The names come from the reference manual, at least the ones for the second instance. We have, for instance, SFT_EN_MIPI_CSI_PCLK_RESETN and SFT_EN_MIPI_CSI2_PCLK_RESETN. Same for DSI and LCDIF, there's DSI and DSI2, and LCDIF and LCDIF2. The "1" suffix has been added for clarity. This is a bit bikeshedding territory as I expect the DT node for the media-blk-ctrl to be written once and never be touched again, so if anyone feels strongly about using better names (whatever those better names would be), I don't mind much. I can submit a v3 once a consensus emerges. -- Regards, Laurent Pinchart