* [PATCH v3 0/6] Input: edt-ft5x06 - Improve configuration
@ 2022-03-13 16:34 Dario Binacchi
2022-03-13 16:34 ` [PATCH v3 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz Dario Binacchi
0 siblings, 1 reply; 3+ messages in thread
From: Dario Binacchi @ 2022-03-13 16:34 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Dmitry Torokhov, Marco Felsch, Michael Trimarchi,
Oliver Graute, Rob Herring, Stephan Gerhold, devicetree,
linux-input
The series was born from the analysis and mitigation of a crc problem
raised by an M06 type device. The added sysfs attributes were helpful
in debugging the problem. Patches that change the report rate on driver
probing, mitigated crc errors on kernel bootup. The patch to get/set
report rate by sysfs for an M12 device, has been tested.
Changes in v3:
- Add hz unit suffix to report-rate dts property.
- Add '|' to report-rate-hz description in the yaml document.
- Check the lower and upper limits of the report-rate-hz value
- Convert the M06 report-rate-hz value
Changes in v2:
- Add Oliver Graute's 'Acked-by' tag to:
* Input: edt-ft5x06 - show model name by sysfs
* Input: edt-ft5x06 - show firmware version by sysfs
- Fix yaml file. Tested with `make DT_CHECKER_FLAGS=-m dt_binding_check'.
Dario Binacchi (6):
dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz
Input: edt-ft5x06 - get/set M12 report rate by sysfs
Input: edt-ft5x06 - set report rate by dts property
Input: edt-ft5x06 - show model name by sysfs
Input: edt-ft5x06 - show firmware version by sysfs
Input: edt-ft5x06 - show crc and header errors by sysfs
.../input/touchscreen/edt-ft5x06.yaml | 8 ++
drivers/input/touchscreen/edt-ft5x06.c | 103 ++++++++++++++++--
2 files changed, 103 insertions(+), 8 deletions(-)
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz
2022-03-13 16:34 [PATCH v3 0/6] Input: edt-ft5x06 - Improve configuration Dario Binacchi
@ 2022-03-13 16:34 ` Dario Binacchi
2022-03-23 17:54 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Dario Binacchi @ 2022-03-13 16:34 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Michael Trimarchi, Dmitry Torokhov, Rob Herring,
Stephan Gerhold, devicetree, linux-input
It allows to change the M06/M12 default scan rate.
Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
Changes in v3:
- Add hz unit suffix.
- Add '|' to description.
.../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
index 2e8da7470513..46bc8c028fe6 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
@@ -85,6 +85,14 @@ properties:
minimum: 0
maximum: 80
+ report-rate-hz:
+ description: |
+ Allows setting the scan rate in Hertz.
+ M06 supports range from 30 to 140 Hz.
+ M12 supports range from 1 to 255 Hz.
+ minimum: 1
+ maximum: 255
+
touchscreen-size-x: true
touchscreen-size-y: true
touchscreen-fuzz-x: true
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz
2022-03-13 16:34 ` [PATCH v3 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz Dario Binacchi
@ 2022-03-23 17:54 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-03-23 17:54 UTC (permalink / raw)
To: Dario Binacchi
Cc: devicetree, Michael Trimarchi, Dmitry Torokhov, linux-kernel,
Stephan Gerhold, Rob Herring, linux-input
On Sun, 13 Mar 2022 17:34:58 +0100, Dario Binacchi wrote:
> It allows to change the M06/M12 default scan rate.
>
> Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
> ---
>
> Changes in v3:
> - Add hz unit suffix.
> - Add '|' to description.
>
> .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-23 17:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-13 16:34 [PATCH v3 0/6] Input: edt-ft5x06 - Improve configuration Dario Binacchi
2022-03-13 16:34 ` [PATCH v3 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz Dario Binacchi
2022-03-23 17:54 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).