[PATCH 1/2] dt-bindings: display: simple: Add AUO B133UAN01 panel

[PATCH 1/2] dt-bindings: display: simple: Add AUO B133UAN01 panel

[Matthias Kaehlcke]

Add binding for the AUO B133UAN01 panel. It is 13.3" TFT LCD panel
with WUXGA (1920x1200) resolution.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---

 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 1eb9dd4f8f58..e5cd45c81d02 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -49,6 +49,8 @@ properties:
       - auo,b133han05
         # AU Optronics Corporation 13.3" FHD (1920x1080) color TFT-LCD panel
       - auo,b133htn01
+        # AU Optronics Corporation 13.3" WUXGA (1920x1200) color TFT-LCD panel
+      - auo,b133uan01
         # AU Optronics Corporation 13.3" WXGA (1366x768) TFT LCD panel
       - auo,b133xtn01
         # AU Optronics Corporation 14.0" FHD (1920x1080) color TFT-LCD panel
-- 
2.35.1.1021.g381101b075-goog

[PATCH 2/2] drm/panel-edp: Add AUO B133UAN01

[Matthias Kaehlcke]

Add support for the AUO B133UAN01 13.3" WUXGA panel.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
output of edid-decode:

  Block 0, Base EDID:
    EDID Structure Version & Revision: 1.4
    Vendor & Product Identification:
      Manufacturer: AUO
      Model: 34196
      Made in: 2020
    Basic Display Parameters & Features:
      Digital display
      Bits per primary color channel: 8
      DisplayPort interface
      Maximum image size: 29 cm x 18 cm
      Gamma: 2.20
      Supported color formats: RGB 4:4:4
      First detailed timing includes the native pixel format and preferred refresh rate
    Color Characteristics:
      Red  : 0.6513, 0.3271
      Green: 0.2900, 0.6279
      Blue : 0.1503, 0.0517
      White: 0.3134, 0.3291
    Established Timings I & II: none
    Standard Timings: none
    Detailed Timing Descriptors:
      DTD 1:  1920x1200   60.026 Hz   8:5    74.192 kHz 156.100 MHz (286 mm x 178 mm)
                   Hfront   16 Hsync  16 Hback 152 Hpol N
                   Vfront    3 Vsync  14 Vback  19 Vpol N
      Manufacturer-Specified Display Descriptor (0x0f): 00 0f 00 00 00 00 00 00 00 00 00 00 00 00 00 20 '............... '
      Alphanumeric Data String: 'AUO'
      Alphanumeric Data String: 'B133UAN01.0 '

 drivers/gpu/drm/panel/panel-edp.c | 32 +++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index e15e62f235d8..2e71dcb734aa 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1043,6 +1043,35 @@ static const struct panel_desc auo_b133htn01 = {
 	},
 };
 
+static const struct drm_display_mode auo_b133uan01_mode = {
+	.clock = 156100,
+	.hdisplay = 1920,
+	.hsync_start = 1920 + 16,
+	.hsync_end = 1920 + 16 + 16,
+	.htotal = 1920 + 16 + 16 + 152,
+	.vdisplay = 1200,
+	.vsync_start = 1200 + 3,
+	.vsync_end = 1200 + 3 + 14,
+	.vtotal = 1200 + 3 + 14 + 19,
+	.flags = DISPLAY_FLAGS_VSYNC_LOW | DISPLAY_FLAGS_HSYNC_LOW,
+};
+
+static const struct panel_desc auo_b133uan01 = {
+	.modes = &auo_b133uan01_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 291,
+		.height = 195,
+	},
+
+	.delay = {
+		.hpd_reliable = 200,
+		.enable = 50,
+		.unprepare = 500,
+	},
+};
+
 static const struct drm_display_mode auo_b133xtn01_mode = {
 	.clock = 69500,
 	.hdisplay = 1366,
@@ -1720,6 +1749,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "auo,b133htn01",
 		.data = &auo_b133htn01,
+	}, {
+		.compatible = "auo,b133uan01",
+		.data = &auo_b133uan01,
 	}, {
 		.compatible = "auo,b133xtn01",
 		.data = &auo_b133xtn01,
-- 
2.35.1.1021.g381101b075-goog

Re: [PATCH 2/2] drm/panel-edp: Add AUO B133UAN01

[Doug Anderson]

Hi,

On Thu, Mar 24, 2022 at 11:14 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> Add support for the AUO B133UAN01 13.3" WUXGA panel.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> output of edid-decode:
>
>   Block 0, Base EDID:
>     EDID Structure Version & Revision: 1.4
>     Vendor & Product Identification:
>       Manufacturer: AUO
>       Model: 34196
>       Made in: 2020
>     Basic Display Parameters & Features:
>       Digital display
>       Bits per primary color channel: 8
>       DisplayPort interface
>       Maximum image size: 29 cm x 18 cm
>       Gamma: 2.20
>       Supported color formats: RGB 4:4:4
>       First detailed timing includes the native pixel format and preferred refresh rate
>     Color Characteristics:
>       Red  : 0.6513, 0.3271
>       Green: 0.2900, 0.6279
>       Blue : 0.1503, 0.0517
>       White: 0.3134, 0.3291
>     Established Timings I & II: none
>     Standard Timings: none
>     Detailed Timing Descriptors:
>       DTD 1:  1920x1200   60.026 Hz   8:5    74.192 kHz 156.100 MHz (286 mm x 178 mm)
>                    Hfront   16 Hsync  16 Hback 152 Hpol N
>                    Vfront    3 Vsync  14 Vback  19 Vpol N
>       Manufacturer-Specified Display Descriptor (0x0f): 00 0f 00 00 00 00 00 00 00 00 00 00 00 00 00 20 '............... '
>       Alphanumeric Data String: 'AUO'
>       Alphanumeric Data String: 'B133UAN01.0 '
>
>  drivers/gpu/drm/panel/panel-edp.c | 32 +++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

I can review this patch and it can be landed if you really need it,
but I'd prefer not to. Instead I'd rather see the panel added to
_just_ the "edp_panels" structure. That maps the panel ID to the
delays. If we do it that way:

1. We don't need the binding.

2. We don't need to hardcode the mode in this file.

3. We support second sourcing the panel.

4. We simplify our device tree files.


Let me know if we can just go that way. If we really have a reason to
support the old hardcoded mode we can land something like this but I'd
rather avoid it if possible.

Also: note that even if we land this, adding the entry to the
"edp_panels" structure would help future-proof us a bit.

-Doug

Re: [PATCH 2/2] drm/panel-edp: Add AUO B133UAN01

[Matthias Kaehlcke]

Hi Doug,

On Thu, Mar 24, 2022 at 11:27:46AM -0700, Doug Anderson wrote:
> Hi,
> 
> On Thu, Mar 24, 2022 at 11:14 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> >
> > Add support for the AUO B133UAN01 13.3" WUXGA panel.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > output of edid-decode:
> >
> >   Block 0, Base EDID:
> >     EDID Structure Version & Revision: 1.4
> >     Vendor & Product Identification:
> >       Manufacturer: AUO
> >       Model: 34196
> >       Made in: 2020
> >     Basic Display Parameters & Features:
> >       Digital display
> >       Bits per primary color channel: 8
> >       DisplayPort interface
> >       Maximum image size: 29 cm x 18 cm
> >       Gamma: 2.20
> >       Supported color formats: RGB 4:4:4
> >       First detailed timing includes the native pixel format and preferred refresh rate
> >     Color Characteristics:
> >       Red  : 0.6513, 0.3271
> >       Green: 0.2900, 0.6279
> >       Blue : 0.1503, 0.0517
> >       White: 0.3134, 0.3291
> >     Established Timings I & II: none
> >     Standard Timings: none
> >     Detailed Timing Descriptors:
> >       DTD 1:  1920x1200   60.026 Hz   8:5    74.192 kHz 156.100 MHz (286 mm x 178 mm)
> >                    Hfront   16 Hsync  16 Hback 152 Hpol N
> >                    Vfront    3 Vsync  14 Vback  19 Vpol N
> >       Manufacturer-Specified Display Descriptor (0x0f): 00 0f 00 00 00 00 00 00 00 00 00 00 00 00 00 20 '............... '
> >       Alphanumeric Data String: 'AUO'
> >       Alphanumeric Data String: 'B133UAN01.0 '
> >
> >  drivers/gpu/drm/panel/panel-edp.c | 32 +++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> 
> I can review this patch and it can be landed if you really need it,
> but I'd prefer not to. Instead I'd rather see the panel added to
> _just_ the "edp_panels" structure. That maps the panel ID to the
> delays. If we do it that way:
> 
> 1. We don't need the binding.
> 
> 2. We don't need to hardcode the mode in this file.
> 
> 3. We support second sourcing the panel.
> 
> 4. We simplify our device tree files.
> 
> 
> Let me know if we can just go that way. If we really have a reason to
> support the old hardcoded mode we can land something like this but I'd
> rather avoid it if possible.
> 
> Also: note that even if we land this, adding the entry to the
> "edp_panels" structure would help future-proof us a bit.

Thanks for your suggestion, it seems it should be possible to support the
panel as you described, which I agree is preferable. I'll send a new
version without the binding and the hardcoded mode.

Re: [PATCH 1/2] dt-bindings: display: simple: Add AUO B133UAN01 panel

[Doug Anderson]

Hi,

On Thu, Mar 24, 2022 at 11:14 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> Add binding for the AUO B133UAN01 panel. It is 13.3" TFT LCD panel
> with WUXGA (1920x1200) resolution.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
>  .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 1eb9dd4f8f58..e5cd45c81d02 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -49,6 +49,8 @@ properties:
>        - auo,b133han05
>          # AU Optronics Corporation 13.3" FHD (1920x1080) color TFT-LCD panel
>        - auo,b133htn01
> +        # AU Optronics Corporation 13.3" WUXGA (1920x1200) color TFT-LCD panel
> +      - auo,b133uan01

Breadcrumbs to save Rob Herring from responding is that we're moving
to do this using the eDP autodetect feature instead of adding a new
compatible. v2 is at:

https://lore.kernel.org/r/20220324134819.v2.1.I816014b6c62da5a33af5021f3cc35cea66552c00@changeid/

-Doug