devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Keerthy <j-keerthy@ti.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 1/4] dt-bindings: timer: Add am6 compatible for ti-timer
Date: Fri, 8 Apr 2022 10:43:21 +0300	[thread overview]
Message-ID: <Yk/nmTNL4tm0sd1X@atomide.com> (raw)
In-Reply-To: <20220408073418.4yjs3ykt34fhqjco@boondocks>

* Nishanth Menon <nm@ti.com> [220408 07:31]:
> On 07:38-20220408, Tony Lindgren wrote:
> > Hi,
> > 
> > * Nishanth Menon <nm@ti.com> [220407 13:31]:
> > > On 10:10-20220407, Tony Lindgren wrote:
> > > > diff --git a/Documentation/devicetree/bindings/timer/ti,timer.txt b/Documentation/devicetree/bindings/timer/ti,timer.txt
> > > > --- a/Documentation/devicetree/bindings/timer/ti,timer.txt
> > > > +++ b/Documentation/devicetree/bindings/timer/ti,timer.txt
> > > > @@ -14,6 +14,7 @@ Required properties:
> > > >  			ti,omap5430-timer (applicable to OMAP543x devices)
> > > >  			ti,am335x-timer	(applicable to AM335x devices)
> > > >  			ti,am335x-timer-1ms (applicable to AM335x devices)
> > > > +			ti,am6-timer (applicable to AM6 devices)
> > > 
> > > Suggestion:
> > > 
> > > Could we call this ti,am65-timer instead? AM6 is a bit nuanced and spans
> > > a couple of sub SoC architectures.
> > 
> > I think the timer hardware is the same across am64, am65 and j7. So we
> > should pick something to represent the am6 timers as it would allow using
> > shared dtsi files for the 16 - 30 timers there are.
> > 
> > Using shared timer dtsi files should work as long as the clocks are
> > defined in include/dt-bindings/clock for each SoC, and assuming we can use
> > the same compatible property for the timers.
> 
> Compatible should work fine, Though I doubt clock and other indices
> (base address etc will scale appropriately), but we could give it a
> shot, but we can discuss that in the context of the dts patches.

Yeah that's a separate series for sure and can be done later on after we
have am6 timers working first.

> > Of course if the timers are really different across am64, am65 and j72
> > then multiple compatible properties are neeeded.
> > 
> > If the timer hardware is the same, then I guess we should just pick the
> > earliest version, so how about using ti,am64-timer?
> 
> yep - the oldest version will be ti,am654-timer ( AM65 was the first
> K3 device. Unfortunately, the numbering does'nt follow a chronological
> order)

OK great, I will use ti,am654-timer then.

Regards,

Tony

      reply	other threads:[~2022-04-08  7:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  7:10 [PATCH 1/4] dt-bindings: timer: Add am6 compatible for ti-timer Tony Lindgren
2022-04-07  7:10 ` [PATCH 2/4] clocksource/drivers/timer-ti-dm: Update defines for am6 for inline functions Tony Lindgren
2022-04-07  8:04   ` Daniel Lezcano
2022-04-07  8:15     ` Tony Lindgren
2022-04-07  8:26       ` Daniel Lezcano
2022-04-07  8:53         ` Tony Lindgren
2022-04-07 10:26           ` Tony Lindgren
2022-04-07 11:48             ` Daniel Lezcano
2022-04-07  7:10 ` [PATCH 3/4] clocksource/drivers/timer-ti-dm: Add compatible for am6 Tony Lindgren
2022-04-07  7:10 ` [PATCH 4/4] clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3 Tony Lindgren
2022-04-07  7:56 ` [PATCH 1/4] dt-bindings: timer: Add am6 compatible for ti-timer Krzysztof Kozlowski
2022-04-07 13:31 ` Nishanth Menon
2022-04-08  4:28   ` Tony Lindgren
2022-04-07 13:33 ` Nishanth Menon
2022-04-08  4:38   ` Tony Lindgren
2022-04-08  7:34     ` Nishanth Menon
2022-04-08  7:43       ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yk/nmTNL4tm0sd1X@atomide.com \
    --to=tony@atomide.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).