From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42414C433EF for ; Fri, 8 Apr 2022 07:43:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbiDHHp1 (ORCPT ); Fri, 8 Apr 2022 03:45:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229852AbiDHHp0 (ORCPT ); Fri, 8 Apr 2022 03:45:26 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B84DC1C025F; Fri, 8 Apr 2022 00:43:23 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 0A62A807E; Fri, 8 Apr 2022 07:40:58 +0000 (UTC) Date: Fri, 8 Apr 2022 10:43:21 +0300 From: Tony Lindgren To: Nishanth Menon Cc: Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Keerthy , Krzysztof Kozlowski , Rob Herring , Vignesh Raghavendra Subject: Re: [PATCH 1/4] dt-bindings: timer: Add am6 compatible for ti-timer Message-ID: References: <20220407071006.37031-1-tony@atomide.com> <20220407133344.v2x2b6rkmskatips@handled> <20220408073418.4yjs3ykt34fhqjco@boondocks> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408073418.4yjs3ykt34fhqjco@boondocks> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Nishanth Menon [220408 07:31]: > On 07:38-20220408, Tony Lindgren wrote: > > Hi, > > > > * Nishanth Menon [220407 13:31]: > > > On 10:10-20220407, Tony Lindgren wrote: > > > > diff --git a/Documentation/devicetree/bindings/timer/ti,timer.txt b/Documentation/devicetree/bindings/timer/ti,timer.txt > > > > --- a/Documentation/devicetree/bindings/timer/ti,timer.txt > > > > +++ b/Documentation/devicetree/bindings/timer/ti,timer.txt > > > > @@ -14,6 +14,7 @@ Required properties: > > > > ti,omap5430-timer (applicable to OMAP543x devices) > > > > ti,am335x-timer (applicable to AM335x devices) > > > > ti,am335x-timer-1ms (applicable to AM335x devices) > > > > + ti,am6-timer (applicable to AM6 devices) > > > > > > Suggestion: > > > > > > Could we call this ti,am65-timer instead? AM6 is a bit nuanced and spans > > > a couple of sub SoC architectures. > > > > I think the timer hardware is the same across am64, am65 and j7. So we > > should pick something to represent the am6 timers as it would allow using > > shared dtsi files for the 16 - 30 timers there are. > > > > Using shared timer dtsi files should work as long as the clocks are > > defined in include/dt-bindings/clock for each SoC, and assuming we can use > > the same compatible property for the timers. > > Compatible should work fine, Though I doubt clock and other indices > (base address etc will scale appropriately), but we could give it a > shot, but we can discuss that in the context of the dts patches. Yeah that's a separate series for sure and can be done later on after we have am6 timers working first. > > Of course if the timers are really different across am64, am65 and j72 > > then multiple compatible properties are neeeded. > > > > If the timer hardware is the same, then I guess we should just pick the > > earliest version, so how about using ti,am64-timer? > > yep - the oldest version will be ti,am654-timer ( AM65 was the first > K3 device. Unfortunately, the numbering does'nt follow a chronological > order) OK great, I will use ti,am654-timer then. Regards, Tony