From: Rob Herring <robh@kernel.org>
To: Abel Vesa <abel.vesa@nxp.com>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shawn Guo <shawnguo@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH v5 8/8] dt-bindings: net: dwmac-imx: Document clk_csr property
Date: Wed, 6 Apr 2022 13:04:13 -0500 [thread overview]
Message-ID: <Yk3WHSr+OGRxYCg0@robh.at.kernel.org> (raw)
In-Reply-To: <20220404134609.2676793-9-abel.vesa@nxp.com>
On Mon, Apr 04, 2022 at 04:46:09PM +0300, Abel Vesa wrote:
> The clk_csr property is used for CSR clock range selection.
Why?
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> index 011363166789..1556d95943f6 100644
> --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> @@ -32,6 +32,10 @@ properties:
> - nxp,imx8dxl-dwmac-eqos
> - const: snps,dwmac-5.10a
>
> + clk_csr:
s/_/-/
vendor prefix needed.
And a type is needed.
> + description: |
> + Fixed CSR Clock Range selection
What? Explain all this to someone that doesn't know your h/w.
> +
> clocks:
> minItems: 3
> items:
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2022-04-06 19:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 13:46 [PATCH v5 0/8] arm64: dts: Add i.MX8DXL initial support Abel Vesa
2022-04-04 13:46 ` [PATCH v5 1/8] arm64: dts: freescale: Add the top level dtsi support for imx8dxl Abel Vesa
2022-04-04 13:46 ` [PATCH v5 2/8] arm64: dts: freescale: Add adma subsystem dtsi " Abel Vesa
2022-04-04 13:46 ` [PATCH v5 3/8] arm64: dts: freescale: Add the imx8dxl connectivity subsys dtsi Abel Vesa
2022-04-04 13:46 ` [PATCH v5 4/8] arm64: dts: freescale: Add ddr subsys dtsi for imx8dxl Abel Vesa
2022-04-04 13:46 ` [PATCH v5 5/8] arm64: dts: freescale: Add lsio " Abel Vesa
2022-04-04 13:46 ` [PATCH v5 6/8] arm64: dts: freescale: Add i.MX8DXL evk board support Abel Vesa
2022-04-04 13:46 ` [PATCH v5 7/8] dt-bindings: fsl: scu: Add i.MX8DXL ocotp binding Abel Vesa
2022-04-04 13:46 ` [PATCH v5 8/8] dt-bindings: net: dwmac-imx: Document clk_csr property Abel Vesa
2022-04-06 18:04 ` Rob Herring [this message]
2022-04-13 7:36 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk3WHSr+OGRxYCg0@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).