From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9837FC433EF for ; Wed, 6 Apr 2022 20:23:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233955AbiDFUYz (ORCPT ); Wed, 6 Apr 2022 16:24:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236725AbiDFUYM (ORCPT ); Wed, 6 Apr 2022 16:24:12 -0400 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDC2E349538; Wed, 6 Apr 2022 11:43:20 -0700 (PDT) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-e1dcc0a327so3925332fac.1; Wed, 06 Apr 2022 11:43:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pe8sju6wPvJSrNfF1Eq2d0NpTEsa+xATy6yZpivcyyo=; b=kOivRFEJHI+w2eouwoiLEYmGL0JgO6ICU+xkf93gZTD45eeepp2HBg9Yis+a0JDDS4 r2YrhPcMOu+edjcuJANfFRrlNqpv7K2tsBmb+KK1d8i3OayzdAFGeiLvfg4y4XFfG7Cn jHyChCHMl9e57crE+l6k1YWVTMg4fKkvWAETAbsAWsEbeOGBgxHzDnjf9DZRwmD2Luxd gc+bhBZx7lroSBiZqU4+FRu71qVqv76eKl+LSczEEvEkkkQ4LZz8VJ/pxEXdh5vbMoS/ iFKSvGnIKaLn/bxm9p8Ih90PDsviOaJssFsyBU4kfLh73QtNOFmDMs4Eu3bLzLB/Hasw 2kWw== X-Gm-Message-State: AOAM5321d6EQZJDptj4e8qZS2Bcx6JF0iUYKUhVkxaC/NBN5FVUF1gkp bU/ZSHNlLLElKBtif/EXnTmKAOegKg== X-Google-Smtp-Source: ABdhPJybK5lLCphfL1x0DdD+DcfV1Sz7fJ99SXLEoZA420LGZz9AqrPtiqQNcfxb94eXkneiXCVC3g== X-Received: by 2002:a05:6870:e30e:b0:de:ecf4:df7e with SMTP id z14-20020a056870e30e00b000deecf4df7emr4782781oad.114.1649270599990; Wed, 06 Apr 2022 11:43:19 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id v17-20020a9d69d1000000b005b2319a08c4sm7048316oto.18.2022.04.06.11.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 11:43:19 -0700 (PDT) Received: (nullmailer pid 2564513 invoked by uid 1000); Wed, 06 Apr 2022 18:43:19 -0000 Date: Wed, 6 Apr 2022 13:43:19 -0500 From: Rob Herring To: Laurent Pinchart Cc: Patrick Rudolph , Peter Rosin , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v7 1/3] dt-bindings: i2c: Add Maxim MAX735x/MAX736x variants Message-ID: References: <20220405120552.433415-1-patrick.rudolph@9elements.com> <20220405120552.433415-2-patrick.rudolph@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Apr 05, 2022 at 04:46:34PM +0300, Laurent Pinchart wrote: > Hi Patrick, > > Thank you for the patch. > > On Tue, Apr 05, 2022 at 02:05:49PM +0200, Patrick Rudolph wrote: > > Update the pca954x bindings to add support for the Maxim MAX735x/MAX736x > > chips. The functionality will be provided by the exisintg pca954x driver. > > > > While on it make the interrupts support conditionally as not all of the > > existing chips have interrupts. > > > > For chips that are powered off by default add an optional regulator > > called vdd-supply. > > > > Signed-off-by: Patrick Rudolph > > --- > > .../bindings/i2c/i2c-mux-pca954x.yaml | 44 ++++++++++++++----- > > 1 file changed, 34 insertions(+), 10 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > > index 9f1726d0356b..132c3e54e7ab 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > > @@ -4,21 +4,48 @@ > > $id: http://devicetree.org/schemas/i2c/i2c-mux-pca954x.yaml# > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > -title: NXP PCA954x I2C bus switch > > +title: NXP PCA954x I2C and compatible bus switches > > > > maintainers: > > - Laurent Pinchart > > > > description: > > - The binding supports NXP PCA954x and PCA984x I2C mux/switch devices. > > + The binding supports NXP PCA954x and PCA984x I2C mux/switch devices, > > + and the Maxim MAX735x and MAX736x I2C mux/switch devices. > > > > allOf: > > - $ref: /schemas/i2c/i2c-mux.yaml# > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - maxim,max7367 > > + - maxim,max7369 > > + - nxp,pca9542 > > + - nxp,pca9543 > > + - nxp,pca9544 > > + - nxp,pca9545 > > + then: > > + properties: > > + interrupts: > > + maxItems: 1 > > + > > + "#interrupt-cells": > > + const: 2 > > + > > + interrupt-controller: true > > It feels a bit out of place to have those properties listed before the > main "properties" property, but we can only have a sincel allOf. I > wonder if the i2c-mux schema could be selected automatically based on > node name, but that's out of scope for this patch. Yes, just move the allOf below 'properties' > I thought it was more customary to define properties in the main > "properties" property, and then have Yes, please do. Rob