From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: align SPI NOR node name with dtschema
Date: Thu, 7 Apr 2022 14:03:03 -0500 [thread overview]
Message-ID: <Yk81Z5G+2B9arV9a@robh.at.kernel.org> (raw)
In-Reply-To: <67f75e49-e0c1-463f-da39-4a2efe7cce3c@linaro.org>
On Thu, Apr 07, 2022 at 05:23:40PM +0200, Krzysztof Kozlowski wrote:
> On 07/04/2022 17:15, Mark Brown wrote:
> > On Thu, Apr 07, 2022 at 04:34:05PM +0200, Krzysztof Kozlowski wrote:
> >> The node names should be generic and SPI NOR dtschema expects "flash".
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> Documentation/devicetree/bindings/mtd/hisilicon,fmc-spi-nor.txt | 2 +-
> >> Documentation/devicetree/bindings/spi/spi-davinci.txt | 2 +-
> >> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 2 +-
> >
> > Acked-by: Mark Brown <broonie@kernel.org>
> >
> > but it would be easier to split this into per subsystem stuff.
>
> With DTS changes I had 22 patches, so splitting is a trade-off. If
> that's preferred (actually can reduce conflicts), I'll split it and send
> a v2.
I've applied it.
Really, I would have just fixed spi-pl022.yaml. In general, I'm not that
interested in taking fixes on the .txt bindings.
Rob
prev parent reply other threads:[~2022-04-07 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 14:34 [PATCH] dt-bindings: align SPI NOR node name with dtschema Krzysztof Kozlowski
2022-04-07 14:52 ` Miquel Raynal
2022-04-07 15:15 ` Mark Brown
2022-04-07 15:23 ` Krzysztof Kozlowski
2022-04-07 19:03 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk81Z5G+2B9arV9a@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).