From: Rob Herring <robh@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH] dt-bindings: PCI: uniphier: Convert uniphier-pcie.txt to json-schema
Date: Mon, 28 Mar 2022 11:23:51 -0500 [thread overview]
Message-ID: <YkHhF7dF9SYS2qTx@robh.at.kernel.org> (raw)
In-Reply-To: <1648471865.799906.2153573.nullmailer@robh.at.kernel.org>
On Mon, Mar 28, 2022 at 07:51:05AM -0500, Rob Herring wrote:
> On Mon, 28 Mar 2022 11:11:38 +0900, Kunihiko Hayashi wrote:
> > Convert the file into a JSON description at the yaml format.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> > ---
> > .../bindings/pci/socionext,uniphier-pcie.yaml | 100 ++++++++++++++++++
> > .../devicetree/bindings/pci/uniphier-pcie.txt | 82 --------------
> > MAINTAINERS | 2 +-
> > 3 files changed, 101 insertions(+), 83 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> > delete mode 100644 Documentation/devicetree/bindings/pci/uniphier-pcie.txt
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1609988
>
>
> pcie@66000000: compatible: ['socionext,uniphier-pcie', 'snps,dw-pcie'] is too long
> arch/arm64/boot/dts/socionext/uniphier-ld20-akebi96.dt.yaml
> arch/arm64/boot/dts/socionext/uniphier-ld20-global.dt.yaml
> arch/arm64/boot/dts/socionext/uniphier-ld20-ref.dt.yaml
> arch/arm64/boot/dts/socionext/uniphier-pxs3-ref.dt.yaml
Ignore this if your intent is to fix these by dropping 'snps,dw-pcie'. I
think that is the right thing to do. 'snps,dw-pcie' is not too
meaningful.
Rob
next prev parent reply other threads:[~2022-03-28 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 2:11 [PATCH] dt-bindings: PCI: uniphier: Convert uniphier-pcie.txt to json-schema Kunihiko Hayashi
2022-03-28 12:51 ` Rob Herring
2022-03-28 16:23 ` Rob Herring [this message]
2022-03-29 10:55 ` Kunihiko Hayashi
2022-03-28 16:22 ` Rob Herring
2022-03-29 10:54 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkHhF7dF9SYS2qTx@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).