Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells

[Vinod Koul <vkoul@kernel.org>]

On 28-03-22, 19:43, Dmitry Baryshkov wrote:
> On Mon, 28 Mar 2022 at 18:30, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > The DSI node is not a bus and the children do not have unit addresses.
> >
> > Reported-by: Vinod Koul <vkoul@kernel.org>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> NAK.
> DSI panels are children of the DSI device tree node with the reg = <0>; address.
> This is the convention used by other platforms too (see e.g.
> arch/arm64/boot/dts/freescale/imx8mq-evk.dts).

So we should add reg = 0, i will update my dtsi fix

> With the DSI split link it is possible to attach two panels to a
> single DSI host, so addresses are necessary.
> 
> > ---
> >  .../bindings/display/msm/dsi-controller-main.yaml          | 7 -------
> >  1 file changed, 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> > index 7095ec3c890d..57f238f72326 100644
> > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> > @@ -51,10 +51,6 @@ properties:
> >    phy-names:
> >      const: dsi
> >
> > -  "#address-cells": true
> > -
> > -  "#size-cells": true
> > -
> >    syscon-sfpb:
> >      description: A phandle to mmss_sfpb syscon node (only for DSIv2).
> >      $ref: "/schemas/types.yaml#/definitions/phandle"
> > @@ -154,9 +150,6 @@ examples:
> >             reg = <0x0ae94000 0x400>;
> >             reg-names = "dsi_ctrl";
> >
> > -           #address-cells = <1>;
> > -           #size-cells = <0>;
> > -
> >             interrupt-parent = <&mdss>;
> >             interrupts = <4>;
> >
> > --
> > 2.32.0
> >
> 
> 
> -- 
> With best wishes
> Dmitry

-- 
~Vinod