devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: jic23@kernel.org, swboyd@chromium.org, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 7/8] dt-bindings: iio: sx9360: Add precharge resistor setting
Date: Tue, 29 Mar 2022 18:36:32 -0500	[thread overview]
Message-ID: <YkOYAIyI6gs9VbN4@robh.at.kernel.org> (raw)
In-Reply-To: <20220325220827.3719273-8-gwendal@chromium.org>

On Fri, Mar 25, 2022 at 03:08:26PM -0700, Gwendal Grignou wrote:
> Allow configure the resistance used during precharge.
> 
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> Changes since v2:
> - Change kOhms into ohms.
> 
> Changes since v1:
> - Suffix property with kOhms.
> 
>  .../bindings/iio/proximity/semtech,sx9360.yaml           | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml
> index 63e1a1fd00d4c..453d2f02abbb1 100644
> --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml
> +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml
> @@ -61,6 +61,14 @@ properties:
>        UINT_MAX (4294967295) represents infinite. Other values
>        represent 1-1/N.
>  
> +  semtech,input-precharge-resistor-ohms:
> +    default: 0
> +    description:
> +      Pre-charge input resistance in Ohm.
> +      Rounded down to a 2000 Ohm multiple.
> +    minimum: 0
> +    maximum: 30

This should give you a failure.

> +
>  required:
>    - compatible
>    - reg
> @@ -85,5 +93,6 @@ examples:
>          semtech,resolution = <256>;
>          semtech,proxraw-strength = <2>;
>          semtech,avg-pos-strength = <64>;
> +        semtech,input-precharge-resistor-ohms = <4000>;
>        };
>      };
> -- 
> 2.35.1.1021.g381101b075-goog
> 
> 

  parent reply	other threads:[~2022-03-29 23:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25 22:08 [PATCH v3 0/8] Add settings for precharge and internal resistor Gwendal Grignou
2022-03-25 22:08 ` [PATCH v3 1/8] iio: sx9324: Fix default precharge internal resistance register Gwendal Grignou
2022-03-25 23:57   ` Stephen Boyd
2022-03-27 19:01   ` Andy Shevchenko
2022-03-25 22:08 ` [PATCH v3 2/8] iio: sx9324: Fix register field spelling Gwendal Grignou
2022-03-25 23:57   ` Stephen Boyd
2022-03-25 22:08 ` [PATCH v3 3/8] dt-bindings: iio: sx9324: Add precharge resistor setting Gwendal Grignou
2022-03-25 23:58   ` Stephen Boyd
2022-03-29 23:33   ` Rob Herring
2022-03-25 22:08 ` [PATCH v3 4/8] iio: sx9324: Add precharge internal resistance setting Gwendal Grignou
2022-03-25 23:59   ` Stephen Boyd
2022-03-25 22:08 ` [PATCH v3 5/8] dt-bindings: iio: sx9324: Add internal compensation resistor setting Gwendal Grignou
2022-03-26  0:00   ` Stephen Boyd
2022-03-29 23:34   ` Rob Herring
2022-03-25 22:08 ` [PATCH v3 6/8] iio: sx9324: Add Setting for internal compensation resistor Gwendal Grignou
2022-03-26  0:04   ` Stephen Boyd
2022-03-27 13:43     ` Jonathan Cameron
2022-03-27 19:08   ` Andy Shevchenko
2022-03-25 22:08 ` [PATCH v3 7/8] dt-bindings: iio: sx9360: Add precharge resistor setting Gwendal Grignou
2022-03-26  0:04   ` Stephen Boyd
2022-03-29 23:36   ` Rob Herring [this message]
2022-03-25 22:08 ` [PATCH v3 8/8] iio: sx9360: Add pre-charge " Gwendal Grignou
2022-03-26  0:05   ` Stephen Boyd
2022-03-27 13:47 ` [PATCH v3 0/8] Add settings for precharge and internal resistor Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkOYAIyI6gs9VbN4@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).