From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Dylan Hung <dylan_hung@aspeedtech.com>
Cc: robh+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au,
andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com, p.zabel@pengutronix.de,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, BMC-SW@aspeedtech.com
Subject: Re: [PATCH v3 2/3] net: mdio: add reset control for Aspeed MDIO
Date: Thu, 31 Mar 2022 08:12:25 +0100 [thread overview]
Message-ID: <YkVUWV0czTzo6MrJ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220325041451.894-3-dylan_hung@aspeedtech.com>
Hi,
On Fri, Mar 25, 2022 at 12:14:50PM +0800, Dylan Hung wrote:
> Add reset assertion/deassertion for Aspeed MDIO. There are 4 MDIO
> controllers embedded in Aspeed AST2600 SOC and share one reset control
> register SCU50[3]. To work with old DT blobs which don't have the reset
> property, devm_reset_control_get_optional_shared is used in this change.
>
> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Should this really be specific to one driver rather than being handled
in the core mdio code?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-03-31 7:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 4:14 [PATCH v3 0/3] Add reset deassertion for Aspeed MDIO Dylan Hung
2022-03-25 4:14 ` [PATCH v3 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding Dylan Hung
2022-03-25 12:19 ` Krzysztof Kozlowski
2022-03-25 4:14 ` [PATCH v3 2/3] net: mdio: add reset control for Aspeed MDIO Dylan Hung
2022-03-31 7:12 ` Russell King (Oracle) [this message]
2022-04-07 6:29 ` Dylan Hung
2022-03-25 4:14 ` [PATCH v3 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes Dylan Hung
2022-03-29 4:45 ` [PATCH v3 0/3] Add reset deassertion for Aspeed MDIO Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkVUWV0czTzo6MrJ@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dylan_hung@aspeedtech.com \
--cc=hkallweit1@gmail.com \
--cc=joel@jms.id.au \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).