From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: niravkumar.l.rabara@intel.com
Cc: Arnd Bergmann <arnd@arndb.de>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add Altera hardware mutex driver
Date: Thu, 31 Mar 2022 15:57:39 +0200 [thread overview]
Message-ID: <YkWzU8dFT7Uom8mN@kroah.com> (raw)
In-Reply-To: <20220331214911.27194-1-niravkumar.l.rabara@intel.com>
On Fri, Apr 01, 2022 at 05:49:11AM +0800, niravkumar.l.rabara@intel.com wrote:
> ---
> .../bindings/misc/altera-hwmutex.yaml | 47 +++
> drivers/misc/Kconfig | 6 +
> drivers/misc/Makefile | 1 +
> drivers/misc/altera_hwmutex.c | 321 ++++++++++++++++++
> include/linux/altera_hwmutex.h | 42 +++
There is no need for a .h file for a single .c file. Please fix that up
for your next submission.
I don't think I need to read anymore :)
thanks,
greg k-h
next prev parent reply other threads:[~2022-03-31 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 21:49 [PATCH] Add Altera hardware mutex driver niravkumar.l.rabara
2022-03-31 13:56 ` Greg Kroah-Hartman
2022-03-31 13:57 ` Greg Kroah-Hartman [this message]
2022-04-01 14:04 ` Rob Herring
2022-04-01 14:08 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkWzU8dFT7Uom8mN@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=niravkumar.l.rabara@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox