From: Andrew Lunn <andrew@lunn.ch>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, hkallweit1@gmail.com,
linux@armlinux.org.uk, Divya.Koppera@microchip.com,
davem@davemloft.net, kuba@kernel.org, richardcochran@gmail.com,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net 2/3] net: phy: micrel: Remove latency from driver
Date: Fri, 1 Apr 2022 16:00:01 +0200 [thread overview]
Message-ID: <YkcFYb1SInTCDjIh@lunn.ch> (raw)
In-Reply-To: <20220401133454.ic6jxnripuxjhp5g@soft-dev3-1.localhost>
On Fri, Apr 01, 2022 at 03:34:54PM +0200, Horatiu Vultur wrote:
> The 04/01/2022 14:47, Andrew Lunn wrote:
> >
> > On Fri, Apr 01, 2022 at 11:48:04AM +0200, Horatiu Vultur wrote:
> > > Based on the discussions here[1], the PHY driver is the wrong place
> > > to set the latencies, therefore remove them.
> > >
> > > [1] https://lkml.org/lkml/2022/3/4/325
> > >
> > > Fixes: ece19502834d84 ("net: phy: micrel: 1588 support for LAN8814 phy")
> > > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> >
> > Thanks for the revert.
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> >
> > > -static struct kszphy_latencies lan8814_latencies = {
> > > - .rx_10 = 0x22AA,
> > > - .tx_10 = 0x2E4A,
> > > - .rx_100 = 0x092A,
> > > - .tx_100 = 0x02C1,
> > > - .rx_1000 = 0x01AD,
> > > - .tx_1000 = 0x00C9,
> > > -};
> >
> > What are the reset defaults of these?
>
> Those are actually the reset values.
Does the driver do a reset, so we can assume the hardware is actually
using these?
Andrew
next prev parent reply other threads:[~2022-04-01 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 9:48 [PATCH net 0/3] net: phy: micrel: Remove latencies support lan8814 Horatiu Vultur
2022-04-01 9:48 ` [PATCH net 1/3] dt-bindings: net: micrel: Revert latency support and timestamping check Horatiu Vultur
2022-04-01 12:37 ` Andrew Lunn
2022-04-01 9:48 ` [PATCH net 2/3] net: phy: micrel: Remove latency from driver Horatiu Vultur
2022-04-01 12:47 ` Andrew Lunn
2022-04-01 13:34 ` Horatiu Vultur
2022-04-01 13:59 ` Allan W. Nielsen
2022-04-01 14:05 ` Andrew Lunn
2022-04-01 14:00 ` Andrew Lunn [this message]
2022-04-01 9:48 ` [PATCH net 3/3] net: phy: micrel: Remove DT option lan8814,ignore-ts Horatiu Vultur
2022-04-01 12:47 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkcFYb1SInTCDjIh@lunn.ch \
--to=andrew@lunn.ch \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).