From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC203C4167E for ; Mon, 4 Apr 2022 21:16:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378929AbiDDVSY (ORCPT ); Mon, 4 Apr 2022 17:18:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380319AbiDDTbb (ORCPT ); Mon, 4 Apr 2022 15:31:31 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFF7620F41 for ; Mon, 4 Apr 2022 12:29:34 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id j8so8952782pll.11 for ; Mon, 04 Apr 2022 12:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QQK0u/1t7bvu65SH9gfd8Qr6GQ/JS9W+uuml8zfn2a8=; b=IRWgirC5/1yGKC93yfne3OYdJ9pDqFar0lGl96/Rld12mFQXDom5GO2t3ivbkNXrhT D2ssZXTI29QCSnDpT3Pk0vtss/PaHY9XNbsi+5Za9AftTNY5MYiexE5fwjeNKtBhMlrw NQ/nd+Fo5EaGA64McZZ2M64G+/+J+4ViGHfCc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QQK0u/1t7bvu65SH9gfd8Qr6GQ/JS9W+uuml8zfn2a8=; b=jDIkkSD0Wdryx+HTF7gfyMcJdYJ06c1P7W7FOEAhWZgK3JZ25IMubkfTbc1hkUEN1W gtBtTe7LTjjs6GHZYOZ2MSZaBlN6i9hZcewMTMpfLlq0xWHisLkmQq8/RisKX205Xq1g xpOmWtrJJ1pzqYn+/NlP9+gG8IHzTR4hO8dm3RExJrzPpuo2hTQAp8U0881EAh12OvLH IGyUpB/LVFNRLwPGhVJeveJnZwRCtMbsSxUMa62D0mRdADZS4TErTme01cd4EiLwEhsd azHnlvuicmiUQOr8Dbo34cuJ2uwC5MONS3KgRuojGROmQarveewXwdrNjPnWiRpsQYbb S01A== X-Gm-Message-State: AOAM533GeAjDN+iYErEEO7gL4MwOAMLWek4WU/g/SoJJj8DZMCqzn0z+ sUwvaCZmNJFYbx5WXPPnTEBDWw== X-Google-Smtp-Source: ABdhPJx69pSWNGeNxYAX4SX/Q4krTcMRZC4c2fenVI8+/TCxfsHtHPUxT4/uYSVl3XeN8u4J+LX0/g== X-Received: by 2002:a17:902:bf06:b0:156:af5b:e6c with SMTP id bi6-20020a170902bf0600b00156af5b0e6cmr1469346plb.147.1649100574399; Mon, 04 Apr 2022 12:29:34 -0700 (PDT) Received: from localhost ([2620:15c:202:201:1ebc:cb71:2a38:38db]) by smtp.gmail.com with UTF8SMTPSA id k18-20020a056a00135200b004fb18fc6c78sm13294266pfu.31.2022.04.04.12.29.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Apr 2022 12:29:34 -0700 (PDT) Date: Mon, 4 Apr 2022 12:29:32 -0700 From: Matthias Kaehlcke To: Manikanta Pubbisetty Cc: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3] arm64: dts: qcom: sc7280: Add WCN6750 WiFi node Message-ID: References: <20220328071057.2454-1-quic_mpubbise@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220328071057.2454-1-quic_mpubbise@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Mar 28, 2022 at 12:40:57PM +0530, Manikanta Pubbisetty wrote: > Add DTS node for WCN6750 WiFi chipset. > > Signed-off-by: Manikanta Pubbisetty > --- > Depends on: > - https://patchwork.kernel.org/project/linux-arm-msm/patch/20220328070701.28551-1-quic_mpubbise@quicinc.com/ > - https://patchwork.kernel.org/project/linux-wireless/patch/20220328060937.16738-2-quic_mpubbise@quicinc.com/ > > Changes from V2: > - Changes based on DT binding concerns > - Rebased on ToT > > Changes from V1: > - Corrected the case for hex values > > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 7 ++++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 46 ++++++++++++++++++++++++ > 2 files changed, 53 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 069ffbc37bc4..a82e9aa7bdc5 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -551,3 +551,10 @@ &remoteproc_wpss { > status = "okay"; > }; > > +&wifi { > + status = "okay"; > + wifi-firmware { > + iommus = <&apps_smmu 0x1c02 0x1>; > + }; > +}; > + > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index b757e8ad1199..dfd9fa077903 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -85,6 +85,11 @@ reserved-memory { > #size-cells = <2>; > ranges; > > + wlan_ce_mem: memory@4cd000 { > + no-map; > + reg = <0x0 0x4cd000 0x0 0x1000>; Pad the address to 8 digits here (not in the node name). > + }; > + > hyp_mem: memory@80000000 { > reg = <0x0 0x80000000 0x0 0x600000>; > no-map; > @@ -1808,6 +1813,47 @@ mmss_noc: interconnect@1740000 { > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > + wifi: wifi@17a10040 { > + compatible = "qcom,wcn6750-wifi"; > + reg = <0 0x17a10040 0 0x0>; > + iommus = <&apps_smmu 0x1c00 0x1>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + qcom,rproc = <&remoteproc_wpss>; > + memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>; Where is 'wlan_fw_mem' added?