From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD80C433EF for ; Tue, 19 Apr 2022 17:16:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244974AbiDSRT1 (ORCPT ); Tue, 19 Apr 2022 13:19:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244331AbiDSRTZ (ORCPT ); Tue, 19 Apr 2022 13:19:25 -0400 Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E08137031 for ; Tue, 19 Apr 2022 10:16:42 -0700 (PDT) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-e5c42b6e31so8248459fac.12 for ; Tue, 19 Apr 2022 10:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Hh2D5T9O1nXJSpyowbHfBZ/qDBEIO6Yb28qotohzW6M=; b=PF5p5rMhgy6pOrHUjITOkzIIX/nu4CrsUEAI+OBpKM/fAcN184LtuvQhGc7XWvwWFE QDev0y1bfAYpdtra2JSbiWBHdcQ1/jItqtGzgN38KQ1T+WkpasC22m3z/6Dvs4eVnwot dxdm7PwEXo96wJMV2xgHNXY/xiYgN78E8Ks1BJ8l6AN5KHRlVxY/dNgK5LLtZqqEobg3 tD422XHJlvCy9K5VxFCKDdjs29GEwsnG/pqC73i/Ph5gebgUYf59ePs1UPWF6bj8LNjH uBkNJCZJrNuQNYRBK98Y5sVJj+nKUFOsE6CX6BocknUrg9+PozAJ37nuZXJLWu2Kretm +M/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Hh2D5T9O1nXJSpyowbHfBZ/qDBEIO6Yb28qotohzW6M=; b=AvX8txmVJFX/IGls0fjctmEbePRW2l1IwWz/1PZcq9whN1XWbIZ4jxtaPkGUfWYIu3 7y9cSi+vA5mMsdBibA5YV8rd9EnYkxEPdnd7xO57D28Eucv6qfgDLjbHpwkVqzrDQ6px 648yY19xoZ0Vjbbchc2UdL8UD00GBbGHpTcYU6jszXF1tgDklp93rrE1r5kl4ieLwbhp FzJ+zDoKVxvG7ZLuupAF4lHtD4CiXciIBSUt7twI1jlyWduT8fXn6KeclE8OrZfooE5w b8Th0apCXIDhdggp3IBaXwA2l3QKWRD6fhEPB+mvbvg/36Gh1FCtJkfRBq/38MKhpG16 tfuw== X-Gm-Message-State: AOAM532y15rPjEAiyJStP2mE90Ezo7wwo9HiDTS+V+rY8Li0gA7HEIKV 2UIsV/75wEY4ierL/C906aKtVA== X-Google-Smtp-Source: ABdhPJwIEiPzWUmSnN/IgWCCz0AcpbNlwnqSyMLhTp4TCVTK0JlV1SdRxsJYUGOJKt5i6RKDh4hTxw== X-Received: by 2002:a05:6870:d68e:b0:e2:861:8b15 with SMTP id z14-20020a056870d68e00b000e208618b15mr8941436oap.156.1650388601641; Tue, 19 Apr 2022 10:16:41 -0700 (PDT) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id j72-20020a9d17ce000000b005e6b89f9f54sm5589996otj.32.2022.04.19.10.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 10:16:40 -0700 (PDT) Date: Tue, 19 Apr 2022 12:16:39 -0500 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Andy Gross , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Vladimir Zapolskiy Subject: Re: [PATCH 3/3] arm64: dts: qcom: sm8450: add cooling-maps to CPU trip points Message-ID: References: <20220410234458.1739279-1-dmitry.baryshkov@linaro.org> <20220410234458.1739279-4-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220410234458.1739279-4-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun 10 Apr 18:44 CDT 2022, Dmitry Baryshkov wrote: > Follow the lead of other Qualcomm platforms and add cooling maps for CPU > trip points. Handle three clusters separately, cooling cores 0-3 for > cpu0-3 trip points, cores 4-6 for cpu4-6 trip points and only cpu7 for > cpu7 trip points. > In line with 52e3b2ca6f9d ("arm64: dts: qcom: sdm845: Remove cpufreq cooling devices for CPU thermal zones") I don't think we should have cooling-maps for platforms where LMh is already thermal throttling the CPU clusters. Picking the other two patches. Regards, Bjorn > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 191 +++++++++++++++++++++++++++ > 1 file changed, 191 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 4f3c7e7d2855..dd8ef4438fd0 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -1651,6 +1651,21 @@ cpu4_top_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu4_top_alert0>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu4_top_alert1>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu4-bottom-thermal { > @@ -1677,6 +1692,21 @@ cpu4_bottom_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu4_bottom_alert0>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu4_bottom_alert1>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu5-top-thermal { > @@ -1703,6 +1733,21 @@ cpu5_top_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu5_top_alert0>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu5_top_alert1>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu5-bottom-thermal { > @@ -1729,6 +1774,21 @@ cpu5_bottom_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu5_bottom_alert0>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu5_bottom_alert1>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu6-top-thermal { > @@ -1755,6 +1815,21 @@ cpu6_top_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu6_top_alert0>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu6_top_alert1>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu6-bottom-thermal { > @@ -1781,6 +1856,21 @@ cpu6_bottom_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu6_bottom_alert0>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu6_bottom_alert1>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu7-top-thermal { > @@ -1807,6 +1897,17 @@ cpu7_top_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu7_top_alert0>; > + cooling-device = <&CPU7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu7_top_alert1>; > + cooling-device = <&CPU7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu7-middle-thermal { > @@ -1833,6 +1934,17 @@ cpu7_middle_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu7_middle_alert0>; > + cooling-device = <&CPU7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu7_middle_alert1>; > + cooling-device = <&CPU7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu7-bottom-thermal { > @@ -1859,6 +1971,17 @@ cpu7_bottom_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu7_bottom_alert0>; > + cooling-device = <&CPU7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu7_bottom_alert1>; > + cooling-device = <&CPU7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > gpu-top-thermal { > @@ -1969,6 +2092,23 @@ cpu0_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu0_alert0>; > + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu0_alert1>; > + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu1-thermal { > @@ -1995,6 +2135,23 @@ cpu1_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu1_alert0>; > + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu1_alert1>; > + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu2-thermal { > @@ -2021,6 +2178,23 @@ cpu2_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu2_alert0>; > + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu2_alert1>; > + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cpu3-thermal { > @@ -2047,6 +2221,23 @@ cpu3_crit: cpu_crit { > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&cpu3_alert0>; > + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + map1 { > + trip = <&cpu3_alert1>; > + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&CPU3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > cdsp0-thermal { > -- > 2.35.1 >