From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
linux-omap@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
Keerthy <j-keerthy@ti.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Nishanth Menon" <nm@ti.com>, "Rob Herring" <robh+dt@kernel.org>,
"Vignesh Raghavendra" <vigneshr@ti.com>
Subject: Re: [PATCH] ARM: dts: Drop unused ti,am4372-timer compatible
Date: Fri, 8 Apr 2022 14:37:27 +0300 [thread overview]
Message-ID: <YlAed8/biRMUNqNm@atomide.com> (raw)
In-Reply-To: <e0cdf420-7a8c-e1a1-c60e-692a77b465e4@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [220408 09:31]:
>
>
> On 08/04/2022 11:33, Krzysztof Kozlowski wrote:
> > On 08/04/2022 10:29, Tony Lindgren wrote:
> > > * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [220408 08:22]:
> > > > On 08/04/2022 10:12, Tony Lindgren wrote:
> > > > > Drop unused (and undocumented) ti,am4372-timer related compatible
> > > > > properties to avoid dtb warnings when updating the binding to yaml.
> > > > >
> > > > > The dual-mode timer instances on am43 are compatible with the am3
> > > > > timers.
> > > >
> > > > Are you sure this is correct approach? Maybe some other user of DTS
> > > > references the am43 compatible, so instead it should be documented in
> > > > the bindings?
> > >
> > > No users.
> >
> > You sure you check all operating systems and all out-of-tree users? I
> > did not talk about in-kernel DTS...
Yeah you can never be quite sure :)
> > > The driver does not parse these. The am4 SoCs boot using
> > > the am3 related compatible properties.
> > >
> > > > See also recommendation "DO use fallback compatibles...":
> > > > Documentation/devicetree/bindings/writing-bindings.rst
> > > > which maybe applies here?
> > >
> > > Yes I'd agree if there were users for this, or if this was already
> > > documented :) But I don't see a need to keep these am4 specific
> > > properties.
> >
>
> I'd prefer to drop it if not used and not documented.
> conversation to yaml is good time for clean up.
> if somebody complains - can always return back and document it.
Well this will produce warnings for Krzysztof for the dt bindings branch
until it's dropped for the dts files. And since it's possible to discuss
this with arguments both ways.. Let's just keep it and document it. I just
noticed we already have few redundant compatibles with dm814 and dm816 that
are probably compatible with omap4 if rememember correctly.
Regards,
Tony
prev parent reply other threads:[~2022-04-08 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 8:12 [PATCH] ARM: dts: Drop unused ti,am4372-timer compatible Tony Lindgren
2022-04-08 8:24 ` Krzysztof Kozlowski
2022-04-08 8:29 ` Tony Lindgren
2022-04-08 8:33 ` Krzysztof Kozlowski
2022-04-08 9:33 ` Grygorii Strashko
2022-04-08 11:37 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlAed8/biRMUNqNm@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).