From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
quic_msavaliy@quicinc.com
Subject: Re: [V3 0/3] arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold
Date: Fri, 8 Apr 2022 19:18:52 -0500 [thread overview]
Message-ID: <YlDQ7GyxSSIOsHVq@builder.lan> (raw)
In-Reply-To: <CAD=FV=XieM5MHMBBV9d7jrbiN+8RVdo6=_XSNf9L-yqEZUTO_Q@mail.gmail.com>
On Wed 06 Apr 10:04 CDT 2022, Doug Anderson wrote:
> Hi,
>
> On Wed, Apr 6, 2022 at 12:16 AM Vijaya Krishna Nivarthi
> <quic_vnivarth@quicinc.com> wrote:
> >
> > WLAN rail was leaking power during RBSC/sleep even after turning BT off.
> > Change sleep pinctrl configuration to handle same.
> >
> > ---
> > v3: apply same change to active state and other sc7280*.dts* as well
> > v2: used bias-bus-hold as per review comments
> > v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only
> > ---
> >
> > Vijaya Krishna Nivarthi (3):
> > arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold
> > arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold
> > arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold
> >
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts | 12 ++++++------
> > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 12 ++++++------
> > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 13 ++++++++-----
> > 3 files changed, 20 insertions(+), 17 deletions(-)
>
> Probably the subject of all the patches should be modified to talk
> about what each patch is applying to. Having 3 identically named
> patches is not ideal.
>
> I'll let Bjorn chime in on whether he'd rather adjust the subject
> himself or whether he'd rather you re-send. In any case, with the
> subject modified then for all 3 patches:
>
I've been fixing up a ton of these during the last few releases, so I
think it's time that I stop doing that.
Please resubmit this with subject prefixes that matches the existing git
log for each change.
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Thanks,
Bjorn
prev parent reply other threads:[~2022-04-09 0:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 7:15 [V3 0/3] arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold Vijaya Krishna Nivarthi
2022-04-06 7:16 ` [V3 1/3] " Vijaya Krishna Nivarthi
2022-04-06 7:16 ` [V3 2/3] " Vijaya Krishna Nivarthi
2022-04-06 7:16 ` [V3 3/3] " Vijaya Krishna Nivarthi
2022-04-06 15:04 ` [V3 0/3] " Doug Anderson
2022-04-09 0:18 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlDQ7GyxSSIOsHVq@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vnivarth@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).