From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F1C6C433FE for ; Sat, 9 Apr 2022 00:25:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235027AbiDIA1j (ORCPT ); Fri, 8 Apr 2022 20:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232506AbiDIA1j (ORCPT ); Fri, 8 Apr 2022 20:27:39 -0400 Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A41818E1C for ; Fri, 8 Apr 2022 17:25:34 -0700 (PDT) Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-de3ca1efbaso11411482fac.9 for ; Fri, 08 Apr 2022 17:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CvlOdjB3+vMb6WfMdUSPA5S26ij9hqMmlmfhzTzVzxI=; b=wZhHDtzhnnFaf/Z3RS31qNESt7qcuJ96Rnd3jTFaDL1H9hwO4HauDN+NBCDXbKvxbY PBMrtdLGVWur2kZ+wwhZhuU9mrOOTBI68t5QJcUenc+v6UUeKfIg/UWDsfLAA4Ux+Jy4 r8Zwk85YlaNSVA0LAcJfTI4ITooqyL0Rg7F2/He1XjFHlEDTlNMmg+m1olhpWeg9HWJ+ oQy9pweBwsXh/H3G9qfcS+I5gEj6ik2W1AoXsW5SbhZPhfVmPoLu7W6+GVT/Vg+14/NA 6HmlJ2Fk5EweDNg50moxn0BC6RSmKiTBBToM7DH3uG1Mq/b3yErXPR+gDGZp0pN3z2ii rQCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CvlOdjB3+vMb6WfMdUSPA5S26ij9hqMmlmfhzTzVzxI=; b=kcKvVbbQDovgAKGTBeF7Kdq5c/nsKB7ZQtXqv+zwykayDQ5nh+X/PXf1ZlZ44feaBk aLqjBl5+hcdAYy2ypq86Y2P7MjREKTi2utnfI2F6JX2xcrcmEDvF/C69xW5fDUXvS6wB I6MpHrR2zK2tnNkO79938BzsO+4y289hF5wQdgU06OAfYKuKhLAKtXiFrIiux7zIgXRN FqpWnV08c0he8ScP1DAESOUVg4zdqS6LKf1FqX2+hBCym8mFgY0pMTp9FS1ryVVDQj9y vhyPkpMCb+7gyuwbHkCf0lBjW9y1O060a/2rmzfakvGgav3VaGuCMsGjR4qdMk56DRPN bakQ== X-Gm-Message-State: AOAM5326QxONNF3+wjti5uCWWbpFwofV+ELFjDD1Sz4fyAA68Zz1o8Da 1ooFn8tlwRGiP28vcr5aMML0eA== X-Google-Smtp-Source: ABdhPJzbsFxjcWZN1TMqg+51RtfqLPl+jfoL9LAzWFSbkcgl9I40vmhI7hD5QVaapMbQwBJuKnO8Ew== X-Received: by 2002:a05:6870:51cd:b0:e2:6cd2:f21a with SMTP id b13-20020a05687051cd00b000e26cd2f21amr4621573oaj.7.1649463933469; Fri, 08 Apr 2022 17:25:33 -0700 (PDT) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id m17-20020a0568301e7100b005b256697d7csm9587232otr.72.2022.04.08.17.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 17:25:32 -0700 (PDT) Date: Fri, 8 Apr 2022 19:25:30 -0500 From: Bjorn Andersson To: Vinod Koul Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, Rob Herring , Andy Gross , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] arm64: dts: qcom: sm8250: move sound node out of soc Message-ID: References: <20220328143035.519909-1-vkoul@kernel.org> <20220328143035.519909-5-vkoul@kernel.org> <3cc9c1a0-45f3-cb1b-1991-f51da4789afd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon 28 Mar 12:14 CDT 2022, Vinod Koul wrote: > On 28-03-22, 17:14, Krzysztof Kozlowski wrote: > > On 28/03/2022 16:30, Vinod Koul wrote: > > > The soc node expects all the nodes to have unit addresses. The sound > > > node does not have that which causes warnings: > > > > > > arch/arm64/boot/dts/qcom/sm8250.dtsi:2806.16-2807.5: > > > Warning (simple_bus_reg): /soc@0/sound: missing or empty reg/ranges property > > > > > > Move sound node out of soc to fix this > > > > > > Signed-off-by: Vinod Koul > > > --- > > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > I don't know the SM8250, but usually the sound node (e.g. containing > > audio-codec) is not part of SoC. I propose to remove it entirely from > > DTSI and define in same place in each DTS. It makes more sense logically > > in such case - one clearly see which board defines the sounds, which > > does not. > > Most of our boards have sound, should we duplicate it in all the > boards..? Bjorn..? > But is the sndcard platform or device specific? E.g. all the SDM845 boards seems to use either qcom,sdm845-sndcard or qcom,db845c-sndcard. Are there room for some common properties in this node? Otherwise it seems reasonable to skip it in the platform dtsi. Regards, Bjorn