From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CC7C433EF for ; Sat, 9 Apr 2022 20:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243149AbiDIUiZ (ORCPT ); Sat, 9 Apr 2022 16:38:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231560AbiDIUiY (ORCPT ); Sat, 9 Apr 2022 16:38:24 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D89E824F16 for ; Sat, 9 Apr 2022 13:36:15 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id h19so11346174pfv.1 for ; Sat, 09 Apr 2022 13:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ToaemIh0N/ictNMTY6+8rwYpqhr7q8UZjVORvPQt/1Y=; b=VrFx9bSfQ+cfWs6cBGHXR9DrCWbguRAu9pGUcToAoFl0OMrWqmJrS4UZ8HJrm1XmlA ON6bJiMXpSqwUItF6z5n1hBhNbWDRowvH/6ptVky3daXm/LYeOUiLh9B/kmy52D/tDaQ mNlpDgQNKap2oxboEiwlJZW+uUqOQl13LxJclL2yUwQ/Q4dbHeUn7crvm8cNtb0pCJgN RLO7nskSGcQIbgp9QjWq7akVn3HeobMjuCoG9VJkZ7UBfmLj4VnQ1kCoZ6Ec4FI7NPxc JIYY8AF+i9HLJkdXfbfYR0bSwEEmW9Cz7Ca7opz7Q/mYdsMbL+/C6JNXYStCUjBzGZ9d A65w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ToaemIh0N/ictNMTY6+8rwYpqhr7q8UZjVORvPQt/1Y=; b=FJIVfaAd83suCh5YJiKPMFSvPMHsQoAkM+qGQHU5t65OzWbPFbahynsTpJkuO6gw+3 eoxu366EjlHIRSQS61JLPTyiM2mDWxXClfZN7AnSC5Vx6sP0E97zoJFjIAlMPkSBzl39 m6rEHzbpSv50tpdxXRwLCFr+nz+ejXz1PG01oppFtBIjdwsiaRKQFGn28IKiuSrtPdts ixb7i4mgtzWeK5QozN6t9HFf2QMTYXoeARPZiBqKaTK/rFfOFpr55CQL2LYKzq03Tv6Z PQtY0m2p7VsYL4BooSR6NxkrdQvPfkRx5hdK7toxaC3fB6PxdFMLK3qzg5t4Lt7PueVv o8zQ== X-Gm-Message-State: AOAM532gO0myZ1E4KO7fBH3QEnwHf7bxTKMKYXj+8zZYFVhtTasH6Nam ssc9bx/rK5bBtI2oWcuOa/x9jA== X-Google-Smtp-Source: ABdhPJw/rmDw7bqHCMDpzikztX0oH3Td8uC+JRWeVwaLpimkoupGZubMwy2iGBHTimSdAcvPSSyFzQ== X-Received: by 2002:a62:6dc3:0:b0:505:895a:d38b with SMTP id i186-20020a626dc3000000b00505895ad38bmr9336064pfc.7.1649536575239; Sat, 09 Apr 2022 13:36:15 -0700 (PDT) Received: from x1 ([2601:1c2:1001:7090:925c:1a60:e433:31b7]) by smtp.gmail.com with ESMTPSA id x17-20020a17090ab01100b001ca8458964esm15629780pjq.18.2022.04.09.13.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Apr 2022 13:36:14 -0700 (PDT) Date: Sat, 9 Apr 2022 13:37:01 -0700 From: Drew Fustini To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Santosh Shilimkar , Dave Gerlach , Tony Lindgren , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle bindings Message-ID: References: <20220409045145.2434096-1-dfustini@baylibre.com> <20220409045145.2434096-2-dfustini@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Apr 09, 2022 at 06:25:24PM +0200, Krzysztof Kozlowski wrote: > On 09/04/2022 06:51, Drew Fustini wrote: > > Document the Wakeup M3 IPC properties that can be used to toggle the VTT > > regulator during low power mode transitions. > > > > (...) > > > @@ -51,6 +61,15 @@ properties: > > mbox_wkupm3 child node. > > maxItems: 1 > > > > + ti,needs-vtt-toggle: > > + type: boolean > > + description: boards requires VTT toggling during suspend/resume > > + > > + ti,vtt-gpio-pin: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: pin on the GPIO0 module used for VTT toggle > > + maxItems: 1 > > No need for maxItems, it's a single uint32. You could add "maximum" if > you know the constraints for the value. Thank you for letting me know. > Do you actually need two properties (bool + pin)? A case of > "ti,vtt-gpio-pin" without the "ti,needs-vtt-toggle" is valid? You raise a good point. In fact, the driver does nothing useful in the case of "ti,needs-vtt-toggle" without "ti,vtt-gpio-pin". Therefore, I will remove the "ti,needs-vtt-toggle" property. > > The other way looks wrong, so you need to add a dependency (see > example-schema). > > > Best regards, > Krzysztof Thank you, Drew